drivers: thermal: Remove ARCH_HAS_BANDGAP dependency for samsung

PATCH New Abhilash Kesavan 5 participants 8 messages Dec 2, 2014 – Dec 10, 2014

Subsystems (5)

Arm (32-bit) Arm sub-architectures Arm Samsung Exynos Thermal +1 more subsystems

lore

Share & tools

lore

Abhilash Kesavan

author

2014-12-02 06:34 UTC #0 lore raw

PATCH 1/2 drivers: thermal: Remove ARCH_HAS_BANDGAP dependency for samsung

As samsung thermal support is enabled only for ARCH_EXYNOS, there is no need to select ARCH_HAS_BANDGAP from the arch-specific code. Removing this dependency will also allow the driver to be enabled on 64-bit SoCs.

Signed-off-by Abhilash Kesavan <[email protected]>

---
This was based on the discussion regarding adding ARCH_HAS_BANDGAP symbol for arm64 here: http://www.spinics.net/lists/arm-kernel/msg377560.html

 drivers/thermal/samsung/Kconfig |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

drivers/thermal/samsung/Kconfig +1 -1

index f760389..c43306e 100644
@@ -1,6 +1,6 @@
 config EXYNOS_THERMAL
 	tristate "Exynos thermal management unit driver"
-	depends on ARCH_HAS_BANDGAP && OF
+	depends on OF
 	help
 	  If you say yes here you get support for the TMU (Thermal Management
 	  Unit) driver for SAMSUNG EXYNOS series of SoCs. This driver initialises

Signature · 1 line

1.7.9.5

Abhilash Kesavan

author

2014-12-02 06:34 UTC #1 lore raw

PATCH 2/2 ARM: EXYNOS: Remove ARCH_HAS_BANDGAP selection

On removing the samsung thermal driver dependency on ARCH_HAS_BANDGAP, selection of this symbol becomes redundant.

Signed-off-by Abhilash Kesavan <[email protected]>

---
 arch/arm/mach-exynos/Kconfig |    1 -
 1 file changed, 1 deletion(-)

arch/arm/mach-exynos/Kconfig +0 -1

index e4a00ba..6ddfce7 100644
@@ -9,7 +9,6 @@
 
 menuconfig ARCH_EXYNOS
 	bool "Samsung EXYNOS" if ARCH_MULTI_V7
-	select ARCH_HAS_BANDGAP
 	select ARCH_HAS_HOLES_MEMORYMODEL
 	select ARCH_REQUIRE_GPIOLIB
 	select ARM_AMBA

Signature · 1 line

1.7.9.5

Bartlomiej Zolnierkiewicz

2014-12-02 14:23 UTC #2 lore raw

PATCH 2/2 ARM: EXYNOS: Remove ARCH_HAS_BANDGAP selection

Hi,

Quoted 4 lines · Abhilash Kesavan

On removing the samsung thermal driver dependency on ARCH_HAS_BANDGAP, selection of this symbol becomes redundant.
Signed-off-by Abhilash Kesavan <[email protected]>

This has also a nice side-effect of removing TI_SOC_THERMAL availability from Exynos only kernel configurations.

Reviewed-by Bartlomiej Zolnierkiewicz <[email protected]>

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics

Quoted 16 lines

---
 arch/arm/mach-exynos/Kconfig |    1 -
 1 file changed, 1 deletion(-)

arch/arm/mach-exynos/Kconfig +0 -1

index e4a00ba..6ddfce7 100644
@@ -9,7 +9,6 @@
 
 menuconfig ARCH_EXYNOS
 	bool "Samsung EXYNOS" if ARCH_MULTI_V7
-	select ARCH_HAS_BANDGAP
 	select ARCH_HAS_HOLES_MEMORYMODEL
 	select ARCH_REQUIRE_GPIOLIB
 	select ARM_AMBA

Lukasz Majewski

2014-12-08 09:44 UTC #3 lore raw

PATCH 2/2 ARM: EXYNOS: Remove ARCH_HAS_BANDGAP selection

In reply to Abhilash Kesavan

Hi Abhilash,

Quoted 13 lines

On removing the samsung thermal driver dependency on ARCH_HAS_BANDGAP, selection of this symbol becomes redundant.
Signed-off-by Abhilash Kesavan <[email protected]>
---
 arch/arm/mach-exynos/Kconfig |    1 -
 1 file changed, 1 deletion(-)
(quoted diff) +0 -0
b/arch/arm/mach-exynos/Kconfig index e4a00ba..6ddfce7 100644

arch/arm/mach-exynos/Kconfig line 14

Quoted 7 lines

arch/arm/mach-exynos/Kconfig +0 -1

@@ -9,7 +9,6 @@
 
 menuconfig ARCH_EXYNOS
 	bool "Samsung EXYNOS" if ARCH_MULTI_V7
-	select ARCH_HAS_BANDGAP
 	select ARCH_HAS_HOLES_MEMORYMODEL
 	select ARCH_REQUIRE_GPIOLIB
 	select ARM_AMBA

Acked-by Lukasz Majewski <[email protected]>

Signature · 5 lines

Best regards,

Lukasz Majewski

Samsung R&D Institute Poland (SRPOL) | Linux Platform Group

Bartlomiej Zolnierkiewicz

2014-12-02 14:17 UTC #4 lore raw

PATCH 1/2 drivers: thermal: Remove ARCH_HAS_BANDGAP dependency for samsung

In reply to Abhilash Kesavan

Hi,

Quoted 8 lines · Abhilash Kesavan

As samsung thermal support is enabled only for ARCH_EXYNOS, there is no need to select ARCH_HAS_BANDGAP from the arch-specific code. Removing this dependency will also allow the driver to be enabled on 64-bit SoCs.
Signed-off-by Abhilash Kesavan <[email protected]>
---
This was based on the discussion regarding adding ARCH_HAS_BANDGAP symbol for arm64 here: http://www.spinics.net/lists/arm-kernel/msg377560.html

Reviewed-by Bartlomiej Zolnierkiewicz <[email protected]>

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics

Quoted 15 lines

 drivers/thermal/samsung/Kconfig |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

drivers/thermal/samsung/Kconfig +1 -1

index f760389..c43306e 100644
@@ -1,6 +1,6 @@
 config EXYNOS_THERMAL
 	tristate "Exynos thermal management unit driver"
-	depends on ARCH_HAS_BANDGAP && OF
+	depends on OF
 	help
 	  If you say yes here you get support for the TMU (Thermal Management
 	  Unit) driver for SAMSUNG EXYNOS series of SoCs. This driver initialises

Lukasz Majewski

2014-12-08 09:43 UTC #5 lore raw

PATCH 1/2 drivers: thermal: Remove ARCH_HAS_BANDGAP dependency for samsung

In reply to Abhilash Kesavan

Hi Abhilash,

Quoted 25 lines

As samsung thermal support is enabled only for ARCH_EXYNOS, there is no need to select ARCH_HAS_BANDGAP from the arch-specific code. Removing this dependency will also allow the driver to be enabled on 64-bit SoCs.
Signed-off-by Abhilash Kesavan <[email protected]>
---
This was based on the discussion regarding adding ARCH_HAS_BANDGAP symbol for arm64 here:
http://www.spinics.net/lists/arm-kernel/msg377560.html
 drivers/thermal/samsung/Kconfig |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
(quoted diff) +0 -0
b/drivers/thermal/samsung/Kconfig index f760389..c43306e 100644
drivers/thermal/samsung/Kconfig +1 -1
@@ -1,6 +1,6 @@
 config EXYNOS_THERMAL
 	tristate "Exynos thermal management unit driver"
-	depends on ARCH_HAS_BANDGAP && OF
+	depends on OF
 	help
 	  If you say yes here you get support for the TMU (Thermal

Quoted 2 lines

Management Unit) driver for SAMSUNG EXYNOS series of SoCs. This driver initialises

Reviewed-by Lukasz Majewski <[email protected]>

Acked-by Lukasz Majewski <[email protected]>

Signature · 5 lines

Best regards,

Lukasz Majewski

Samsung R&D Institute Poland (SRPOL) | Linux Platform Group

Abhilash Kesavan

2014-12-10 03:56 UTC #6 lore raw

PATCH 1/2 drivers: thermal: Remove ARCH_HAS_BANDGAP dependency for samsung

Hi Eduardo,

Quoted 16 lines · Lukasz Majewski

Hi Abhilash,
Quoted 14 lines
As samsung thermal support is enabled only for ARCH_EXYNOS, there is no need to select ARCH_HAS_BANDGAP from the arch-specific code. Removing this dependency will also allow the driver to be enabled on 64-bit SoCs.
Signed-off-by Abhilash Kesavan <[email protected]>
---
This was based on the discussion regarding adding ARCH_HAS_BANDGAP symbol for arm64 here:
http://www.spinics.net/lists/arm-kernel/msg377560.html
 drivers/thermal/samsung/Kconfig |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Quoted 16 lines

Quoted 11 lines
(quoted diff) +0 -0
b/drivers/thermal/samsung/Kconfig index f760389..c43306e 100644
drivers/thermal/samsung/Kconfig +1 -1
@@ -1,6 +1,6 @@
 config EXYNOS_THERMAL
      tristate "Exynos thermal management unit driver"
-     depends on ARCH_HAS_BANDGAP && OF
+     depends on OF
      help
        If you say yes here you get support for the TMU (Thermal
Quoted 2 lines
Management Unit) driver for SAMSUNG EXYNOS series of SoCs. This driver initialises
Reviewed-by Lukasz Majewski <[email protected]>
Acked-by Lukasz Majewski <[email protected]>

Can you pick up these 2 patches if they look OK ?

Regards,
Abhilash

Quoted 7 lines

--
Best regards,
Lukasz Majewski
Samsung R&D Institute Poland (SRPOL) | Linux Platform Group

Eduardo Valentin

2014-12-10 14:41 UTC #7 lore raw

PATCH 1/2 drivers: thermal: Remove ARCH_HAS_BANDGAP dependency for samsung

Quoted 36 lines · Abhilash Kesavan

Hi Eduardo,
Quoted 16 lines · Lukasz Majewski
Hi Abhilash,
Quoted 14 lines
As samsung thermal support is enabled only for ARCH_EXYNOS, there is no need to select ARCH_HAS_BANDGAP from the arch-specific code. Removing this dependency will also allow the driver to be enabled on 64-bit SoCs.
Signed-off-by Abhilash Kesavan <[email protected]>
---
This was based on the discussion regarding adding ARCH_HAS_BANDGAP symbol for arm64 here:
http://www.spinics.net/lists/arm-kernel/msg377560.html
 drivers/thermal/samsung/Kconfig |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Quoted 16 lines
Quoted 11 lines
(quoted diff) +0 -0
b/drivers/thermal/samsung/Kconfig index f760389..c43306e 100644
drivers/thermal/samsung/Kconfig +1 -1
@@ -1,6 +1,6 @@
 config EXYNOS_THERMAL
      tristate "Exynos thermal management unit driver"
-     depends on ARCH_HAS_BANDGAP && OF
+     depends on OF
      help
        If you say yes here you get support for the TMU (Thermal
Quoted 2 lines
Management Unit) driver for SAMSUNG EXYNOS series of SoCs. This driver initialises
Reviewed-by Lukasz Majewski <[email protected]>
Acked-by Lukasz Majewski <[email protected]>

Quoted 1 line

Can you pick up these 2 patches if they look OK ?

OK. Adding to my fixes queue.

Quoted 10 lines

Regards,
Abhilash
Quoted 7 lines
--
Best regards,
Lukasz Majewski
Samsung R&D Institute Poland (SRPOL) | Linux Platform Group

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20141210/373a3a28/attachment.sig>