Skip to contentSkip to conversation

pinentry: bump version to 0.9.0

PATCH New Vicente Olivert Riera 3 participants 10 messages Nov 28, 2014 – Dec 8, 2014

lore
Share & tools
lore

Vicente Olivert Riera

author
#0 lore raw

PATCH 1/1 pinentry: bump version to 0.9.0

- Bump version to 0.9.0
- Add a hash file

Signed-off-by Vicente Olivert Riera <[email protected]>
---
 package/pinentry/pinentry.hash |    2 ++
 package/pinentry/pinentry.mk   |    2 +-
 2 files changed, 3 insertions(+), 1 deletions(-)
 create mode 100644 package/pinentry/pinentry.hash
package/pinentry/pinentry.hash new file +2 -0
new file mode 100644
index 0000000..851c721
@@ -0,0 +1,2 @@
+# From https://www.gnupg.org/download/integrity_check.html
+sha1  f8e5c774c35fbb91d84e82559baf76f6b4513236  pinentry-0.9.0.tar.bz2
package/pinentry/pinentry.mk +1 -1
index 39358a7..56e8e71 100644
@@ -4,7 +4,7 @@
 #
 ################################################################################
 
-PINENTRY_VERSION = 0.8.3
+PINENTRY_VERSION = 0.9.0
 PINENTRY_SOURCE = pinentry-$(PINENTRY_VERSION).tar.bz2
 PINENTRY_SITE = ftp://ftp.gnupg.org/gcrypt/pinentry
 PINENTRY_LICENSE = GPLv2+
Signature · 1 line
1.7.1
#1 lore raw

PATCH 1/1 pinentry: bump version to 0.9.0

Vicente, All,

On 2014-11-28 16:09 +0000, Vicente Olivert Riera spake thusly:

Quoted 4 lines

- Bump version to 0.9.0
- Add a hash file

Signed-off-by Vicente Olivert Riera <[email protected]>

Manually downloaded and manually verified the hash

Reviewed-by "Yann E. MORIN" <[email protected]>

Regards,
Yann E. MORIN.

Quoted 34 lines
---
 package/pinentry/pinentry.hash |    2 ++
 package/pinentry/pinentry.mk   |    2 +-
 2 files changed, 3 insertions(+), 1 deletions(-)
 create mode 100644 package/pinentry/pinentry.hash
package/pinentry/pinentry.hash new file +2 -0
new file mode 100644
index 0000000..851c721
@@ -0,0 +1,2 @@
+# From https://www.gnupg.org/download/integrity_check.html
+sha1  f8e5c774c35fbb91d84e82559baf76f6b4513236  pinentry-0.9.0.tar.bz2
package/pinentry/pinentry.mk +1 -1
index 39358a7..56e8e71 100644
@@ -4,7 +4,7 @@
 #
 ################################################################################
 
-PINENTRY_VERSION = 0.8.3
+PINENTRY_VERSION = 0.9.0
 PINENTRY_SOURCE = pinentry-$(PINENTRY_VERSION).tar.bz2
 PINENTRY_SITE = ftp://ftp.gnupg.org/gcrypt/pinentry
 PINENTRY_LICENSE = GPLv2+
Signature · 6 lines
1.7.1

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
Signature · 13 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20141207/c877dede/attachment.asc>
Applied
#2 lore raw

PATCH 1/1 pinentry: bump version to 0.9.0

In reply to Vicente Olivert Riera

Dear Vicente Olivert Riera,

Quoted 9 lines · Vicente Olivert Riera

- Bump version to 0.9.0
- Add a hash file

Signed-off-by Vicente Olivert Riera <[email protected]>
---
 package/pinentry/pinentry.hash |    2 ++
 package/pinentry/pinentry.mk   |    2 +-
 2 files changed, 3 insertions(+), 1 deletions(-)
 create mode 100644 package/pinentry/pinentry.hash

Applied, thanks.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
#3 lore raw

PATCH 1/1 pinentry: bump version to 0.9.0

In reply to Vicente Olivert Riera

Dear Vicente Olivert Riera,

Quoted 9 lines · Vicente Olivert Riera

- Bump version to 0.9.0
- Add a hash file

Signed-off-by Vicente Olivert Riera <[email protected]>
---
 package/pinentry/pinentry.hash |    2 ++
 package/pinentry/pinentry.mk   |    2 +-
 2 files changed, 3 insertions(+), 1 deletions(-)
 create mode 100644 package/pinentry/pinentry.hash

Apparently causes some build failures:
http://autobuild.buildroot.org/results/314/314de324a09f64f8b95882ca169c77847d75680c/build-end.log.

Can you have a look?

Thanks!

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
author
#4 lore raw

PATCH 1/1 pinentry: bump version to 0.9.0

Quoted 13 lines · Thomas Petazzoni

Dear Vicente Olivert Riera,

Quoted 9 lines · Vicente Olivert Riera

- Bump version to 0.9.0
- Add a hash file

Signed-off-by Vicente Olivert Riera <[email protected]>
---
 package/pinentry/pinentry.hash |    2 ++
 package/pinentry/pinentry.mk   |    2 +-
 2 files changed, 3 insertions(+), 1 deletions(-)
 create mode 100644 package/pinentry/pinentry.hash
Quoted 9 lines

Apparently causes some build failures:
http://autobuild.buildroot.org/results/314/314de324a09f64f8b95882ca169c77847d75680c/build-end.log.

Can you have a look?

Thanks!

Thomas

Sure, I will have a look at it now :-)

Cheers,

Signature · 5 lines
Vicente Olivert Riera
Graduate Software Engineer, MIPS Platforms
Imagination Technologies Limited
t: +44 (0)113 2429814
www.imgtec.com
author
#5 lore raw

PATCH 1/1 pinentry: bump version to 0.9.0

Dear Thomas Petazzoni,

Quoted 19 lines · Vicente Olivert Riera
Quoted 18 lines · Thomas Petazzoni

Dear Vicente Olivert Riera,

Quoted 9 lines · Vicente Olivert Riera

- Bump version to 0.9.0
- Add a hash file

Signed-off-by Vicente Olivert Riera <[email protected]>
---
 package/pinentry/pinentry.hash |    2 ++
 package/pinentry/pinentry.mk   |    2 +-
 2 files changed, 3 insertions(+), 1 deletions(-)
 create mode 100644 package/pinentry/pinentry.hash

Apparently causes some build failures:
http://autobuild.buildroot.org/results/314/314de324a09f64f8b95882ca169c77847d75680c/build-end.log.

Can you have a look?

Quoted 9 lines
Quoted 4 lines

Thanks!

Thomas

Sure, I will have a look at it now :-)

Cheers,

it was a problem when building pinentry-qt4, which needs to have support for Qt accessibility. Qt accessibility is enabled by default on Qt, but we disable it in Buildroot by passing "-no-accessibility" to the configure script. I don't know why we do that. There is no comment in the .mk file.

When you fix that, you face another problem which is not related with us (Buildroot) but a mistake (that's my opinion) made by the person who released the pinentry tarball. I have reported the issue upstream and written a patch for Buildroot in the meantime.

While I was working on all of this, I noticed that the options we had for disablen pinentry-gtk1 and pinentry-qt3 where no longer needed since those options don't exist anymore in the configure script, and the directories gtk and qt don't exist either when you unpack the tarball.

Path sent:
http://patchwork.ozlabs.org/patch/418743/

Cheers,

Signature · 5 lines
Vicente Olivert Riera
Graduate Software Engineer, MIPS Platforms
Imagination Technologies Limited
t: +44 (0)113 2429814
www.imgtec.com
#6 lore raw

PATCH 1/1 pinentry: bump version to 0.9.0

Dear Vicente Olivert Riera,

Quoted 5 lines · Vicente Olivert Riera

it was a problem when building pinentry-qt4, which needs to have support for Qt accessibility. Qt accessibility is enabled by default on Qt, but we disable it in Buildroot by passing "-no-accessibility" to the configure script. I don't know why we do that. There is no comment in the .mk file.

Simply because many people probably don't need it, and therefore we disabled it by default, waiting for someone who needs it to add an option for it.

Quoted 5 lines

When you fix that, you face another problem which is not related with us (Buildroot) but a mistake (that's my opinion) made by the person who released the pinentry tarball. I have reported the issue upstream and written a patch for Buildroot in the meantime.

Quoted 7 lines

While I was working on all of this, I noticed that the options we had for disablen pinentry-gtk1 and pinentry-qt3 where no longer needed since those options don't exist anymore in the configure script, and the directories gtk and qt don't exist either when you unpack the tarball.

Path sent:
http://patchwork.ozlabs.org/patch/418743/

The accessibility part should be made optional.

Best regards,

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
author
#7 lore raw

PATCH 1/1 pinentry: bump version to 0.9.0

Dear Thomas Petazzoni,

Quoted 24 lines · Thomas Petazzoni

Dear Vicente Olivert Riera,

Quoted 5 lines · Vicente Olivert Riera

it was a problem when building pinentry-qt4, which needs to have support for Qt accessibility. Qt accessibility is enabled by default on Qt, but we disable it in Buildroot by passing "-no-accessibility" to the configure script. I don't know why we do that. There is no comment in the .mk file.

Simply because many people probably don't need it, and therefore we disabled it by default, waiting for someone who needs it to add an option for it.

Quoted 10 lines

When you fix that, you face another problem which is not related with us (Buildroot) but a mistake (that's my opinion) made by the person who released the pinentry tarball. I have reported the issue upstream and written a patch for Buildroot in the meantime.

While I was working on all of this, I noticed that the options we had for disablen pinentry-gtk1 and pinentry-qt3 where no longer needed since those options don't exist anymore in the configure script, and the directories gtk and qt don't exist either when you unpack the tarball.

Quoted 4 lines
Quoted 2 lines

Path sent:
http://patchwork.ozlabs.org/patch/418743/

The accessibility part should be made optional.

I can send a patch to pinentry to make the accessibility part optional. Do you prefer I mark my current patch as rejected and do another one including the patch for making the accessibility part optional instead of modifying packages/qt/qt.mk?

Cheers,

Signature · 5 lines
Vicente Olivert Riera
Graduate Software Engineer, MIPS Platforms
Imagination Technologies Limited
t: +44 (0)113 2429814
www.imgtec.com
#8 lore raw

PATCH 1/1 pinentry: bump version to 0.9.0

Dear Vicente Olivert Riera,

Quoted 4 lines · Vicente Olivert Riera

I can send a patch to pinentry to make the accessibility part optional. Do you prefer I mark my current patch as rejected and do another one including the patch for making the accessibility part optional instead of modifying packages/qt/qt.mk?

I was suggesting to make the accessibility feature in Qt optional, and then have the pinentry package select this option in Qt.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
author
#9 lore raw

PATCH 1/1 pinentry: bump version to 0.9.0

Dear Thomas Petazzoni,

Quoted 11 lines · Thomas Petazzoni

Dear Vicente Olivert Riera,

Quoted 4 lines · Vicente Olivert Riera

I can send a patch to pinentry to make the accessibility part optional. Do you prefer I mark my current patch as rejected and do another one including the patch for making the accessibility part optional instead of modifying packages/qt/qt.mk?

I was suggesting to make the accessibility feature in Qt optional, and then have the pinentry package select this option in Qt.

Well..., that's another valid option, yes, but I prefer to fix pinentry upstream and leave the qt package as is. I have sent a patch for that:

http://lists.gnupg.org/pipermail/gnupg-devel/2014-December/029182.html

Let's see if it gets merged soon and we can backport it.

Cheers,

Signature · 5 lines
Vicente Olivert Riera
Graduate Software Engineer, MIPS Platforms
Imagination Technologies Limited
t: +44 (0)113 2429814
www.imgtec.com