usb: dwc3: add DWC3_SKIP_USB3PHY and DWC3_SKIP_USB2_PHY quirks
Hi list,
On platforms which has native usb hosts/phys and pci-dwc3 controller, the dwc3 core may get the wrong usb2_phy and usb3_phy by devm_usb_get_phy(). It depends on which usb phy driver is initialized firstly, the usb_phy_generic or the native/real usb phy driver.
Before all old USB phy library usage removed, the solution I can have is to add DWC3_SKIP_USB3PHY and DWC3_SKIP_USB2_PHY quirks and set them in dwc3-pci. Could such modification can be accepted? If not, could you please give alternative suggestions?
Thanks,
Jisheng
Hi,
Quoted 4 lines · Jisheng Zhang
On platforms which has native usb hosts/phys and pci-dwc3 controller, the dwc3 core may get the wrong
usb2_phyandusb3_phybydevm_usb_get_phy(). It depends on which usb phy driver is initialized firstly, theusb_phy_genericor the native/real usb phy driver.
why are you initializing generic PHY if you have a real PHY ?
Quoted 5 lines
Before all old USB phy library usage removed, the solution I can have is to add
DWC3_SKIP_USB3PHYandDWC3_SKIP_USB2_PHYquirks and set them in dwc3-pci.
Could such modification can be accepted? If not, could you please give alternative suggestions?
we will not accept a quirk to skip PHYs, sorry. A better way of handling this needs to be found.
Signature · 8 lines
balbi -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 819 bytes Desc: Digital signature URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20150108/98e36480/attachment.sig>
Hi Felipe,
Quoted 9 lines · On Thu, 8 Jan 2015 09:08:15 -0800 Felipe Balbi <[email protected]> wrote:
Hi,
Quoted 4 lines · Jisheng Zhang
On platforms which has native usb hosts/phys and pci-dwc3 controller, the dwc3 core may get the wrong
usb2_phyandusb3_phybydevm_usb_get_phy(). It depends on which usb phy driver is initialized firstly, theusb_phy_genericor the native/real usb phy driver.why are you initializing generic PHY if you have a real PHY ?
we have two kind of usb hosts: the native usb hosts which can be probed via. DT and the usb hosts from pci-dwc3. The former has real phy and the latter doesn't.
Quoted 10 lines
Quoted 6 lines
Before all old USB phy library usage removed, the solution I can have is to add
DWC3_SKIP_USB3PHYandDWC3_SKIP_USB2_PHYquirks and set them in dwc3-pci.
Could such modification can be accepted? If not, could you please give alternative suggestions?we will not accept a quirk to skip PHYs, sorry. A better way of handling this needs to be found.
OK, Got your points. It seems we need to deprecate old usb phy library usage early.
Thanks,
Jisheng