Add USB device 04ca:3010 as Athoros AR3012

PATCH In review Janne Heikkinen 2 participants 6 messages Dec 9, 2014 Bluetooth drivers

lore

Share & tools

lore

Janne Heikkinen

author

2014-12-09 06:05 UTC #0 lore raw

PATCH 1/1 Add USB device 04ca:3010 as Athoros AR3012

Asus X553MA has USB device 04ca:3010 that is Athoros AR3012 or compatible.

Signed-off-by Janne Heikkinen <[email protected]>

---
 drivers/bluetooth/ath3k.c | 2 ++
 drivers/bluetooth/btusb.c | 1 +
 2 files changed, 3 insertions(+)

drivers/bluetooth/ath3k.c +2 -0

index d85ced2..74dd27a 100644
@@ -86,6 +86,7 @@ static const struct usb_device_id ath3k_table[] = {
 	{ USB_DEVICE(0x04CA, 0x3007) },
 	{ USB_DEVICE(0x04CA, 0x3008) },
 	{ USB_DEVICE(0x04CA, 0x300b) },
+	{ USB_DEVICE(0x04CA, 0x3010) },
 	{ USB_DEVICE(0x0930, 0x0219) },
 	{ USB_DEVICE(0x0930, 0x0220) },
 	{ USB_DEVICE(0x0930, 0x0227) },

@@ -137,6 +138,7 @@ static const struct usb_device_id ath3k_blist_tbl[] = {
 	{ USB_DEVICE(0x04ca, 0x3007), .driver_info = BTUSB_ATH3012 },
 	{ USB_DEVICE(0x04ca, 0x3008), .driver_info = BTUSB_ATH3012 },
 	{ USB_DEVICE(0x04ca, 0x300b), .driver_info = BTUSB_ATH3012 },
+	{ USB_DEVICE(0x04ca, 0x3010), .driver_info = BTUSB_ATH3012 },
 	{ USB_DEVICE(0x0930, 0x0219), .driver_info = BTUSB_ATH3012 },
 	{ USB_DEVICE(0x0930, 0x0220), .driver_info = BTUSB_ATH3012 },
 	{ USB_DEVICE(0x0930, 0x0227), .driver_info = BTUSB_ATH3012 },

drivers/bluetooth/btusb.c +1 -0

index edfc17b..edbd365 100644
@@ -163,6 +163,7 @@ static const struct usb_device_id blacklist_table[] = {
 	{ USB_DEVICE(0x04ca, 0x3007), .driver_info = BTUSB_ATH3012 },
 	{ USB_DEVICE(0x04ca, 0x3008), .driver_info = BTUSB_ATH3012 },
 	{ USB_DEVICE(0x04ca, 0x300b), .driver_info = BTUSB_ATH3012 },
+	{ USB_DEVICE(0x04ca, 0x3010), .driver_info = BTUSB_ATH3012 },
 	{ USB_DEVICE(0x0930, 0x0219), .driver_info = BTUSB_ATH3012 },
 	{ USB_DEVICE(0x0930, 0x0220), .driver_info = BTUSB_ATH3012 },
 	{ USB_DEVICE(0x0930, 0x0227), .driver_info = BTUSB_ATH3012 },

Signature · 1 line

1.9.1

Marcel Holtmann

maintainer

2014-12-09 06:12 UTC #1 lore raw

Hi Janne,

Quoted 4 lines · Janne Heikkinen

Asus X553MA has USB device 04ca:3010 that is Athoros AR3012 or compatible.

please include the device section from /sys/kernel/debug/usb/devices in the commit message.

Regards

Marcel

Janne Heikkinen

author

2014-12-09 06:42 UTC #2 lore raw

Hi Marcel,

Quoted 3 lines · Marcel Holtmann

please include the device section from /sys/kernel/debug/usb/devices in the commit message.
From 4cd18645e19a41c14a7e30ab28d611128139e8ce Mon Sep 17 00:00:00 2001

From: Janne Heikkinen <[email protected]>
Date: Tue, 9 Dec 2014 07:44:51 +0200
Subject: [PATCH] Add USB device 04ca:3010 as Athoros AR3012

Asus X553MA has USB device 04ca:3010 that is Athoros AR3012 or compatible.

Device from /sys/kernel/debug/usb/devices:

T:  Bus=01 Lev=02 Prnt=02 Port=03 Cnt=02 Dev#= 27 Spd=12   MxCh= 0
D:  Ver= 1.10 Cls=e0(wlcon) Sub=01 Prot=01 MxPS=64 #Cfgs=  1
P:  Vendor=04ca ProdID=3010 Rev= 0.02
C:* #Ifs= 2 Cfg#= 1 Atr=e0 MxPwr=100mA
A:  FirstIf#= 0 IfCount= 2 Cls=e0(wlcon) Sub=01 Prot=01
I:* If#= 0 Alt= 0 #EPs= 3 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb
E:  Ad=81(I) Atr=03(Int.) MxPS=  16 Ivl=1ms
E:  Ad=82(I) Atr=02(Bulk) MxPS=  64 Ivl=0ms
E:  Ad=02(O) Atr=02(Bulk) MxPS=  64 Ivl=0ms
I:* If#= 1 Alt= 0 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb
E:  Ad=83(I) Atr=01(Isoc) MxPS=   0 Ivl=1ms
E:  Ad=03(O) Atr=01(Isoc) MxPS=   0 Ivl=1ms
I:  If#= 1 Alt= 1 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb
E:  Ad=83(I) Atr=01(Isoc) MxPS=   9 Ivl=1ms
E:  Ad=03(O) Atr=01(Isoc) MxPS=   9 Ivl=1ms
I:  If#= 1 Alt= 2 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb
E:  Ad=83(I) Atr=01(Isoc) MxPS=  17 Ivl=1ms
E:  Ad=03(O) Atr=01(Isoc) MxPS=  17 Ivl=1ms
I:  If#= 1 Alt= 3 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb
E:  Ad=83(I) Atr=01(Isoc) MxPS=  25 Ivl=1ms
E:  Ad=03(O) Atr=01(Isoc) MxPS=  25 Ivl=1ms
I:  If#= 1 Alt= 4 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb
E:  Ad=83(I) Atr=01(Isoc) MxPS=  33 Ivl=1ms
E:  Ad=03(O) Atr=01(Isoc) MxPS=  33 Ivl=1ms
I:  If#= 1 Alt= 5 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb
E:  Ad=83(I) Atr=01(Isoc) MxPS=  49 Ivl=1ms
E:  Ad=03(O) Atr=01(Isoc) MxPS=  49 Ivl=1ms

Signed-off-by Janne Heikkinen <[email protected]>

---
 drivers/bluetooth/ath3k.c | 2 ++
 drivers/bluetooth/btusb.c | 1 +
 2 files changed, 3 insertions(+)

drivers/bluetooth/ath3k.c +2 -0

index d85ced2..74dd27a 100644
@@ -86,6 +86,7 @@ static const struct usb_device_id ath3k_table[] = {
  { USB_DEVICE(0x04CA, 0x3007) },
  { USB_DEVICE(0x04CA, 0x3008) },
  { USB_DEVICE(0x04CA, 0x300b) },
+ { USB_DEVICE(0x04CA, 0x3010) },
  { USB_DEVICE(0x0930, 0x0219) },
  { USB_DEVICE(0x0930, 0x0220) },
  { USB_DEVICE(0x0930, 0x0227) },

@@ -137,6 +138,7 @@ static const struct usb_device_id ath3k_blist_tbl[] = {
  { USB_DEVICE(0x04ca, 0x3007), .driver_info = BTUSB_ATH3012 },
  { USB_DEVICE(0x04ca, 0x3008), .driver_info = BTUSB_ATH3012 },
  { USB_DEVICE(0x04ca, 0x300b), .driver_info = BTUSB_ATH3012 },
+ { USB_DEVICE(0x04ca, 0x3010), .driver_info = BTUSB_ATH3012 },
  { USB_DEVICE(0x0930, 0x0219), .driver_info = BTUSB_ATH3012 },
  { USB_DEVICE(0x0930, 0x0220), .driver_info = BTUSB_ATH3012 },
  { USB_DEVICE(0x0930, 0x0227), .driver_info = BTUSB_ATH3012 },

drivers/bluetooth/btusb.c +1 -0

index edfc17b..edbd365 100644
@@ -163,6 +163,7 @@ static const struct usb_device_id blacklist_table[] = {
  { USB_DEVICE(0x04ca, 0x3007), .driver_info = BTUSB_ATH3012 },
  { USB_DEVICE(0x04ca, 0x3008), .driver_info = BTUSB_ATH3012 },
  { USB_DEVICE(0x04ca, 0x300b), .driver_info = BTUSB_ATH3012 },
+ { USB_DEVICE(0x04ca, 0x3010), .driver_info = BTUSB_ATH3012 },
  { USB_DEVICE(0x0930, 0x0219), .driver_info = BTUSB_ATH3012 },
  { USB_DEVICE(0x0930, 0x0220), .driver_info = BTUSB_ATH3012 },
  { USB_DEVICE(0x0930, 0x0227), .driver_info = BTUSB_ATH3012 },

Signature · 1 line

1.9.1

Marcel Holtmann

maintainer

2014-12-09 06:55 UTC #3 lore raw

Hi Janne,

Quoted 6 lines

Quoted 1 line
please include the device section from /sys/kernel/debug/usb/devices in the commit message.
From 4cd18645e19a41c14a7e30ab28d611128139e8ce Mon Sep 17 00:00:00 2001
From: Janne Heikkinen <[email protected]>
Date: Tue, 9 Dec 2014 07:44:51 +0200
Subject: [PATCH] Add USB device 04ca:3010 as Athoros AR3012

the subject needs a Bluetooth: prefix.

Quoted 45 lines

Asus X553MA has USB device 04ca:3010 that is Athoros AR3012 or compatible.

Device from /sys/kernel/debug/usb/devices:

T:  Bus=01 Lev=02 Prnt=02 Port=03 Cnt=02 Dev#= 27 Spd=12   MxCh= 0
D:  Ver= 1.10 Cls=e0(wlcon) Sub=01 Prot=01 MxPS=64 #Cfgs=  1
P:  Vendor=04ca ProdID=3010 Rev= 0.02
C:* #Ifs= 2 Cfg#= 1 Atr=e0 MxPwr=100mA
A:  FirstIf#= 0 IfCount= 2 Cls=e0(wlcon) Sub=01 Prot=01
I:* If#= 0 Alt= 0 #EPs= 3 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb
E:  Ad=81(I) Atr=03(Int.) MxPS=  16 Ivl=1ms
E:  Ad=82(I) Atr=02(Bulk) MxPS=  64 Ivl=0ms
E:  Ad=02(O) Atr=02(Bulk) MxPS=  64 Ivl=0ms
I:* If#= 1 Alt= 0 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb
E:  Ad=83(I) Atr=01(Isoc) MxPS=   0 Ivl=1ms
E:  Ad=03(O) Atr=01(Isoc) MxPS=   0 Ivl=1ms
I:  If#= 1 Alt= 1 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb
E:  Ad=83(I) Atr=01(Isoc) MxPS=   9 Ivl=1ms
E:  Ad=03(O) Atr=01(Isoc) MxPS=   9 Ivl=1ms
I:  If#= 1 Alt= 2 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb
E:  Ad=83(I) Atr=01(Isoc) MxPS=  17 Ivl=1ms
E:  Ad=03(O) Atr=01(Isoc) MxPS=  17 Ivl=1ms
I:  If#= 1 Alt= 3 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb
E:  Ad=83(I) Atr=01(Isoc) MxPS=  25 Ivl=1ms
E:  Ad=03(O) Atr=01(Isoc) MxPS=  25 Ivl=1ms
I:  If#= 1 Alt= 4 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb
E:  Ad=83(I) Atr=01(Isoc) MxPS=  33 Ivl=1ms
E:  Ad=03(O) Atr=01(Isoc) MxPS=  33 Ivl=1ms
I:  If#= 1 Alt= 5 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb
E:  Ad=83(I) Atr=01(Isoc) MxPS=  49 Ivl=1ms
E:  Ad=03(O) Atr=01(Isoc) MxPS=  49 Ivl=1ms

Signed-off-by Janne Heikkinen <[email protected]>

---
drivers/bluetooth/ath3k.c | 2 ++
drivers/bluetooth/btusb.c | 1 +

2 files changed, 3 insertions(+)

drivers/bluetooth/ath3k.c +0 -0

index d85ced2..74dd27a 100644

drivers/bluetooth/ath3k.c static const struct usb_device_id ath3k_table[] = { · line 92

Quoted 7 lines

drivers/bluetooth/ath3k.c +1 -0

@@ -86,6 +86,7 @@ static const struct usb_device_id ath3k_table[] = {
 { USB_DEVICE(0x04CA, 0x3007) },
 { USB_DEVICE(0x04CA, 0x3008) },
 { USB_DEVICE(0x04CA, 0x300b) },
+ { USB_DEVICE(0x04CA, 0x3010) },
 { USB_DEVICE(0x0930, 0x0219) },
 { USB_DEVICE(0x0930, 0x0220) },
 { USB_DEVICE(0x0930, 0x0227) },

This is not a patch that I can apply with git am. Your mail client mangled all the spacing. Use git format-path and git send-email.

Regards

Marcel

Janne Heikkinen

author

2014-12-09 07:09 UTC #4 lore raw

Hi Marcel,

Quoted 3 lines · Marcel Holtmann

Quoted 1 line
Subject: [PATCH] Add USB device 04ca:3010 as Athoros AR3012
the subject needs a Bluetooth: prefix.

...

Quoted 1 line

This is not a patch that I can apply with git am. Your mail client mangled all the spacing. Use git format-path and git send-email.

I'll try sending output of git format-patch as attachment.

From cfd5c6d53067010265752d9de39e5df0ebfe598a Mon Sep 17 00:00:00 2001
From: Janne Heikkinen <[email protected]>
Date: Tue, 9 Dec 2014 07:44:51 +0200
Subject: [PATCH] Bluetooth: Add USB device 04ca:3010 as Athoros AR3012

Asus X553MA has USB device 04ca:3010 that is Athoros AR3012 or compatible.

Device from /sys/kernel/debug/usb/devices:

T:  Bus=01 Lev=02 Prnt=02 Port=03 Cnt=02 Dev#= 27 Spd=12   MxCh= 0
D:  Ver= 1.10 Cls=e0(wlcon) Sub=01 Prot=01 MxPS=64 #Cfgs=  1
P:  Vendor=04ca ProdID=3010 Rev= 0.02
C:* #Ifs= 2 Cfg#= 1 Atr=e0 MxPwr=100mA
A:  FirstIf#= 0 IfCount= 2 Cls=e0(wlcon) Sub=01 Prot=01
I:* If#= 0 Alt= 0 #EPs= 3 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb
E:  Ad=81(I) Atr=03(Int.) MxPS=  16 Ivl=1ms
E:  Ad=82(I) Atr=02(Bulk) MxPS=  64 Ivl=0ms
E:  Ad=02(O) Atr=02(Bulk) MxPS=  64 Ivl=0ms
I:* If#= 1 Alt= 0 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb
E:  Ad=83(I) Atr=01(Isoc) MxPS=   0 Ivl=1ms
E:  Ad=03(O) Atr=01(Isoc) MxPS=   0 Ivl=1ms
I:  If#= 1 Alt= 1 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb
E:  Ad=83(I) Atr=01(Isoc) MxPS=   9 Ivl=1ms
E:  Ad=03(O) Atr=01(Isoc) MxPS=   9 Ivl=1ms
I:  If#= 1 Alt= 2 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb
E:  Ad=83(I) Atr=01(Isoc) MxPS=  17 Ivl=1ms
E:  Ad=03(O) Atr=01(Isoc) MxPS=  17 Ivl=1ms
I:  If#= 1 Alt= 3 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb
E:  Ad=83(I) Atr=01(Isoc) MxPS=  25 Ivl=1ms
E:  Ad=03(O) Atr=01(Isoc) MxPS=  25 Ivl=1ms
I:  If#= 1 Alt= 4 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb
E:  Ad=83(I) Atr=01(Isoc) MxPS=  33 Ivl=1ms
E:  Ad=03(O) Atr=01(Isoc) MxPS=  33 Ivl=1ms
I:  If#= 1 Alt= 5 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb
E:  Ad=83(I) Atr=01(Isoc) MxPS=  49 Ivl=1ms
E:  Ad=03(O) Atr=01(Isoc) MxPS=  49 Ivl=1ms

Signed-off-by Janne Heikkinen <[email protected]>

---
 drivers/bluetooth/ath3k.c | 2 ++
 drivers/bluetooth/btusb.c | 1 +
 2 files changed, 3 insertions(+)

drivers/bluetooth/ath3k.c +2 -0

index d85ced2..74dd27a 100644
@@ -86,6 +86,7 @@ static const struct usb_device_id ath3k_table[] = {
 	{ USB_DEVICE(0x04CA, 0x3007) },
 	{ USB_DEVICE(0x04CA, 0x3008) },
 	{ USB_DEVICE(0x04CA, 0x300b) },
+	{ USB_DEVICE(0x04CA, 0x3010) },
 	{ USB_DEVICE(0x0930, 0x0219) },
 	{ USB_DEVICE(0x0930, 0x0220) },
 	{ USB_DEVICE(0x0930, 0x0227) },

@@ -137,6 +138,7 @@ static const struct usb_device_id ath3k_blist_tbl[] = {
 	{ USB_DEVICE(0x04ca, 0x3007), .driver_info = BTUSB_ATH3012 },
 	{ USB_DEVICE(0x04ca, 0x3008), .driver_info = BTUSB_ATH3012 },
 	{ USB_DEVICE(0x04ca, 0x300b), .driver_info = BTUSB_ATH3012 },
+	{ USB_DEVICE(0x04ca, 0x3010), .driver_info = BTUSB_ATH3012 },
 	{ USB_DEVICE(0x0930, 0x0219), .driver_info = BTUSB_ATH3012 },
 	{ USB_DEVICE(0x0930, 0x0220), .driver_info = BTUSB_ATH3012 },
 	{ USB_DEVICE(0x0930, 0x0227), .driver_info = BTUSB_ATH3012 },

drivers/bluetooth/btusb.c +1 -0

index edfc17b..edbd365 100644
@@ -163,6 +163,7 @@ static const struct usb_device_id blacklist_table[] = {
 	{ USB_DEVICE(0x04ca, 0x3007), .driver_info = BTUSB_ATH3012 },
 	{ USB_DEVICE(0x04ca, 0x3008), .driver_info = BTUSB_ATH3012 },
 	{ USB_DEVICE(0x04ca, 0x300b), .driver_info = BTUSB_ATH3012 },
+	{ USB_DEVICE(0x04ca, 0x3010), .driver_info = BTUSB_ATH3012 },
 	{ USB_DEVICE(0x0930, 0x0219), .driver_info = BTUSB_ATH3012 },
 	{ USB_DEVICE(0x0930, 0x0220), .driver_info = BTUSB_ATH3012 },
 	{ USB_DEVICE(0x0930, 0x0227), .driver_info = BTUSB_ATH3012 },

Signature · 1 line

1.9.1

Marcel Holtmann

maintainer

2014-12-09 07:20 UTC #5 lore raw

Hi Janne,

Quoted 8 lines

Quoted 3 lines
Quoted 1 line
Subject: [PATCH] Add USB device 04ca:3010 as Athoros AR3012
the subject needs a Bluetooth: prefix.
...
Quoted 1 line
This is not a patch that I can apply with git am. Your mail client mangled all the spacing. Use git format-path and git send-email.
I'll try sending output of git format-patch as attachment. <0001-Bluetooth-Add-USB-device-04ca-3010-as-Athoros-AR3012.patch>

I really have no idea why using git send-email is so complicated. And in general I do not accept patches that come via attachments. They are really hard to review. Anyway, in this case I applied the patch to bluetooth-next tree.

Regards

Marcel