package/mpd: bump to version 0.19.6

PATCH Superseded Jörg Krause 2 participants 11 messages Dec 8, 2014 – Dec 9, 2014

lore

Share & tools

lore

Jörg Krause

author

2014-12-08 22:44 UTC #0 lore raw

PATCH 1/6 package/mpd: bump to version 0.19.6

Signed-off-by J?rg Krause <[email protected]>

---
 package/mpd/mpd.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

package/mpd/mpd.mk +1 -1

index c80de41..3be2ae5 100644
@@ -5,7 +5,7 @@
 ################################################################################
 
 MPD_VERSION_MAJOR = 0.19
-MPD_VERSION = $(MPD_VERSION_MAJOR).5
+MPD_VERSION = $(MPD_VERSION_MAJOR).6
 MPD_SOURCE = mpd-$(MPD_VERSION).tar.xz
 MPD_SITE = http://www.musicpd.org/download/mpd/$(MPD_VERSION_MAJOR)
 MPD_DEPENDENCIES = host-pkgconf boost libglib2

Signature · 1 line

2.1.3

Jörg Krause

author

2014-12-08 22:44 UTC #1 lore raw

PATCH 2/6 package/mpd: fix typo

Fix little type: it's UPnP, not UPnp.

Signed-off-by J?rg Krause <[email protected]>

---
 package/mpd/Config.in | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

package/mpd/Config.in +1 -1

index 1d38b1a..4097f52 100644
@@ -279,7 +279,7 @@ config BR2_PACKAGE_MPD_TCP
 	  on different machines (the usual scenario).
 
 config BR2_PACKAGE_MPD_UPNP
-	bool "UPnp"
+	bool "UPnP"
 	select BR2_PACKAGE_EXPAT
 	select BR2_PACKAGE_LIBUPNP
 	help

Signature · 1 line

2.1.3

Thomas Petazzoni

Applied

2014-12-09 18:53 UTC #2 lore raw

PATCH 2/6 package/mpd: fix typo

Dear J?rg Krause,

Quoted 6 lines · J?rg Krause

Fix little type: it's UPnP, not UPnp.
Signed-off-by J?rg Krause <[email protected]>
---
 package/mpd/Config.in | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Applied, thanks.

Thomas

Signature · 3 lines

Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

Jörg Krause

author

2014-12-08 22:44 UTC #3 lore raw

PATCH 3/6 package/mpd: make all package names in help text uppercase

In reply to Jörg Krause

Make the package name uppercase to be consistent in all the help texts.

Signed-off-by J?rg Krause <[email protected]>

---
 package/mpd/Config.in | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

package/mpd/Config.in +3 -3

index 4097f52..3435b05 100644
@@ -273,9 +273,9 @@ config BR2_PACKAGE_MPD_TCP
 	bool "tcp sockets"
 	default y
 	help
-	  Enable mpd to listen on tcp sockets.
+	  Enable MPD to listen on tcp sockets.
 
-	  You want this on if mpd and the client(s) work
+	  You want this on if MPD and the client(s) work
 	  on different machines (the usual scenario).
 
 config BR2_PACKAGE_MPD_UPNP

@@ -283,7 +283,7 @@ config BR2_PACKAGE_MPD_UPNP
 	select BR2_PACKAGE_EXPAT
 	select BR2_PACKAGE_LIBUPNP
 	help
-	  Enable mpd UPnP client support.
+	  Enable MPD UPnP client support.
 
 endif

Signature · 1 line

2.1.3

Thomas Petazzoni

Applied

2014-12-09 18:54 UTC #4 lore raw

PATCH 3/6 package/mpd: make all package names in help text uppercase

Dear J?rg Krause,

Quoted 6 lines · J?rg Krause

Make the package name uppercase to be consistent in all the help texts.
Signed-off-by J?rg Krause <[email protected]>
---
 package/mpd/Config.in | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

Applied, thanks.

Thomas

Signature · 3 lines

Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

Jörg Krause

author

2014-12-08 22:44 UTC #5 lore raw

PATCH 4/6 package/mpd: fix line length for help text

In reply to Jörg Krause

Make help text lines not longer as 80 characters (one tab weights eight chars).

Signed-off-by J?rg Krause <[email protected]>

---
 package/mpd/Config.in | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

package/mpd/Config.in +4 -4

index 3435b05..901902b 100644
@@ -65,8 +65,8 @@ config BR2_PACKAGE_MPD_AUDIOFILE
 config BR2_PACKAGE_MPD_DSD
 	bool "dsd"
 	help
-	  Enable Digital Speech Decoder (DSD) support to play audio files encoded
-	  in a digital speech format.
+	  Enable Digital Speech Decoder (DSD) support to play audio files
+	  encoded in a digital speech format.
 
 config BR2_PACKAGE_MPD_FAAD2
 	bool "faad2"

@@ -263,8 +263,8 @@ config BR2_PACKAGE_MPD_AVAHI_SUPPORT
 	select BR2_PACKAGE_AVAHI_LIBDNSSD_COMPATIBILITY
 	help
 	  Enable Avahi (zeroconf) support.
-	  Select this for multicast DNS/DNS-SD service discovery support. This allows
-	  MPD to publish service information on a local network.
+	  Select this for multicast DNS/DNS-SD service discovery support. This
+	  allows MPD to publish service information on a local network.
 
 comment "avahi support needs a toolchain w/ dynamic library"
 	depends on BR2_PREFER_STATIC_LIB

Signature · 1 line

2.1.3

Thomas Petazzoni

Applied

2014-12-09 18:54 UTC #6 lore raw

PATCH 4/6 package/mpd: fix line length for help text

Dear J?rg Krause,

Quoted 6 lines · J?rg Krause

Make help text lines not longer as 80 characters (one tab weights eight chars).
Signed-off-by J?rg Krause <[email protected]>
---
 package/mpd/Config.in | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

Applied, after wrapping some other help texts that were also too long (at least from Emacs text wrapping perspective, which as we all know is the absolute rule everyone must follow! :-))

Thanks,

Thomas

Signature · 3 lines

Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

Jörg Krause

author

2014-12-08 22:44 UTC #7 lore raw

PATCH 5/6 package/mpd: enable neighbor discovery support

In reply to Jörg Krause

Enable support for neighbor discovery useful in Samba and UPnP networks.

Signed-off-by J?rg Krause <[email protected]>

---
 package/mpd/Config.in | 10 ++++++++++
 package/mpd/mpd.mk    |  6 ++++++
 2 files changed, 16 insertions(+)

package/mpd/Config.in +10 -0

index 901902b..57ed434 100644
@@ -269,6 +269,16 @@ config BR2_PACKAGE_MPD_AVAHI_SUPPORT
 comment "avahi support needs a toolchain w/ dynamic library"
 	depends on BR2_PREFER_STATIC_LIB
 
+config BR2_PACKAGE_MPD_NEIGHBOR_DISCOVERY_SUPPORT
+	bool "neighbor discovery support"
+	help
+	  Enable support for neighbor discovery.
+	  This option may be used in conjunction with the plugin samba to
+	  provide a list of SMB/CIFS servers or with the plugin UPnP to provide
+	  a list of UPnP servers on the local network.
+	  The neighbor plugin needs configuration in mpd.conf. For further
+	  information take a look at the MPD documentation.
+
 config BR2_PACKAGE_MPD_TCP
 	bool "tcp sockets"
 	default y

package/mpd/mpd.mk +6 -0

index 3be2ae5..85bbe8b 100644
@@ -162,6 +162,12 @@ else
 MPD_CONF_OPTS += --disable-mpc
 endif
 
+ifeq ($(BR2_PACKAGE_MPD_NEIGHBOR_DISCOVERY_SUPPORT),y)
+MPD_CONF_OPTS += --enable-neighbor-plugins
+else
+MPD_CONF_OPTS += --disable-neighbor-plugins
+endif
+
 ifeq ($(BR2_PACKAGE_MPD_OPUS),y)
 MPD_DEPENDENCIES += opus libogg
 MPD_CONF_OPTS += --enable-opus

Signature · 1 line

2.1.3

Thomas Petazzoni

2014-12-09 19:15 UTC #8 lore raw

PATCH 5/6 package/mpd: enable neighbor discovery support

Dear J?rg Krause,

Quoted 15 lines · J?rg Krause

Enable support for neighbor discovery useful in Samba and UPnP networks.
Signed-off-by J?rg Krause <[email protected]>
---
 package/mpd/Config.in | 10 ++++++++++
 package/mpd/mpd.mk    |  6 ++++++
 2 files changed, 16 insertions(+)
package/mpd/Config.in +0 -0
index 901902b..57ed434 100644
@@ -269,6 +269,16 @@ config BR2_PACKAGE_MPD_AVAHI_SUPPORT
 comment "avahi support needs a toolchain w/ dynamic library"
 	depends on BR2_PREFER_STATIC_LIB

package/mpd/Config.in config BR2_PACKAGE_MPD_AVAHI_SUPPORT · line 280

Quoted 10 lines

package/mpd/Config.in +9 -0

 
+config BR2_PACKAGE_MPD_NEIGHBOR_DISCOVERY_SUPPORT
+	bool "neighbor discovery support"
+	help
+	  Enable support for neighbor discovery.
+	  This option may be used in conjunction with the plugin samba to
+	  provide a list of SMB/CIFS servers or with the plugin UPnP to provide
+	  a list of UPnP servers on the local network.
+	  The neighbor plugin needs configuration in mpd.conf. For further
+	  information take a look at the MPD documentation.

After looking a bit at the MPD configure.ac script and Makefile.am, it appeared to me that this feature doesn't do anything useful if there isn't either smbclient or upnp support enabled, so I made this option depends on smbclient or upnp support.

Applied with this change, thanks.

Thomas

Signature · 3 lines

Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

Jörg Krause

author

2014-12-08 22:44 UTC #9 lore raw

PATCH 6/6 package/mpd: enable OSS support

In reply to Jörg Krause

Add support for the OSS (Open Sound System).

Signed-off-by J?rg Krause <[email protected]>

---
 package/mpd/Config.in | 5 +++++
 package/mpd/mpd.mk    | 6 ++++++
 2 files changed, 11 insertions(+)

package/mpd/Config.in +5 -0

index 57ed434..50f9ad0 100644
@@ -241,6 +241,11 @@ comment "jack support needs a toolchain w/ largefile"
 	depends on BR2_ARCH_HAS_ATOMICS
 	depends on !BR2_LARGEFILE
 
+config BR2_PACKAGE_MPD_OSS
+	bool "oss"
+	help
+	  Enable OSS (Open Sound System) output support.
+
 config BR2_PACKAGE_MPD_PULSEAUDIO
 	bool "pulseaudio"
 	depends on BR2_LARGEFILE # pulseaudio -> libsndfile

package/mpd/mpd.mk +6 -0

index 85bbe8b..132ad44 100644
@@ -175,6 +175,12 @@ else
 MPD_CONF_OPTS += --disable-opus
 endif
 
+ifeq ($(BR2_PACKAGE_MPD_OSS),y)
+MPD_CONF_OPTS += --enable-oss
+else
+MPD_CONF_OPTS += --disable-oss
+endif
+
 ifeq ($(BR2_PACKAGE_MPD_PULSEAUDIO),y)
 MPD_DEPENDENCIES += pulseaudio
 MPD_CONF_OPTS += --enable-pulse

Signature · 1 line

2.1.3

Thomas Petazzoni

2014-12-09 19:16 UTC #10 lore raw

PATCH 6/6 package/mpd: enable OSS support

Dear J?rg Krause,

Quoted 3 lines · J?rg Krause

Add support for the OSS (Open Sound System).
Signed-off-by J?rg Krause <[email protected]>

Applied, after adjusting the commit title: the commit is not enabling OSS support, it's adding an option to enable or disable the OSS support. And in practice it actually disables it: it was enabled by default by the mpd configure.ac script, unless --disable-oss is passed. Now that we have the option which defaults to not enabled, the OSS support will be disabled by default. I believe this is good as on most Linux systems, ALSA is now used for audio, and OSS is deprecated.

Thanks,

Thomas

Signature · 3 lines

Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com