Skip to contentSkip to conversation

clk: shmobile: Add r8a7793 support

PATCH New Yoshihiro Kaneko 3 participants 8 messages Dec 8, 2014 – Dec 10, 2014

Subsystems (2)
Common clk SuperH
lore
Share & tools
lore

Yoshihiro Kaneko

author
#0 lore raw

PATCH 1/1 clk: shmobile: Add r8a7793 support

From: Hisashi Nakamura <[email protected]>

R-Car M2N (r8a7793) clock is handled in R-Car Gen2 clock driver.

Signed-off-by Hisashi Nakamura <[email protected]>
Signed-off-by Yoshihiro Kaneko <[email protected]>

---

This patch is based on renesas/devel.

 drivers/clk/shmobile/Makefile | 1 +
 1 file changed, 1 insertion(+)
drivers/clk/shmobile/Makefile +1 -0
index 960bf22..3cc716d 100644
@@ -4,6 +4,7 @@ obj-$(CONFIG_ARCH_R8A7740)		+= clk-r8a7740.o
 obj-$(CONFIG_ARCH_R8A7779)		+= clk-r8a7779.o
 obj-$(CONFIG_ARCH_R8A7790)		+= clk-rcar-gen2.o
 obj-$(CONFIG_ARCH_R8A7791)		+= clk-rcar-gen2.o
+obj-$(CONFIG_ARCH_R8A7793)		+= clk-rcar-gen2.o
 obj-$(CONFIG_ARCH_R8A7794)		+= clk-rcar-gen2.o
 obj-$(CONFIG_ARCH_SHMOBILE_MULTI)	+= clk-div6.o
 obj-$(CONFIG_ARCH_SHMOBILE_MULTI)	+= clk-mstp.o
Signature · 1 line
1.9.1
#1 lore raw

PATCH 1/1 clk: shmobile: Add r8a7793 support

Hi Kaneko-san,

Quoted 3 lines · Yoshihiro Kaneko

From: Hisashi Nakamura <[email protected]>

R-Car M2N (r8a7793) clock is handled in R-Car Gen2 clock driver.

Thanks for your patch!

Quoted 2 lines
Signed-off-by Hisashi Nakamura <[email protected]>
Signed-off-by Yoshihiro Kaneko <[email protected]>
Acked-by Geert Uytterhoeven <[email protected]>

Can you please also send a patch to update the binding documentation in Documentation/devicetree/bindings/clock/renesas,rcar-gen2-cpg-clocks.txt?

Thanks again!

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds

author
#2 lore raw

PATCH 1/1 clk: shmobile: Add r8a7793 support

Hi Geert-san,

2014-12-08 20:13 GMT+09:00 Geert Uytterhoeven <[email protected]>:

Quoted 9 lines

Hi Kaneko-san,

Quoted 3 lines · Yoshihiro Kaneko

From: Hisashi Nakamura <[email protected]>

R-Car M2N (r8a7793) clock is handled in R-Car Gen2 clock driver.

Thanks for your patch!

Quoted 7 lines
Quoted 2 lines
Signed-off-by Hisashi Nakamura <[email protected]>
Signed-off-by Yoshihiro Kaneko <[email protected]>
Acked-by Geert Uytterhoeven <[email protected]>

Can you please also send a patch to update the binding documentation in Documentation/devicetree/bindings/clock/renesas,rcar-gen2-cpg-clocks.txt?

This patch updates Makefile only, not added dtsi for r8a7793. Is the update of the document necessary?

Thanks,
Kaneko

Quoted 13 lines

Thanks again!

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds

#3 lore raw

PATCH 1/1 clk: shmobile: Add r8a7793 support

Hi Kaneko-san,

Quoted 11 lines · Yoshihiro Kaneko

2014-12-08 20:13 GMT+09:00 Geert Uytterhoeven <[email protected]>:

Quoted 10 lines · Yoshihiro Kaneko
Quoted 3 lines

From: Hisashi Nakamura <[email protected]>

R-Car M2N (r8a7793) clock is handled in R-Car Gen2 clock driver.

Thanks for your patch!

Quoted 2 lines
Signed-off-by Hisashi Nakamura <[email protected]>
Signed-off-by Yoshihiro Kaneko <[email protected]>
Quoted 7 lines
Quoted 4 lines
Acked-by Geert Uytterhoeven <[email protected]>

Can you please also send a patch to update the binding documentation in Documentation/devicetree/bindings/clock/renesas,rcar-gen2-cpg-clocks.txt?

This patch updates Makefile only, not added dtsi for r8a7793. Is the update of the document necessary?

Not at this moment. I was just trying to be proactive ;-)

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds

#4 lore raw

PATCH 1/1 clk: shmobile: Add r8a7793 support

Quoted 16 lines · Geert Uytterhoeven

Hi Kaneko-san,

Quoted 13 lines · Yoshihiro Kaneko

2014-12-08 20:13 GMT+09:00 Geert Uytterhoeven <[email protected]>:

Quoted 12 lines · Yoshihiro Kaneko
Quoted 3 lines

From: Hisashi Nakamura <[email protected]>

R-Car M2N (r8a7793) clock is handled in R-Car Gen2 clock driver.

Thanks for your patch!

Quoted 2 lines
Signed-off-by Hisashi Nakamura <[email protected]>
Signed-off-by Yoshihiro Kaneko <[email protected]>
Acked-by Geert Uytterhoeven <[email protected]>
Quoted 7 lines
Quoted 5 lines
Quoted 2 lines

Can you please also send a patch to update the binding documentation in Documentation/devicetree/bindings/clock/renesas,rcar-gen2-cpg-clocks.txt?

This patch updates Makefile only, not added dtsi for r8a7793. Is the update of the document necessary?

Not at this moment. I was just trying to be proactive ;-)

Kaneko-san,

I think that the update to renesas,rcar-gen2-cpg-clocks.txt should be a one line change. I can prepare a patch if you prefer not to.

author
#5 lore raw

PATCH 1/1 clk: shmobile: Add r8a7793 support

Hi Simon-san,

2014-12-09 9:23 GMT+09:00 Simon Horman <[email protected]>:

Quoted 23 lines · Geert Uytterhoeven
Quoted 22 lines

Hi Kaneko-san,

Quoted 18 lines · Yoshihiro Kaneko

2014-12-08 20:13 GMT+09:00 Geert Uytterhoeven <[email protected]>:

Quoted 7 lines · Yoshihiro Kaneko
Quoted 3 lines

From: Hisashi Nakamura <[email protected]>

R-Car M2N (r8a7793) clock is handled in R-Car Gen2 clock driver.

Thanks for your patch!

Quoted 7 lines
Quoted 2 lines
Signed-off-by Hisashi Nakamura <[email protected]>
Signed-off-by Yoshihiro Kaneko <[email protected]>
Acked-by Geert Uytterhoeven <[email protected]>

Can you please also send a patch to update the binding documentation in Documentation/devicetree/bindings/clock/renesas,rcar-gen2-cpg-clocks.txt?

This patch updates Makefile only, not added dtsi for r8a7793. Is the update of the document necessary?

Quoted 6 lines
Quoted 1 line

Not at this moment. I was just trying to be proactive ;-)

Kaneko-san,

I think that the update to renesas,rcar-gen2-cpg-clocks.txt should be a one line change. I can prepare a patch if you prefer not to.

Yes, I know that the update is very small.
But "renesas,r8a7793-cpg-clocks" which will be added to the documentation was not found anywhere in the source tree. For example, "renesas,r8a7794-cpg-clocks"
is found in arch/arm/boot/dts/r8a7794.dtsi.
Is r8a7793.dtsi not necessary to update the document?

#6 lore raw

PATCH 1/1 clk: shmobile: Add r8a7793 support

Quoted 33 lines · Yoshihiro Kaneko

Hi Simon-san,

2014-12-09 9:23 GMT+09:00 Simon Horman <[email protected]>:

Quoted 23 lines · Geert Uytterhoeven
Quoted 22 lines

Hi Kaneko-san,

Quoted 18 lines · Yoshihiro Kaneko

2014-12-08 20:13 GMT+09:00 Geert Uytterhoeven <[email protected]>:

Quoted 7 lines · Yoshihiro Kaneko
Quoted 3 lines

From: Hisashi Nakamura <[email protected]>

R-Car M2N (r8a7793) clock is handled in R-Car Gen2 clock driver.

Thanks for your patch!

Quoted 7 lines
Quoted 2 lines
Signed-off-by Hisashi Nakamura <[email protected]>
Signed-off-by Yoshihiro Kaneko <[email protected]>
Acked-by Geert Uytterhoeven <[email protected]>

Can you please also send a patch to update the binding documentation in Documentation/devicetree/bindings/clock/renesas,rcar-gen2-cpg-clocks.txt?

This patch updates Makefile only, not added dtsi for r8a7793. Is the update of the document necessary?

Quoted 6 lines
Quoted 1 line

Not at this moment. I was just trying to be proactive ;-)

Kaneko-san,

I think that the update to renesas,rcar-gen2-cpg-clocks.txt should be a one line change. I can prepare a patch if you prefer not to.

Quoted 6 lines

Yes, I know that the update is very small.
But "renesas,r8a7793-cpg-clocks" which will be added to the documentation was not found anywhere in the source tree. For example, "renesas,r8a7794-cpg-clocks"
is found in arch/arm/boot/dts/r8a7794.dtsi.
Is r8a7793.dtsi not necessary to update the document?

In theory (though not always in practice) bindings should be documented before they are used. So unless I misunderstand things, yes, I think renesas,rcar-gen2-cpg-clocks.txt should be updated even though arch/arm/boot/dts/r8a7794.dtsi is (not yet) updated.

author
#7 lore raw

PATCH 1/1 clk: shmobile: Add r8a7793 support

2014-12-10 9:18 GMT+09:00 Simon Horman <[email protected]>:

Quoted 41 lines · Yoshihiro Kaneko
Quoted 33 lines

Hi Simon-san,

2014-12-09 9:23 GMT+09:00 Simon Horman <[email protected]>:

Quoted 23 lines · Geert Uytterhoeven
Quoted 22 lines

Hi Kaneko-san,

Quoted 18 lines · Yoshihiro Kaneko

2014-12-08 20:13 GMT+09:00 Geert Uytterhoeven <[email protected]>:

Quoted 7 lines · Yoshihiro Kaneko
Quoted 3 lines

From: Hisashi Nakamura <[email protected]>

R-Car M2N (r8a7793) clock is handled in R-Car Gen2 clock driver.

Thanks for your patch!

Quoted 7 lines
Quoted 2 lines
Signed-off-by Hisashi Nakamura <[email protected]>
Signed-off-by Yoshihiro Kaneko <[email protected]>
Acked-by Geert Uytterhoeven <[email protected]>

Can you please also send a patch to update the binding documentation in Documentation/devicetree/bindings/clock/renesas,rcar-gen2-cpg-clocks.txt?

This patch updates Makefile only, not added dtsi for r8a7793. Is the update of the document necessary?

Quoted 6 lines
Quoted 1 line

Not at this moment. I was just trying to be proactive ;-)

Kaneko-san,

I think that the update to renesas,rcar-gen2-cpg-clocks.txt should be a one line change. I can prepare a patch if you prefer not to.

Quoted 6 lines

Yes, I know that the update is very small.
But "renesas,r8a7793-cpg-clocks" which will be added to the documentation was not found anywhere in the source tree. For example, "renesas,r8a7794-cpg-clocks"
is found in arch/arm/boot/dts/r8a7794.dtsi.
Is r8a7793.dtsi not necessary to update the document?

Quoted 4 lines

In theory (though not always in practice) bindings should be documented before they are used. So unless I misunderstand things, yes, I think renesas,rcar-gen2-cpg-clocks.txt should be updated even though arch/arm/boot/dts/r8a7794.dtsi is (not yet) updated.

I got it. I can prepare a patch which updates the binding document.