Skip to contentSkip to conversation

staging: rts5208: Removed the new typedefs

PATCH In review Anjana Sasindran 2 participants 2 messages Dec 10, 2014 Staging

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 staging: rts5208: Removed the new typedefs

This patch fix the checkpatch.pl warning:

WARNING: do not add new typedefs

---
 drivers/staging/rts5208/rtsx_sys.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/rts5208/rtsx_sys.h +1 -1
index 0b6b4d4..f04d997 100644
@@ -28,7 +28,7 @@
 #include "rtsx_chip.h"
 #include "rtsx_card.h"
 
-typedef dma_addr_t ULONG_PTR;
+dma_addr_t ULONG_PTR;
 
 static inline void rtsx_exclusive_enter_ss(struct rtsx_chip *chip)
 {
Signature · 1 line
1.9.1
maintainer
#1 lore raw
Quoted 14 lines · Anjana Sasindran

This patch fix the checkpatch.pl warning:

WARNING: do not add new typedefs

---
 drivers/staging/rts5208/rtsx_sys.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/rts5208/rtsx_sys.h +0 -0
index 0b6b4d4..f04d997 100644

drivers/staging/rts5208/rtsx_sys.h line 34

Quoted 8 lines
drivers/staging/rts5208/rtsx_sys.h +1 -1
@@ -28,7 +28,7 @@
 #include "rtsx_chip.h"
 #include "rtsx_card.h"
 
-typedef dma_addr_t ULONG_PTR;
+dma_addr_t ULONG_PTR;
 
 static inline void rtsx_exclusive_enter_ss(struct rtsx_chip *chip)
 {

Please learn how the C language works before attempting to contribute to the Linux kernel. You obviously didn't even test build this code, which means you are trying to waste my time, a very rude thing to do to someone else, don't you think?

*plonk*