staging, addi_apci_1500: fix IRQ spew

PATCH In review Alan Cox 2 participants 2 messages Dec 10, 2014 – Jan 10, 2015 Staging

Share & tools

Alan Cox

author

2014-12-10 14:42 UTC #0 lore raw

PATCH 1/1 staging, addi_apci_1500: fix IRQ spew

The driver very carefully checks if the card is the IRQ source, and if it isn't thoughtfully spews crap at_dev_warn() level. Remove the spewage so it can be used on a shared interrupt line.

Resolves-bug: https://bugzilla.kernel.org/show_bug.cgi?id=88651

Signed-off-by Alan Cox <[email protected]>

---
 .../comedi/drivers/addi-data/hwdrv_apci1500.c      |    4 ----
 1 file changed, 4 deletions(-)

drivers/staging/comedi/drivers/addi-data/hwdrv_apci1500.c +0 -4

index 0ea081e..b7b9857 100644
@@ -2175,10 +2175,6 @@ static void apci1500_interrupt(int irq, void *d)
 			devpriv->iobase + APCI1500_Z8536_CONTROL_REGISTER);
 		/* Authorizes the main interrupt on the board */
 		outb(0xD0, devpriv->iobase + APCI1500_Z8536_CONTROL_REGISTER);
-	} else {
-		dev_warn(dev->class_dev,
-			"Interrupt from unknown source\n");
-
 	}
 }

Greg KH

maintainer

2015-01-10 01:50 UTC #1 lore raw

Quoted 15 lines · Alan Cox

The driver very carefully checks if the card is the IRQ source, and if it isn't thoughtfully spews crap at_dev_warn() level. Remove the spewage so it can be used on a shared interrupt line.
Resolves-bug: https://bugzilla.kernel.org/show_bug.cgi?id=88651
Signed-off-by Alan Cox <[email protected]>
---
 .../comedi/drivers/addi-data/hwdrv_apci1500.c      |    4 ----
 1 file changed, 4 deletions(-)
drivers/staging/comedi/drivers/addi-data/hwdrv_apci1500.c +0 -0
index 0ea081e..b7b9857 100644

drivers/staging/comedi/drivers/addi-data/hwdrv_apci1500.c static void apci1500_interrupt(int irq, void *d) · line 2180

Quoted 10 lines

drivers/staging/comedi/drivers/addi-data/hwdrv_apci1500.c +0 -4

@@ -2175,10 +2175,6 @@ static void apci1500_interrupt(int irq, void *d)
 			devpriv->iobase + APCI1500_Z8536_CONTROL_REGISTER);
 		/* Authorizes the main interrupt on the board */
 		outb(0xD0, devpriv->iobase + APCI1500_Z8536_CONTROL_REGISTER);
-	} else {
-		dev_warn(dev->class_dev,
-			"Interrupt from unknown source\n");
-
 	}
 }

No longer applies to my tree due to other changes in this driver :(

thanks,

greg k-h