Skip to contentSkip to conversation

NFSv4 ACLs and umasks

PATCH J. Bruce Fields 2 participants 2 messages Dec 10, 2014

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

We've gotten complaints that the effect of NFSv4 ACL inheritance is often overridden by common umask settings.

Options:

- Do nothing, make sure the behavior's documented. I don't think this will make people happy, but I haven't tried to figure out exactly what any of them are trying to do.

- Do as in NFSv3 and teach the client to skip the umask in the case the parent directory has inheritable ACEs. The following patch is a proof-of-concept with some bugs. It requires documenting what we mean by "parent directory has interitable ACEs"--I'm taking it to mean that the ACL has some ACE with inheritance bits set, as that's simple to explain. Drawbacks
include: requires fetching and caching an ACL on create; there's a race between checking and creating; creates may fail just because reading the ACL fails.

- New protocol: e.g. add a new attribute representing the un-umasked mode, send both that and the regular mode on create, let the server sort it out.

- Something else??: adopt some convention that uses redundant information in a compound (multiple SETATTRs?) to communicate umask to "in the know" servers without changing behavior on existing servers. Provide an "ignore the umask" mount option. Maybe I'm missing a clever trick.

Any ideas?

--b.

fs/nfs/dir.c +1 -1
index 6e62155abf26..e3b4b6250693 100644
@@ -1503,7 +1503,7 @@ int nfs_atomic_open(struct inode *dir, struct dentry *dentry,
 
 	if (open_flags & O_CREAT) {
 		attr.ia_valid |= ATTR_MODE;
-		attr.ia_mode = mode & ~current_umask();
+		attr.ia_mode = mode;
 	}
 	if (open_flags & O_TRUNC) {
 		attr.ia_valid |= ATTR_SIZE;
fs/nfs/nfs4proc.c +81 -3

114 lines not on this page · raw message

#1 lore raw
Quoted 8 lines · J. Bruce Fields

We've gotten complaints that the effect of NFSv4 ACL inheritance is often overridden by common umask settings.

Options:

- Do nothing, make sure the behavior's documented. I don't think this will make people happy, but I haven't tried to figure out exactly what any of them are trying to do.

POSIX documents exactly how open(O_CREATE) works. I'd say that if anything, we'd need to document how inherited ACLs are supposed to work in this situation.

Quoted 10 lines

- Do as in NFSv3 and teach the client to skip the umask in the case the parent directory has inheritable ACEs. The following patch is a proof-of-concept with some bugs. It requires documenting what we mean by "parent directory has interitable ACEs"--I'm taking it to mean that the ACL has some ACE with inheritance bits set, as that's simple to explain. Drawbacks
include: requires fetching and caching an ACL on create; there's a race between checking and creating; creates may fail just because reading the ACL fails.

Yeah, this is a non-starter.

Quoted 11 lines

- New protocol: e.g. add a new attribute representing the un-umasked mode, send both that and the regular mode on create, let the server sort it out.

- Something else??: adopt some convention that uses redundant information in a compound (multiple SETATTRs?) to communicate umask to "in the know" servers without changing behavior on existing servers. Provide an "ignore the umask" mount option. Maybe I'm missing a clever trick.

Any ideas?

As I indicated above, I'd like to see a little more debate around how we expect this whole ACL inheritance thing to work in practice. The NFSv4 spec is all about enabling Windows-like ACL behaviour, but that isn't necessarily the right thing for Linux applications.

IOW: before we discuss fixes, I'd like to understand how the current behaviour is broken.

Signature · 5 lines
Trond Myklebust

Linux NFS client maintainer, PrimaryData

[email protected]