libfm-extra: new package
PATCH v2 1/4 libfm-extra: new package
---
Changes v1 -> v2: nothing
package/Config.in | 1 + package/libfm-extra/Config.in | 15 +++++++++++++++ package/libfm-extra/libfm-extra.hash | 2 ++ package/libfm-extra/libfm-extra.mk | 16 ++++++++++++++++ 4 files changed, 34 insertions(+), 0 deletions(-) create mode 100644 package/libfm-extra/Config.in create mode 100644 package/libfm-extra/libfm-extra.hash create mode 100644 package/libfm-extra/libfm-extra.mk
package/Config.in +1 -0
@@ -644,6 +644,7 @@ menu "Graphics" source "package/libdmtx/Config.in" source "package/libdrm/Config.in" source "package/libexif/Config.in" + source "package/libfm-extra/Config.in" source "package/libgail/Config.in" source "package/libgeotiff/Config.in" source "package/libglade/Config.in"
package/libfm-extra/Config.in new file +15 -0
@@ -0,0 +1,15 @@ +config BR2_PACKAGE_LIBFM_EXTRA + bool "libfm-extra" + select BR2_PACKAGE_LIBGLIB2 + depends on BR2_USE_WCHAR # libglib2 + depends on BR2_TOOLCHAIN_HAS_THREADS # libglib2 + depends on BR2_USE_MMU # libglib2 + help + The libfm-extra package contains a library and other files + required by menu-cache-gen libexec of menu-cache-1.0.0 + + http://wiki.lxde.org/en/Libfm + +comment "libfm-extra needs a toolchain w/ wchar, threads, C++" + depends on BR2_USE_MMU + depends on !BR2_USE_WCHAR || !BR2_TOOLCHAIN_HAS_THREADS
package/libfm-extra/libfm-extra.hash new file +2 -0
@@ -0,0 +1,2 @@ +# From http://blog.lxde.org/?p=1280 +sha1 c3f2f34086761d89d6aba549883610084ba00750 libfm-1.2.3.tar.xz
package/libfm-extra/libfm-extra.mk new file +16 -0
@@ -0,0 +1,16 @@ +################################################################################ +# +# libfm-extra +# +################################################################################ + +LIBFM_EXTRA_VERSION = 1.2.3 +LIBFM_EXTRA_SOURCE = libfm-$(LIBFM_EXTRA_VERSION).tar.xz +LIBFM_EXTRA_SITE = http://sourceforge.net/projects/pcmanfm/files +LIBFM_EXTRA_DEPENDENCIES = libglib2 +LIBFM_EXTRA_LICENSE = GPLv2 +LIBFM_EXTRA_LICENSE_FILES = COPYING +LIBFM_EXTRA_INSTALL_STAGING = YES +LIBFM_EXTRA_CONF_OPTS = --with-extra-only --with-gtk=no + +$(eval $(autotools-package))
Signature · 1 line
1.7.1
PATCH v2 2/4 menu-cache: new package
---
Changes v1 -> v2: Remove GETTEXT and LIBICONV lines. Copy/Paste error
package/Config.in | 1 + package/menu-cache/Config.in | 15 +++++++++++++++ package/menu-cache/menu-cache.hash | 2 ++ package/menu-cache/menu-cache.mk | 17 +++++++++++++++++ 4 files changed, 35 insertions(+), 0 deletions(-) create mode 100644 package/menu-cache/Config.in create mode 100644 package/menu-cache/menu-cache.hash create mode 100644 package/menu-cache/menu-cache.mk
package/Config.in +1 -0
@@ -662,6 +662,7 @@ menu "Graphics" source "package/libungif/Config.in" source "package/libva/Config.in" source "package/libva-intel-driver/Config.in" + source "package/menu-cache/Config.in" source "package/opencv/Config.in" source "package/opengl/Config.in" source "package/pango/Config.in"
package/menu-cache/Config.in new file +15 -0
@@ -0,0 +1,15 @@ +config BR2_PACKAGE_MENU_CACHE + bool "menu-cache" + select BR2_PACKAGE_LIBGLIB2 + select BR2_PACKAGE_LIBFM_EXTRA + depends on BR2_USE_WCHAR # libglib2 + depends on BR2_TOOLCHAIN_HAS_THREADS # libglib2 + depends on BR2_USE_MMU # libglib2 + help + Small library from LXDE project used for application menu integration + + http://wiki.lxde.org/ + +comment "menu-cache needs a toolchain w/ wchar, threads" + depends on BR2_USE_MMU + depends on !BR2_USE_WCHAR || !BR2_TOOLCHAIN_HAS_THREADS
package/menu-cache/menu-cache.hash new file +2 -0
@@ -0,0 +1,2 @@ +# From http://blog.lxde.org/?p=1299 +sha1 e7b3854109f9826472cf9795e924acebe5e27861 menu-cache-1.0.0.tar.xz
package/menu-cache/menu-cache.mk new file +17 -0
@@ -0,0 +1,17 @@ +################################################################################ +# +# menu-cache +# +################################################################################ + +MENU_CACHE_VERSION_MAJOR = 1.0 +MENU_CACHE_VERSION_MINOR = 0 +MENU_CACHE_VERSION = $(MENU_CACHE_VERSION_MAJOR).$(MENU_CACHE_VERSION_MINOR) +MENU_CACHE_SOURCE = menu-cache-$(MENU_CACHE_VERSION).tar.xz +MENU_CACHE_SITE = http://sourceforge.net/projects/lxde/files/menu-cache/$(MENU_CACHE_VERSION_MAJOR) +MENU_CACHE_DEPENDENCIES = libfm-extra libglib2 +MENU_CACHE_LICENSE = LGPLv2.1 +MENU_CACHE_LICENSE_FILES = COPYING +MENU_CACHE_INSTALL_STAGING = YES + +$(eval $(autotools-package))
Signature · 1 line
1.7.1
PATCH v2 2/4 menu-cache: new package
Vicente, All,
On 2014-11-21 15:33 +0000, Vicente Olivert Riera spake thusly:
Quoted 1 line
Signed-off-by Vicente Olivert Riera <[email protected]>
[--SNIP--]
Quoted 14 lines
package/menu-cache/menu-cache.hash new file +2
-0@@ -0,0 +1,2 @@ +# From http://blog.lxde.org/?p=1299 +sha1 e7b3854109f9826472cf9795e924acebe5e27861 menu-cache-1.0.0.tar.xzpackage/menu-cache/menu-cache.mk new file +0
-0
package/menu-cache/menu-cache.mk line 8
Quoted 8 lines
package/menu-cache/menu-cache.mk new file +8
-0@@ -0,0 +1,17 @@ +################################################################################ +# +# menu-cache +# +################################################################################ + +MENU_CACHE_VERSION_MAJOR = 1.0 +MENU_CACHE_VERSION_MINOR = 0
Drop the _MINOR variable.
package/menu-cache/menu-cache.mk line 9
Quoted 1 line
package/menu-cache/menu-cache.mk new file +1
-0+MENU_CACHE_VERSION = $(MENU_CACHE_VERSION_MAJOR).$(MENU_CACHE_VERSION_MINOR)
MENU_CACHE_VERSION = $(MENU_CACHE_VERSION_MAJOR).0
Regards,
Yann E. MORIN.
Quoted 15 lines
package/menu-cache/menu-cache.mk new file +8
-0+MENU_CACHE_SOURCE = menu-cache-$(MENU_CACHE_VERSION).tar.xz +MENU_CACHE_SITE = http://sourceforge.net/projects/lxde/files/menu-cache/$(MENU_CACHE_VERSION_MAJOR) +MENU_CACHE_DEPENDENCIES = libfm-extra libglib2 +MENU_CACHE_LICENSE = LGPLv2.1 +MENU_CACHE_LICENSE_FILES = COPYING +MENU_CACHE_INSTALL_STAGING = YES + +$(eval $(autotools-package))Signature · 6 lines
1.7.1 _______________________________________________ buildroot mailing list buildroot at busybox.net http://lists.busybox.net/mailman/listinfo/buildroot
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------. | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | '------------------------------^-------^------------------^--------------------'
PATCH v2 2/4 menu-cache: new package
In reply to Vicente Olivert RieraDear Vicente Olivert Riera,
Quoted 3 lines · Vicente Olivert Riera
Signed-off-by Vicente Olivert Riera <[email protected]>---
Changes v1 -> v2: Remove GETTEXT and LIBICONV lines. Copy/Paste error
Applied after some changes:
[Thomas:
- Remove the MENU_CACHE_VERSION_MINOR variable, not needed. Noticed by Yann E. Morin.
- Rewrap Config.in help text.]
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com
PATCH v2 3/4 libfm: new package
In reply to Vicente Olivert Riera---
Changes v1 -> v2: nothing
package/Config.in | 1 + package/libfm/Config.in | 27 +++++++++++++++++++++++++++ package/libfm/libfm.hash | 2 ++ package/libfm/libfm.mk | 15 +++++++++++++++ 4 files changed, 45 insertions(+), 0 deletions(-) create mode 100644 package/libfm/Config.in create mode 100644 package/libfm/libfm.hash create mode 100644 package/libfm/libfm.mk
package/Config.in +1 -0
@@ -644,6 +644,7 @@ menu "Graphics" source "package/libdmtx/Config.in" source "package/libdrm/Config.in" source "package/libexif/Config.in" + source "package/libfm/Config.in" source "package/libfm-extra/Config.in" source "package/libgail/Config.in" source "package/libgeotiff/Config.in"
package/libfm/Config.in new file +27 -0
@@ -0,0 +1,27 @@ +config BR2_PACKAGE_LIBFM + bool "libfm" + select BR2_PACKAGE_MENU_CACHE + select BR2_PACKAGE_LIBGLIB2 + select BR2_PACKAGE_LIBGTK2 + select BR2_PACKAGE_CAIRO + select BR2_PACKAGE_XORG7 # libgtk2 + depends on BR2_USE_WCHAR # libglib2 + depends on BR2_TOOLCHAIN_HAS_THREADS # libglib2 + depends on BR2_USE_MMU # libglib2 + depends on BR2_INSTALL_LIBSTDCPP # libgtk2 + depends on BR2_ARCH_HAS_ATOMICS # libgtk2 + help + A glib/gio-based library providing some file management utilities and + related-widgets missing in gtk+/glib. This is the core of PCManFM. + The library is desktop independent (not LXDE specific) and has clean + API. It can be used to develop other applications requiring file + management functionality. For example, you can create your own file + manager with facilities provided by libfm. + + http://wiki.lxde.org/en/Libfm + +comment "libfm needs a toolchain w/ wchar, threads, C++" + depends on BR2_USE_MMU + depends on BR2_ARCH_HAS_ATOMICS + depends on !BR2_USE_WCHAR || !BR2_INSTALL_LIBSTDCPP || \ + !BR2_TOOLCHAIN_HAS_THREADS
package/libfm/libfm.hash new file +2 -0
@@ -0,0 +1,2 @@ +# From http://blog.lxde.org/?p=1280 +sha1 c3f2f34086761d89d6aba549883610084ba00750 libfm-1.2.3.tar.xz
package/libfm/libfm.mk new file +15 -0
@@ -0,0 +1,15 @@ +################################################################################ +# +# libfm +# +################################################################################ + +LIBFM_VERSION = 1.2.3 +LIBFM_SOURCE = libfm-$(LIBFM_VERSION).tar.xz +LIBFM_SITE = http://sourceforge.net/projects/pcmanfm/files +LIBFM_DEPENDENCIES = menu-cache libgtk2 libglib2 cairo +LIBFM_LICENSE = GPLv2 +LIBFM_LICENSE_FILES = COPYING +LIBFM_INSTALL_STAGING = YES + +$(eval $(autotools-package))
Signature · 1 line
1.7.1
PATCH v2 3/4 libfm: new package
vicente, All,
On 2014-11-21 15:33 +0000, Vicente Olivert Riera spake thusly:
Quoted 1 line
Signed-off-by Vicente Olivert Riera <[email protected]>
[--SNIP--]
package/libfm/Config.in line 7
Quoted 13 lines
package/libfm/Config.in new file +7
-0@@ -0,0 +1,27 @@ +config BR2_PACKAGE_LIBFM + bool "libfm" + select BR2_PACKAGE_MENU_CACHE + select BR2_PACKAGE_LIBGLIB2 + select BR2_PACKAGE_LIBGTK2 + select BR2_PACKAGE_CAIRO + select BR2_PACKAGE_XORG7 # libgtk2
I know we said on IRC "The rule is that there is no rule" but I would prefer this be a depends rather than a select.
We currently have no package that select Xorg, which would seem to mean we do have an unwritten rule to not select Xorg. ;-)
Quoted 8 lines
package/libfm/Config.in new file +8
-0+ depends on BR2_USE_WCHAR # libglib2 + depends on BR2_TOOLCHAIN_HAS_THREADS # libglib2 + depends on BR2_USE_MMU # libglib2 + depends on BR2_INSTALL_LIBSTDCPP # libgtk2 + depends on BR2_ARCH_HAS_ATOMICS # libgtk2 + help + A glib/gio-based library providing some file management utilities and + related-widgets missing in gtk+/glib. This is the core of PCManFM.
package/libfm/Config.in line 25
Quoted 10 lines
package/libfm/Config.in new file +10
-0+ The library is desktop independent (not LXDE specific) and has clean + API. It can be used to develop other applications requiring file + management functionality. For example, you can create your own file + manager with facilities provided by libfm. + + http://wiki.lxde.org/en/Libfm + +comment "libfm needs a toolchain w/ wchar, threads, C++" + depends on BR2_USE_MMU + depends on BR2_ARCH_HAS_ATOMICS
So:
comment "libfm needs X.Org and a toolchain w/ wchar, threads, C++"
and appropriate dependencies.
Quoted 17 lines
package/libfm/Config.in new file +2
-0+ depends on !BR2_USE_WCHAR || !BR2_INSTALL_LIBSTDCPP || \ + !BR2_TOOLCHAIN_HAS_THREADSpackage/libfm/libfm.hash new file +2
-0@@ -0,0 +1,2 @@ +# From http://blog.lxde.org/?p=1280 +sha1 c3f2f34086761d89d6aba549883610084ba00750 libfm-1.2.3.tar.xzpackage/libfm/libfm.mk new file +1
-0@@ -0,0 +1,15 @@ +################################################################################
package/libfm/libfm.mk line 11
Quoted 10 lines
package/libfm/libfm.mk new file +10
-0+# +# libfm +# +################################################################################ + +LIBFM_VERSION = 1.2.3 +LIBFM_SOURCE = libfm-$(LIBFM_VERSION).tar.xz +LIBFM_SITE = http://sourceforge.net/projects/pcmanfm/files +LIBFM_DEPENDENCIES = menu-cache libgtk2 libglib2 cairo +LIBFM_LICENSE = GPLv2
Same comment as for libfm-extra (since it's the same package): it is also partly LGPLV2.1+.
package/libfm/libfm.mk line 12
Quoted 1 line
package/libfm/libfm.mk new file +1
-0+LIBFM_LICENSE_FILES = COPYING
But then, I don't see any extra file we could add in there... :-/ Maybe the same as for libfm-extra? Or just src/fm.h ?
Regards,
Yann E. MORIN.
Quoted 10 lines
package/libfm/libfm.mk new file +3
-0+LIBFM_INSTALL_STAGING = YES + +$(eval $(autotools-package))Signature · 6 lines
1.7.1 _______________________________________________ buildroot mailing list buildroot at busybox.net http://lists.busybox.net/mailman/listinfo/buildroot
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------. | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | '------------------------------^-------^------------------^--------------------'
PATCH v2 3/4 libfm: new package
In reply to Vicente Olivert RieraDear Vicente Olivert Riera,
Quoted 3 lines · Vicente Olivert Riera
Signed-off-by Vicente Olivert Riera <[email protected]>---
Changes v1 -> v2: nothing
Applied after some changes:
[Thomas:
- switch from 'select BR2_PACKAGE_XORG7' to 'depends on BR2_PACKAGE_XORG7' as suggested by Yann E. Morin.
- add LGPLv2.1+ in the list of licenses as well as a corresponding license file, as suggested by Yann E. Morin.]
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com
PATCH v2 4/4 pcmanfm: bump version to 1.2.3
In reply to Vicente Olivert Riera- Bump version to 1.2.3
- Remove unnecessary patch
- Add a hash file
---
Changes v1 -> v2: nothing
package/pcmanfm/Config.in | 32 +++++++++++--------- package/pcmanfm/pcmanfm-link-against-libx11.patch | 20 ------------- package/pcmanfm/pcmanfm.hash | 2 + package/pcmanfm/pcmanfm.mk | 11 +++---- 4 files changed, 25 insertions(+), 40 deletions(-) delete mode 100644 package/pcmanfm/pcmanfm-link-against-libx11.patch create mode 100644 package/pcmanfm/pcmanfm.hash
package/pcmanfm/Config.in +18 -14
@@ -1,20 +1,24 @@ config BR2_PACKAGE_PCMANFM bool "pcmanfm" - depends on BR2_PACKAGE_XORG7 - depends on BR2_USE_WCHAR # glib2 - depends on BR2_TOOLCHAIN_HAS_THREADS # glib2 - depends on BR2_USE_MMU # glib2 - select BR2_PACKAGE_GAMIN - select BR2_PACKAGE_STARTUP_NOTIFICATION - select BR2_PACKAGE_XLIB_LIBX11 - depends on BR2_PACKAGE_LIBGTK2 + select BR2_PACKAGE_LIBFM + select BR2_PACKAGE_MENU_CACHE + select BR2_PACKAGE_LIBGLIB2 + select BR2_PACKAGE_LIBGTK2 + select BR2_PACKAGE_XORG7 # libgtk2 + depends on BR2_USE_WCHAR # libglib2 + depends on BR2_TOOLCHAIN_HAS_THREADS # libglib2 + depends on BR2_USE_MMU # libglib2 + depends on BR2_INSTALL_LIBSTDCPP # libgtk2 + depends on BR2_ARCH_HAS_ATOMICS # libgtk2 help - An extremely fast and lightweight file manager which features - tabbed browsing and a user-friendly interface. + PCMan File Manager (PCManFM) is a file manager application developed + by Hong Jen Yee from Taiwan which is meant to be a replacement for + Nautilus, Konqueror and Thunar. - http://internap.dl.sourceforge.net/sourceforge/pcmanfm + http://wiki.lxde.org/en/PCManFM -comment "pcmanfm needs a toolchain w/ wchar, threads" - depends on BR2_PACKAGE_XORG7 && BR2_PACKAGE_LIBGTK2 - depends on !BR2_USE_WCHAR || !BR2_TOOLCHAIN_HAS_THREADS +comment "pcmanfm needs a toolchain w/ wchar, threads, C++" depends on BR2_USE_MMU + depends on BR2_ARCH_HAS_ATOMICS + depends on !BR2_USE_WCHAR || !BR2_INSTALL_LIBSTDCPP || \ + !BR2_TOOLCHAIN_HAS_THREADS
package/pcmanfm/pcmanfm-link-against-libx11.patch deleted +0 -20
@@ -1,20 +0,0 @@ -Link against libX11 - -fm-desktop.c uses XSendEvent, so we should link against libX11. - -Signed-off-by: Thomas Petazzoni <[email protected]> - -Index: b/configure.in -=================================================================== ---- a/configure.in -+++ b/configure.in -@@ -12,7 +12,8 @@ - - pkg_modules="gtk+-2.0 >= 2.6.0 \ - gthread-2.0 \ -- libstartup-notification-1.0" -+ libstartup-notification-1.0 \ -+ x11" - - AC_FUNC_MMAP -
package/pcmanfm/pcmanfm.hash new file +2 -0
@@ -0,0 +1,2 @@ +# From http://blog.lxde.org/?p=1280 +sha1 0a195301de31c82f1c169e620be7cea8b91813b5 pcmanfm-1.2.3.tar.xz
package/pcmanfm/pcmanfm.mk +5 -6
@@ -4,12 +4,11 @@ # ################################################################################ -PCMANFM_VERSION = 0.3.5.9 -PCMANFM_SITE = http://downloads.sourceforge.net/project/pcmanfm/pcmanfm-legacy%20%28Old%200.5%20series%29/PCManFM%20$(PCMANFM_VERSION) -PCMANFM_CONF_OPTS = --disable-hal -PCMANFM_DEPENDENCIES = host-pkgconf libgtk2 gamin startup-notification xlib_libX11 -PCMANFM_AUTORECONF = YES -PCMANFM_LICENSE = GPLv2+ +PCMANFM_VERSION = 1.2.3 +PCMANFM_SOURCE = pcmanfm-$(PCMANFM_VERSION).tar.xz +PCMANFM_SITE = http://sourceforge.net/projects/pcmanfm/files +PCMANFM_DEPENDENCIES = libgtk2 libglib2 menu-cache libfm +PCMANFM_LICENSE = GPLv2 PCMANFM_LICENSE_FILES = COPYING $(eval $(autotools-package))
Signature · 1 line
1.7.1
PATCH v2 4/4 pcmanfm: bump version to 1.2.3
Dear Vicente Olivert Riera,
Quoted 7 lines · Vicente Olivert Riera
- Bump version to 1.2.3
- Remove unnecessary patch
- Add a hash fileSigned-off-by Vicente Olivert Riera <[email protected]>---
Changes v1 -> v2: nothing
Applied after some changes:
[Thomas:
- adapt patch to the latest master
- license is GPLv2+, not GPLv2
- replace 'select BR2_PACKAGE_XORG7' by 'depends on BR2_PACKAGE_XORG7']
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com
PATCH v2 1/4 libfm-extra: new package
In reply to Vicente Olivert RieraDear Vicente Olivert Riera,
package/libfm-extra/libfm-extra.mk line 8
Quoted 2 lines · Vicente Olivert Riera
package/libfm-extra/libfm-extra.mk new file +2
-0+LIBFM_EXTRA_VERSION = 1.2.3 +LIBFM_EXTRA_SOURCE = libfm-$(LIBFM_EXTRA_VERSION).tar.xz
This is the exact same tarball as the one used for the libfm package:
+LIBFM_VERSION = 1.2.3
+LIBFM_SOURCE = libfm-$(LIBFM_VERSION).tar.xz +LIBFM_SITE = http://sourceforge.net/projects/pcmanfm/files
Why do we have two different packages? Is it because libfm full version needs menu-cache, and menu-cache needs libfm-extra? This really seems weird.
Can you elaborate on this?
Thanks,
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com
PATCH v2 1/4 libfm-extra: new package
Dear Thomas Petazzoni,
Quoted 13 lines · Thomas Petazzoni
Dear Vicente Olivert Riera,
package/libfm-extra/libfm-extra.mk line 8
Quoted 2 lines · Vicente Olivert Riera
package/libfm-extra/libfm-extra.mk new file +2
-0+LIBFM_EXTRA_VERSION = 1.2.3 +LIBFM_EXTRA_SOURCE = libfm-$(LIBFM_EXTRA_VERSION).tar.xzThis is the exact same tarball as the one used for the libfm package:
(quoted diff) +3
-0+LIBFM_VERSION = 1.2.3 +LIBFM_SOURCE = libfm-$(LIBFM_VERSION).tar.xz +LIBFM_SITE = http://sourceforge.net/projects/pcmanfm/files
Quoted 2 lines
Why do we have two different packages? Is it because libfm full version needs menu-cache, and menu-cache needs libfm-extra?
Yes, that is exactly the reason. Look for instance how is done in LinuxFromScratch:
http://www.linuxfromscratch.org/blfs/view/svn/lxde/libfm-extra.html
They build libfm-extra first, then menu-cache and then libfm. I did exactly the same.
Cheers,
Signature · 5 lines
Vicente Olivert Riera Graduate Software Engineer, MIPS Processor IP Imagination Technologies Limited t: +44 (0)113 2429814 www.imgtec.com
PATCH v2 1/4 libfm-extra: new package
Dear Vicente Olivert Riera,
Quoted 20 lines · Vicente Olivert Riera
Quoted 13 lines · Thomas Petazzoni
Dear Vicente Olivert Riera,
package/libfm-extra/libfm-extra.mk line 8
Quoted 2 lines · Vicente Olivert Riera
package/libfm-extra/libfm-extra.mk new file +2
-0+LIBFM_EXTRA_VERSION = 1.2.3 +LIBFM_EXTRA_SOURCE = libfm-$(LIBFM_EXTRA_VERSION).tar.xzThis is the exact same tarball as the one used for the libfm package:
(quoted diff) +3
-0+LIBFM_VERSION = 1.2.3 +LIBFM_SOURCE = libfm-$(LIBFM_VERSION).tar.xz +LIBFM_SITE = http://sourceforge.net/projects/pcmanfm/filesQuoted 2 lines
Why do we have two different packages? Is it because libfm full version needs menu-cache, and menu-cache needs libfm-extra?
Yes, that is exactly the reason. Look for instance how is done in LinuxFromScratch:
Quoted 4 lines
http://www.linuxfromscratch.org/blfs/view/svn/lxde/libfm-extra.html
They build libfm-extra first, then menu-cache and then libfm. I did exactly the same.
And you didn't explain that anywhere in the commit logs? No comments about this in the code? If you want such non-obvious stuff to be merged one day, you should at least add a little bit of explanation about it.
This all seems a bit crazy. How are the pcmanfm people building their stuff?
Thanks!
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com
PATCH v2 1/4 libfm-extra: new package
Dear Thomas Petazzoni,
Quoted 24 lines · Thomas Petazzoni
Dear Vicente Olivert Riera,
Quoted 20 lines · Vicente Olivert Riera
Quoted 13 lines · Thomas Petazzoni
Dear Vicente Olivert Riera,
package/libfm-extra/libfm-extra.mk line 8
Quoted 2 lines · Vicente Olivert Riera
package/libfm-extra/libfm-extra.mk new file +2
-0+LIBFM_EXTRA_VERSION = 1.2.3 +LIBFM_EXTRA_SOURCE = libfm-$(LIBFM_EXTRA_VERSION).tar.xzThis is the exact same tarball as the one used for the libfm package:
(quoted diff) +3
-0+LIBFM_VERSION = 1.2.3 +LIBFM_SOURCE = libfm-$(LIBFM_VERSION).tar.xz +LIBFM_SITE = http://sourceforge.net/projects/pcmanfm/filesQuoted 2 lines
Why do we have two different packages? Is it because libfm full version needs menu-cache, and menu-cache needs libfm-extra?
Yes, that is exactly the reason. Look for instance how is done in LinuxFromScratch:
Quoted 8 lines
Quoted 4 lines
http://www.linuxfromscratch.org/blfs/view/svn/lxde/libfm-extra.html
They build libfm-extra first, then menu-cache and then libfm. I did exactly the same.
And you didn't explain that anywhere in the commit logs? No comments about this in the code? If you want such non-obvious stuff to be merged one day, you should at least add a little bit of explanation about it.
If you want, I don't mind to respin my patches adding more information about that. But please, don't say that there is zero information because in the "help" message of the libfm-extra package I added a short text saying that package is needed for menu-cache:
+ help
+ The libfm-extra package contains a library and other files
+ required by menu-cache-gen libexec of menu-cache-1.0.0
And also in the cover-letter:
http://lists.busybox.net/pipermail/buildroot/2014-November/112652.html
Quoted 2 lines
This all seems a bit crazy. How are the pcmanfm people building their stuff?
They are building it in that way. First libfm-extra, then menu-cache, then libfm and finally pcmanfm.
Cheers,
Signature · 5 lines
Vicente Olivert Riera Graduate Software Engineer, MIPS Processor IP Imagination Technologies Limited t: +44 (0)113 2429814 www.imgtec.com
PATCH v2 1/4 libfm-extra: new package
In reply to Vicente Olivert RieraVincet, All,
On 2014-11-21 15:33 +0000, Vicente Olivert Riera spake thusly:
Quoted 1 line
Signed-off-by Vicente Olivert Riera <[email protected]>
[--SNIP--]
Quoted 7 lines
package/libfm-extra/libfm-extra.mk new file +1
-0@@ -0,0 +1,16 @@ +################################################################################
package/libfm-extra/libfm-extra.mk line 11
Quoted 10 lines
package/libfm-extra/libfm-extra.mk new file +10
-0+# +# libfm-extra +# +################################################################################ + +LIBFM_EXTRA_VERSION = 1.2.3 +LIBFM_EXTRA_SOURCE = libfm-$(LIBFM_EXTRA_VERSION).tar.xz +LIBFM_EXTRA_SITE = http://sourceforge.net/projects/pcmanfm/files +LIBFM_EXTRA_DEPENDENCIES = libglib2 +LIBFM_EXTRA_LICENSE = GPLv2
Dome files have the LGPLV2.1+ header, like:
src/fm.c
src/fm-extra.h
src/base/fm-app-info.c
[...]Also, the only file that seem to get compiled is:
src/extra/fm-xml-file.c
for which the header states it is LGPLv2.1+.
So, even if there's only the COPYING for the GPLv2 and that we only compile an LGPLv2.1+ file, I'd state both licenses.
package/libfm-extra/libfm-extra.mk line 12
Quoted 1 line
package/libfm-extra/libfm-extra.mk new file +1
-0+LIBFM_EXTRA_LICENSE_FILES = COPYING
Here, I'd add src/extra/fm-xml-file.c as a license file, too.
Regards,
Yann E. MORIN.
Quoted 11 lines
package/libfm-extra/libfm-extra.mk new file +4
-0+LIBFM_EXTRA_INSTALL_STAGING = YES +LIBFM_EXTRA_CONF_OPTS = --with-extra-only --with-gtk=no + +$(eval $(autotools-package))Signature · 6 lines
1.7.1 _______________________________________________ buildroot mailing list buildroot at busybox.net http://lists.busybox.net/mailman/listinfo/buildroot
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------. | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | '------------------------------^-------^------------------^--------------------'
PATCH v2 1/4 libfm-extra: new package
Dear Yann E. MORIN,
Quoted 7 lines · Yann E. MORIN
Also, the only file that seem to get compiled is:
src/extra/fm-xml-file.cfor which the header states it is LGPLv2.1+.
So, even if there's only the COPYING for the GPLv2 and that we only compile an LGPLv2.1+ file, I'd state both licenses.
I'm not sure here: since some files of the library are under the GPL, the library as a whole is under the GPL, even though some parts of it are under other licenses.
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com
PATCH v2 1/4 libfm-extra: new package
Thomas, All,
On 2014-12-10 22:10 +0100, Thomas Petazzoni spake thusly:
Quoted 5 lines · Yann E. MORIN
Quoted 4 lines
Also, the only file that seem to get compiled is:
src/extra/fm-xml-file.c
Quoted 8 lines
Quoted 4 lines
for which the header states it is LGPLv2.1+.
So, even if there's only the COPYING for the GPLv2 and that we only compile an LGPLv2.1+ file, I'd state both licenses.
I'm not sure here: since some files of the library are under the GPL, the library as a whole is under the GPL, even though some parts of it are under other licenses.
Yes, the GPL gobbles up the LGPL, because of its stronger requirements. But licensing wise, they are both applicable licenses.
Even worse in this case, the resulting combination is probably just LGPLv2.1+, since the only compiled file is LGPLv2.1+.
So, I'd prefer we stride on the safe side, and include both licenses, and delegate to the user (and/or his legal team) the decision as to what license is applicable.
We are not lawyer, and this is a complicated matter.
Regards,
Yann E. MORIN.
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------. | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | '------------------------------^-------^------------------^--------------------'
PATCH v2 1/4 libfm-extra: new package
Dear Yann E. MORIN,
Quoted 5 lines · Yann E. MORIN
Yes, the GPL gobbles up the LGPL, because of its stronger requirements. But licensing wise, they are both applicable licenses.
Even worse in this case, the resulting combination is probably just LGPLv2.1+, since the only compiled file is LGPLv2.1+.
Ah, indeed if the only compiled files are LGPLv2.1+, then the <pkg>_LICENSE should state that, because it's quite important. Usually something like LGPLv2.1+ (library), GPLv2+ (<some other stuff>).
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com
PATCH v2 1/4 libfm-extra: new package
In reply to Vicente Olivert RieraVicente, All,
Some further review I previously missed...
On 2014-11-21 15:33 +0000, Vicente Olivert Riera spake thusly:
Quoted 1 line
Signed-off-by Vicente Olivert Riera <[email protected]>
[--SNIP--]
Quoted 9 lines
package/libfm-extra/Config.in new file +3
-0@@ -0,0 +1,15 @@ +config BR2_PACKAGE_LIBFM_EXTRA + bool "libfm-extra" + select BR2_PACKAGE_LIBGLIB2
package/libfm-extra/Config.in line 13
Quoted 10 lines
package/libfm-extra/Config.in new file +10
-0+ depends on BR2_USE_WCHAR # libglib2 + depends on BR2_TOOLCHAIN_HAS_THREADS # libglib2 + depends on BR2_USE_MMU # libglib2 + help + The libfm-extra package contains a library and other files + required by menu-cache-gen libexec of menu-cache-1.0.0 + + http://wiki.lxde.org/en/Libfm + +comment "libfm-extra needs a toolchain w/ wchar, threads, C++"
"C++" is not needed. Stray copy-paste? ;-)
Regards,
Yann E. MORIN.
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------. | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | '------------------------------^-------^------------------^--------------------'
PATCH v2 1/4 libfm-extra: new package
In reply to Vicente Olivert RieraDear Vicente Olivert Riera,
Quoted 3 lines · Vicente Olivert Riera
Signed-off-by Vicente Olivert Riera <[email protected]>---
Changes v1 -> v2: nothing
Applied after some changes:
[Thomas:
- adjust license: it's actually under GPLv2+, plus some bits under LGPLv2.1+ as noticed by Yann E. Morin, and add another license file for LGPLv2.1+
- add missing dependency on host-intltool.]
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com