mtr: bump to version 0.86 and use github call

---
 package/mtr/mtr.mk | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

index aa4d883..f376d47 100644
@@ -4,9 +4,10 @@
 #
 ################################################################################
 
-MTR_VERSION = 0.85
-MTR_SITE = ftp://ftp.bitwizard.nl/mtr
-MTR_CONF_OPTS = --without-gtk --without-glib
+MTR_VERSION = v0.86
+MTR_SITE = $(call github,traviscross,mtr,$(MTR_VERSION))
+MTR_AUTORECONF = YES
+MTR_CONF_OPT = --without-gtk --without-glib
 MTR_DEPENDENCIES = host-pkgconf $(if $(BR2_PACKAGE_NCURSES),ncurses)
 MTR_LICENSE = GPLv2
 MTR_LICENSE_FILES = COPYING

2.1.3

---
 package/mtr/mtr.mk | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

index aa4d883..75cadc1 100644
@@ -4,8 +4,9 @@
 #
 ################################################################################
 
-MTR_VERSION = 0.85
-MTR_SITE = ftp://ftp.bitwizard.nl/mtr
+MTR_VERSION = v0.86
+MTR_SITE = $(call github,traviscross,mtr,$(MTR_VERSION))
+MTR_AUTORECONF = YES
 MTR_CONF_OPTS = --without-gtk --without-glib
 MTR_DEPENDENCIES = host-pkgconf $(if $(BR2_PACKAGE_NCURSES),ncurses)
 MTR_LICENSE = GPLv2

2.1.3

Dear Ivan Sergeev,

just a few things:

The '--without-glib' option doesn't exist in the configure script. You can remove it.

Also, while you are doing the version bump, why not adding a hash file as well:

http://buildroot.uclibc.org/downloads/manual/manual.html#adding-packages-hash

Could you please mark the previous versions of this patch as 'superseded' in patchwork?

And finally, could you please state what changes you make between versions?

Best regards,

Vicente Olivert Riera
Graduate Software Engineer, MIPS Platforms
Imagination Technologies Limited
t: +44 (0)113 2429814
www.imgtec.com

Dear Vicente Olivert Riera,

Are you sure it makes sense to have hash files for github downloads?

There were some patches from Maxime Hadjinlian to remove hash files for github-sourced packages.

Also, when you reply to someone on the list, you should reply both to the person (as To:) and the list (as Cc:). This will make sure the person you reply to actually sees the message, and your message is not mixed in the fairly heavy flow of e-mails that goes through the list.

Thanks!

Thomas

Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

Hi Thomas,

yes, it makes sense. If you download a released tarball, it's supposed the hash of that tarball should be always the same.

In fact, I would change the download url to this one:

https://github.com/traviscross/mtr/releases

Cheers,
--
Vicente Olivert Riera
Graduate Software Engineer, MIPS Processor IP
Imagination Technologies Limited
t: +44 (0)113 2429814
www.imgtec.com

Dear Vicente Olivert Riera,

Thanks, sure. I'll look out for stale configure options and keep things in sync with patchwork next time around.

Thanks,
~vsergeev
Ivan Sergeev

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20141212/3f243b6c/attachment-0001.html>

Dear Ivan Sergeev,

Thanks, I've applied your patch, after removing the --without-glib option that is no longer useful.

Also, if you have some time to work on mtr, it would be good to get rid of the ugly:

# uClibc has res_ninit but not res_nmkquery
ifeq ($(BR2_TOOLCHAIN_USES_UCLIBC),y)
define MTR_DISABLE_RES_NINIT

        $(SED) 's/#ifdef res_ninit/#if 0/' \
                $(@D)/dns.c

endef
endif

MTR_POST_PATCH_HOOKS += MTR_DISABLE_RES_NINIT

that we have in package/mtr/mtr.mk. To do this, some improvements to configure.ac are needed to detect if the C library has res_ninit() and res_nmkquery(). Feel free to work this out with upstream :-)

Thanks!

Thomas Petazzoni

Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com