ARM: shmobile: r8a7794: Add QSPI clock to device tree
Subsystems (3)
PATCH 1/1 ARM: shmobile: r8a7794: Add QSPI clock to device tree
From: Hisashi Nakamura <[email protected]>
---
Based on the renesas-devel-20141211-v3.18 tag of my renesas tree
Changes by Simon Horman
* Removed portions of patch which add device node and alias
* Renamed patch from
"ARM: shmobile: r8a7794: Add QSPI clock and device to device tree" to "ARM: shmobile: r8a7794: Add QSPI clock to device tree"
--- arch/arm/boot/dts/r8a7794.dtsi | 8 ++++++++ include/dt-bindings/clock/r8a7794-clock.h | 1 + 2 files changed, 9 insertions(+)
arch/arm/boot/dts/r8a7794.dtsi +8 -0
@@ -535,6 +535,14 @@ clock-output-names = "vin1", "vin0", "ether"; }; + mstp9_clks: mstp9_clks at e6150994 { + compatible = "renesas,r8a7794-mstp-clocks", "renesas,cpg-mstp-clocks"; + reg = <0 0xe6150994 0 4>, <0 0xe61509a4 0 4>; + clocks = <&cpg_clocks R8A7794_CLK_QSPI>; + #clock-cells = <1>; + renesas,clock-indices = <R8A7794_CLK_QSPI_MOD>; + clock-output-names = "qspi_mod"; + }; mstp11_clks: mstp11_clks at e615099c { compatible = "renesas,r8a7794-mstp-clocks", "renesas,cpg-mstp-clocks"; reg = <0 0xe615099c 0 4>, <0 0xe61509ac 0 4>;
include/dt-bindings/clock/r8a7794-clock.h +1 -0
@@ -86,6 +86,7 @@#define R8A7794_CLK_GPIO2 10#define R8A7794_CLK_GPIO1 11#define R8A7794_CLK_GPIO0 12 +#define R8A7794_CLK_QSPI_MOD 17/* MSTP11 */ #define R8A7794_CLK_SCIFA3 6
Signature · 1 line
2.1.3
PATCH 1/1 ARM: shmobile: r8a7794: Add QSPI clock to device tree
Hi Simon
Quoted 25 lines
From: Hisashi Nakamura <[email protected]>
Signed-off-by Hisashi Nakamura <[email protected]>[horms: omitted device node and alias; only add clock]Signed-off-by Simon Horman <[email protected], not device nodes:u>---
Based on the renesas-devel-20141211-v3.18 tag of my renesas treeChanges by Simon Horman
* Removed portions of patch which add device node and alias
* Renamed patch from
"ARM: shmobile: r8a7794: Add QSPI clock and device to device tree" to "ARM: shmobile: r8a7794: Add QSPI clock to device tree"--- arch/arm/boot/dts/r8a7794.dtsi | 8 ++++++++ include/dt-bindings/clock/r8a7794-clock.h | 1 + 2 files changed, 9 insertions(+)arch/arm/boot/dts/r8a7794.dtsi +0
-0@@ -535,6 +535,14 @@ clock-output-names =
arch/arm/boot/dts/r8a7794.dtsi line 545
Quoted 10 lines
arch/arm/boot/dts/r8a7794.dtsi +8
-0"vin1", "vin0", "ether"; }; + mstp9_clks: mstp9_clks at e6150994 { + compatible = "renesas,r8a7794-mstp-clocks", "renesas,cpg-mstp-clocks"; + reg = <0 0xe6150994 0 4>, <0 0xe61509a4 0 4>; + clocks = <&cpg_clocks R8A7794_CLK_QSPI>; + #clock-cells = <1>; + renesas,clock-indices = <R8A7794_CLK_QSPI_MOD>; + clock-output-names = "qspi_mod"; + };
We want ot use this ?
- renesas,clock-indices
+ clock-indices
PATCH 1/1 ARM: shmobile: r8a7794: Add QSPI clock to device tree
Quoted 41 lines · Kuninori Morimoto
Hi Simon
Quoted 25 lines
From: Hisashi Nakamura <[email protected]>
Signed-off-by Hisashi Nakamura <[email protected]>[horms: omitted device node and alias; only add clock]Signed-off-by Simon Horman <[email protected], not device nodes:u>---
Based on the renesas-devel-20141211-v3.18 tag of my renesas treeChanges by Simon Horman
* Removed portions of patch which add device node and alias
* Renamed patch from
"ARM: shmobile: r8a7794: Add QSPI clock and device to device tree" to "ARM: shmobile: r8a7794: Add QSPI clock to device tree"--- arch/arm/boot/dts/r8a7794.dtsi | 8 ++++++++ include/dt-bindings/clock/r8a7794-clock.h | 1 + 2 files changed, 9 insertions(+)arch/arm/boot/dts/r8a7794.dtsi +0
-0@@ -535,6 +535,14 @@ clock-output-names =arch/arm/boot/dts/r8a7794.dtsi line 545
Quoted 10 lines
arch/arm/boot/dts/r8a7794.dtsi +8
-0"vin1", "vin0", "ether"; }; + mstp9_clks: mstp9_clks at e6150994 { + compatible = "renesas,r8a7794-mstp-clocks", "renesas,cpg-mstp-clocks"; + reg = <0 0xe6150994 0 4>, <0 0xe61509a4 0 4>; + clocks = <&cpg_clocks R8A7794_CLK_QSPI>; + #clock-cells = <1>; + renesas,clock-indices = <R8A7794_CLK_QSPI_MOD>; + clock-output-names = "qspi_mod"; + };We want ot use this ?
Quoted 2 lines
- renesas,clock-indices
+ clock-indices
Thanks, and sorry for missing that. I'll fix that up.
Do you have any objections to the patch if that problem is resolved?
PATCH 1/1 ARM: shmobile: r8a7794: Add QSPI clock to device tree
Hi Simon
Quoted 15 lines
Quoted 15 lines
arch/arm/boot/dts/r8a7794.dtsi line 545
Quoted 12 lines
arch/arm/boot/dts/r8a7794.dtsi +8
-0@@ -535,6 +535,14 @@ clock-output-names = "vin1", "vin0", "ether"; }; + mstp9_clks: mstp9_clks at e6150994 { + compatible = "renesas,r8a7794-mstp-clocks", "renesas,cpg-mstp-clocks"; + reg = <0 0xe6150994 0 4>, <0 0xe61509a4 0 4>; + clocks = <&cpg_clocks R8A7794_CLK_QSPI>; + #clock-cells = <1>; + renesas,clock-indices = <R8A7794_CLK_QSPI_MOD>; + clock-output-names = "qspi_mod"; + };We want ot use this ?
Quoted 5 lines
Quoted 2 lines
- renesas,clock-indices
+ clock-indicesThanks, and sorry for missing that. I'll fix that up.
Do you have any objections to the patch if that problem is resolved?
Thank you
I have no objections.
PATCH 1/1 ARM: shmobile: r8a7794: Add QSPI clock to device tree
In reply to Simon HormanQuoted 5 lines · Simon Horman
From: Hisashi Nakamura <[email protected]>
Signed-off-by Hisashi Nakamura <[email protected]>[horms: omitted device node and alias; only add clock]Signed-off-by Simon Horman <[email protected], not device nodes:u>
(After fixing renesas,clock-indices, as reported by Morimoto-san)
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
PATCH 1/1 ARM: shmobile: r8a7794: Add QSPI clock to device tree
Quoted 11 lines · Geert Uytterhoeven
Quoted 5 lines · Simon Horman
From: Hisashi Nakamura <[email protected]>
Signed-off-by Hisashi Nakamura <[email protected]>[horms: omitted device node and alias; only add clock]Signed-off-by Simon Horman <[email protected], not device nodes:u>(After fixing renesas,clock-indices, as reported by Morimoto-san)
Thanks, I have queued up the revised version.