Skip to contentSkip to conversation

legacy: update the BR2_PREFER_STATIC_LIB option

PATCH Superseded Samuel Martin 2 participants 2 messages Dec 14, 2014

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore

Samuel Martin

author
#0 lore raw

PATCH 1/1 legacy: update the BR2_PREFER_STATIC_LIB option

Since the refactoring of the type of libraries in the target filesystem, these options belong to a choice, and the default is "shared only".

The former option BR2_PREFER_STATIC_LIB has been moved in the legacy menu, and only selects the BR2_STATIC_LIBS ("static only") option. However, because BR2_STATIC_LIBS belongs to a choice, when BR2_PREFER_STATIC_LIB is selected, it does not affect the choice. So, existing Buildroot configurations, which have BR2_PREFER_STATIC_LIB set, will silently end with BR2_SHARED_LIBS ("shared only") enabled.

So, the backward compatibility is not kept.

Besides, the legacy BR2_PREFER_STATIC_LIB option doesn not select BR2_LEGACY, so the user is not notify of this legacy option, and the build silently continues with some undesired changes.

This patch removes the inefficient BR2_STATIC_LIBS selection, correctly selects the BR2_LEGACY option and extend the hepl message so the user can easily know how to update his/her Buildroot configuration.

Signed-off-by Samuel Martin <[email protected]>
Cc "Yann E. MORIN" <[email protected]>
Cc Thomas Petazzoni <[email protected]>
---
 Config.in.legacy | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)
Config.in.legacy +4 -1
index 09c025c..a969662 100644
@@ -104,13 +104,16 @@ comment "Legacy options removed in 2015.02"
 
 config BR2_PREFER_STATIC_LIB
 	bool "static library option renamed"
-	select BR2_STATIC_LIBS
+	select BR2_LEGACY
 	help
 	  The BR2_PREFER_STATIC_LIB was renamed to BR2_STATIC_LIBS. It
 	  highlights the fact that the option no longer "prefers"
 	  static libraries, but "enforces" static libraries (i.e
 	  shared libraries are completely unused).
 
+	  Take care of updating the type of libraries you want under the
+	  "Build options" menu.
+
 comment "Legacy options removed in 2014.11"
 
 config BR2_x86_generic
Signature · 1 line
2.1.3
#1 lore raw

PATCH 1/1 legacy: update the BR2_PREFER_STATIC_LIB option

Samuel, All,

On 2014-12-14 17:08 +0100, Samuel Martin spake thusly:

Quoted 10 lines

Since the refactoring of the type of libraries in the target filesystem, these options belong to a choice, and the default is "shared only".

The former option BR2_PREFER_STATIC_LIB has been moved in the legacy menu, and only selects the BR2_STATIC_LIBS ("static only") option. However, because BR2_STATIC_LIBS belongs to a choice, when BR2_PREFER_STATIC_LIB is selected, it does not affect the choice. So, existing Buildroot configurations, which have BR2_PREFER_STATIC_LIB set, will silently end with BR2_SHARED_LIBS ("shared only") enabled.

Quoted 3 lines

So, the backward compatibility is not kept.

Besides, the legacy BR2_PREFER_STATIC_LIB option doesn not select

s/doesn/does/

Quoted 1 line

BR2_LEGACY, so the user is not notify of this legacy option, and the

s/notify/notified/

Quoted 4 lines

build silently continues with some undesired changes.

This patch removes the inefficient BR2_STATIC_LIBS selection, correctly selects the BR2_LEGACY option and extend the hepl message so the user

s/hepl/help/

It seems I'm not the only one to suffer from kebord dislexia. Hehe! ;-)

Quoted 5 lines

can easily know how to update his/her Buildroot configuration.

Signed-off-by Samuel Martin <[email protected]>
Cc "Yann E. MORIN" <[email protected]>
Cc Thomas Petazzoni <[email protected]>

Otherwise:

Acked-by "Yann E. MORIN" <[email protected]>

Regards,
Yann E. MORIN.

Quoted 29 lines
---
 Config.in.legacy | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)
Config.in.legacy +4 -1
index 09c025c..a969662 100644
@@ -104,13 +104,16 @@ comment "Legacy options removed in 2015.02"
 
 config BR2_PREFER_STATIC_LIB
 	bool "static library option renamed"
-	select BR2_STATIC_LIBS
+	select BR2_LEGACY
 	help
 	  The BR2_PREFER_STATIC_LIB was renamed to BR2_STATIC_LIBS. It
 	  highlights the fact that the option no longer "prefers"
 	  static libraries, but "enforces" static libraries (i.e
 	  shared libraries are completely unused).
 
+	  Take care of updating the type of libraries you want under the
+	  "Build options" menu.
+
 comment "Legacy options removed in 2014.11"
 
 config BR2_x86_generic
Signature · 1 line
2.1.3
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'