drm/i915/bdw: Enable execlists by default where supported
Subsystems (2)
PATCH 1/1 drm/i915/bdw: Enable execlists by default where supported
Execlist support in the i915 driver is now considered good enough for the feature to be enabled by default on Gen8 and later and routinely tested. Adjusted i915 parameters structure initialization to reflect this and updated the comment in intel_sanitize_enable_execlists().
Issue: VIZ-2020
--- drivers/gpu/drm/i915/i915_params.c | 2 +- drivers/gpu/drm/i915/intel_lrc.c | 3 +-- 2 files changed, 2 insertions(+), 3 deletions(-)
drivers/gpu/drm/i915/i915_params.c +1 -1
@@ -35,7 +35,7 @@ struct i915_params i915 __read_mostly = { .vbt_sdvo_panel_type = -1, .enable_rc6 = -1, .enable_fbc = -1, - .enable_execlists = 0, + .enable_execlists = -1, .enable_hangcheck = true, .enable_ppgtt = -1, .enable_psr = 0,
drivers/gpu/drm/i915/intel_lrc.c +1 -2
@@ -212,8 +212,7 @@ static int intel_lr_context_pin(struct intel_engine_cs *ring,* @enable_execlists: value of i915.enable_execlists module parameter. * * Only certain platforms support Execlists (the prerequisites being -* support for Logical Ring Contexts and Aliasing PPGTT or better), -* and only when enabled via module parameter. +* support for Logical Ring Contexts and Aliasing PPGTT or better). * * Return: 1 if Execlists is supported and has to be enabled. */
Signature · 6 lines
1.7.9.5 _______________________________________________ Intel-gfx mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Jani Nikula
maintainerQuoted 4 lines · Thomas Daniel
Execlist support in the i915 driver is now considered good enough for the feature to be enabled by default on Gen8 and later and routinely tested. Adjusted i915 parameters structure initialization to reflect this and updated the comment in
intel_sanitize_enable_execlists().
Please update the MODULE_PARM_DESC too.
BR,
Jani.
Quoted 42 lines
Issue: VIZ-2020
Signed-off-by Thomas Daniel <[email protected]>--- drivers/gpu/drm/i915/i915_params.c | 2 +- drivers/gpu/drm/i915/intel_lrc.c | 3 +-- 2 files changed, 2 insertions(+), 3 deletions(-)drivers/gpu/drm/i915/i915_params.c +1
-1@@ -35,7 +35,7 @@ struct i915_params i915 __read_mostly = { .vbt_sdvo_panel_type = -1, .enable_rc6 = -1, .enable_fbc = -1, - .enable_execlists = 0, + .enable_execlists = -1, .enable_hangcheck = true, .enable_ppgtt = -1, .enable_psr = 0,drivers/gpu/drm/i915/intel_lrc.c +1
-2@@ -212,8 +212,7 @@ static int intel_lr_context_pin(struct intel_engine_cs *ring,* @enable_execlists: value of i915.enable_execlists module parameter. * * Only certain platforms support Execlists (the prerequisites being -* support for Logical Ring Contexts and Aliasing PPGTT or better), -* and only when enabled via module parameter. +* support for Logical Ring Contexts and Aliasing PPGTT or better). * * Return: 1 if Execlists is supported and has to be enabled. */ Signature · 6 lines
1.7.9.5 _______________________________________________ Intel-gfx mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Signature · 5 lines
Jani Nikula, Intel Open Source Technology Center _______________________________________________ Intel-gfx mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 7 lines · Jani Nikula
Quoted 4 lines · Thomas Daniel
Execlist support in the i915 driver is now considered good enough for the feature to be enabled by default on Gen8 and later and routinely tested. Adjusted i915 parameters structure initialization to reflect this and updated the comment in
intel_sanitize_enable_execlists().Please update the
MODULE_PARM_DESCtoo.
Also we probably want to add a _debug annotation to this one given the hw team doesn't really like legacy submission all that much any more. -Daniel
Signature · 7 lines
Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch _______________________________________________ Intel-gfx mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH v2 1/1 drm/i915/bdw: Enable execlists by default where supported
In reply to Thomas DanielExeclist support in the i915 driver is now considered good enough for the feature to be enabled by default on Gen8 and later and routinely tested. Adjusted i915 parameters structure initialization to reflect this and updated the comment in intel_sanitize_enable_execlists().
v2: Update the MODULE_PARM_DESC too.
Issue: VIZ-2020
--- drivers/gpu/drm/i915/i915_params.c | 4 ++-- drivers/gpu/drm/i915/intel_lrc.c | 3 +-- 2 files changed, 3 insertions(+), 4 deletions(-)
drivers/gpu/drm/i915/i915_params.c +2 -2
@@ -35,7 +35,7 @@ struct i915_params i915 __read_mostly = { .vbt_sdvo_panel_type = -1, .enable_rc6 = -1, .enable_fbc = -1, - .enable_execlists = 0, + .enable_execlists = -1, .enable_hangcheck = true, .enable_ppgtt = -1, .enable_psr = 0,
@@ -122,7 +122,7 @@ MODULE_PARM_DESC(enable_ppgtt,module_param_named (enable_execlists, i915.enable_execlists, int,0400 );MODULE_PARM_DESC (enable_execlists,"Override execlists usage. " -"(-1=auto, 0=disabled [default], 1=enabled)" ); +"(-1=auto [default], 0=disabled, 1=enabled)" );module_param_named (enable_psr, i915.enable_psr, int,0600 );MODULE_PARM_DESC (enable_psr,"Enable PSR (default: false)" );
drivers/gpu/drm/i915/intel_lrc.c +1 -2
@@ -212,8 +212,7 @@ static int intel_lr_context_pin(struct intel_engine_cs *ring,* @enable_execlists: value of i915.enable_execlists module parameter. * * Only certain platforms support Execlists (the prerequisites being -* support for Logical Ring Contexts and Aliasing PPGTT or better), -* and only when enabled via module parameter. +* support for Logical Ring Contexts and Aliasing PPGTT or better). * * Return: 1 if Execlists is supported and has to be enabled. */
Signature · 6 lines
1.7.9.5 _______________________________________________ Intel-gfx mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/intel-gfx
-------------------------------------Summary-------------------------------------
Platform Delta drm-intel-nightly Series Applied
PNV 364/364 364/364
ILK +1 364/366 365/366
SNB 448/450 448/450 IVB 497/498 497/498 BYT 289/289 289/289
HSW -1 563/564 562/564
BDW 417/417 417/417
-------------------------------------Detailed-------------------------------------
Platform Test drm-intel-nightly Series Applied
ILK igt_kms_flip_wf_vblank-ts-check DMESG_WARN(7, M26)PASS(25, M26M37) PASS(1, M37)
*HSW igt_pm_rpm_dpms-mode-unset-non-lpsp PASS(3, M40) DMESG_WARN(1, M40)
Note: You need to pay more attention to line start with '*'
_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Daniel Vetter
AppliedQuoted 6 lines · Thomas Daniel
Execlist support in the i915 driver is now considered good enough for the feature to be enabled by default on Gen8 and later and routinely tested. Adjusted i915 parameters structure initialization to reflect this and updated the comment in
intel_sanitize_enable_execlists().v2: Update the
MODULE_PARM_DESCtoo.
MO is to mention the reviewer for each change and add them to the cc:
list. Not too important for something simple like this, but a good habit.
Quoted 3 lines
Issue: VIZ-2020
Signed-off-by Thomas Daniel <[email protected]>
Queued for -next, thanks for the patch.
-Daniel
Quoted 48 lines
--- drivers/gpu/drm/i915/i915_params.c | 4 ++-- drivers/gpu/drm/i915/intel_lrc.c | 3 +-- 2 files changed, 3 insertions(+), 4 deletions(-)drivers/gpu/drm/i915/i915_params.c +2
-2@@ -35,7 +35,7 @@ struct i915_params i915 __read_mostly = { .vbt_sdvo_panel_type = -1, .enable_rc6 = -1, .enable_fbc = -1, - .enable_execlists = 0, + .enable_execlists = -1, .enable_hangcheck = true, .enable_ppgtt = -1, .enable_psr = 0,@@ -122,7 +122,7 @@ MODULE_PARM_DESC(enable_ppgtt,module_param_named (enable_execlists, i915.enable_execlists, int,0400 );MODULE_PARM_DESC (enable_execlists,"Override execlists usage. " -"(-1=auto, 0=disabled [default], 1=enabled)" ); +"(-1=auto [default], 0=disabled, 1=enabled)" );module_param_named (enable_psr, i915.enable_psr, int,0600 );MODULE_PARM_DESC (enable_psr,"Enable PSR (default: false)" );drivers/gpu/drm/i915/intel_lrc.c +1
-2@@ -212,8 +212,7 @@ static int intel_lr_context_pin(struct intel_engine_cs *ring,* @enable_execlists: value of i915.enable_execlists module parameter. * * Only certain platforms support Execlists (the prerequisites being -* support for Logical Ring Contexts and Aliasing PPGTT or better), -* and only when enabled via module parameter. +* support for Logical Ring Contexts and Aliasing PPGTT or better). * * Return: 1 if Execlists is supported and has to be enabled. */ Signature · 6 lines
1.7.9.5 _______________________________________________ Intel-gfx mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Signature · 7 lines
Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch _______________________________________________ Intel-gfx mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 4 lines · Thomas Daniel
Execlist support in the i915 driver is now considered good enough for the feature to be enabled by default on Gen8 and later and routinely tested. Adjusted i915 parameters structure initialization to reflect this and updated the comment in
intel_sanitize_enable_execlists().
Oh and I added a note that we still have a bit of work to do before the 3.20 cutoff. But enabling earlier is beneficial for testing and the 3.20 cycle just started for drm/i915 so here we go.
-Daniel
Signature · 7 lines
Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch _______________________________________________ Intel-gfx mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/intel-gfx