Skip to contentSkip to conversation

Demos/Android.mk: dont build intel_sprite_on

PATCH Superseded [email protected] 3 participants 5 messages Dec 12, 2014 – Dec 15, 2014

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Demos/Android.mk: dont build intel_sprite_on

From: Tim Gore <[email protected]>

intel_sprite_on wont build on Android, due to use
of a particular API that has changed in Gmin

---
 demos/Android.mk | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)
demos/Android.mk +4 -2
index 6227e06..be7f3c2 100644
@@ -4,11 +4,13 @@ LOCAL_PATH := $(call my-dir)
 
 include $(CLEAR_VARS)
 
-LOCAL_SRC_FILES := intel_sprite_on.c
+# This demo wont build on android (from Gmin on). 
+#LOCAL_SRC_FILES := intel_sprite_on.c
+
 
 LOCAL_CFLAGS += -DHAVE_TERMIOS_H
 LOCAL_CFLAGS += -DANDROID -UNDEBUG
-LOCAL_CFLAGS += -std=c99
+LOCAL_CFLAGS += -std=gnu99
 # Excessive complaining for established cases. Rely on the Linux version warnings.
 LOCAL_CFLAGS += -Wno-sign-compare
 
Signature · 6 lines
2.1.3

_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
#1 lore raw
Quoted 17 lines · On 12 December 2014 at 10:18, <[email protected]> wrote:

From: Tim Gore <[email protected]>

intel_sprite_on wont build on Android, due to use
of a particular API that has changed in Gmin

---
 demos/Android.mk | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)
demos/Android.mk +0 -0
index 6227e06..be7f3c2 100644
@@ -4,11 +4,13 @@ LOCAL_PATH := $(call my-dir)
 
 include $(CLEAR_VARS)

demos/Android.mk LOCAL_PATH := $(call my-dir) · line 13

Quoted 10 lines
demos/Android.mk +4 -2
 
-LOCAL_SRC_FILES := intel_sprite_on.c
+# This demo wont build on android (from Gmin on).
+#LOCAL_SRC_FILES := intel_sprite_on.c
+
 
 LOCAL_CFLAGS += -DHAVE_TERMIOS_H
 LOCAL_CFLAGS += -DANDROID -UNDEBUG
-LOCAL_CFLAGS += -std=c99
+LOCAL_CFLAGS += -std=gnu99

I think this change should have been in your previous patch ("Android.mk: replace std=c99 with std=gnu99")?

Quoted 6 lines
demos/Android.mk +0 -1
 # Excessive complaining for established cases. Rely on the Linux version warnings.
 LOCAL_CFLAGS += -Wno-sign-compare
 
--

2.1.3

_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

#2 lore raw
Quoted 24 lines · Thomas Wood
Quoted 23 lines · On 12 December 2014 at 10:18, <[email protected]> wrote:

From: Tim Gore <[email protected]>

intel_sprite_on wont build on Android, due to use
of a particular API that has changed in Gmin

---
 demos/Android.mk | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)
demos/Android.mk +3 -1
index 6227e06..be7f3c2 100644
@@ -4,11 +4,13 @@ LOCAL_PATH := $(call my-dir)
 
 include $(CLEAR_VARS)
 
-LOCAL_SRC_FILES := intel_sprite_on.c
+# This demo wont build on android (from Gmin on).
+#LOCAL_SRC_FILES := intel_sprite_on.c
+
 
Quoted 7 lines

demos/Android.mk LOCAL_PATH := $(call my-dir) · line 13

Quoted 4 lines
demos/Android.mk +1 -1
 LOCAL_CFLAGS += -DHAVE_TERMIOS_H
 LOCAL_CFLAGS += -DANDROID -UNDEBUG
-LOCAL_CFLAGS += -std=c99
+LOCAL_CFLAGS += -std=gnu99

I think this change should have been in your previous patch ("Android.mk: replace std=c99 with std=gnu99")?

btw intel_sprite_on has been contributed by your team (Armin Reese), so not sure why you want to disable it. Have you checked with display folks whether they don't need it?
-Daniel

Quoted 12 lines
Quoted 8 lines
demos/Android.mk +0 -1
 # Excessive complaining for established cases. Rely on the Linux version warnings.
 LOCAL_CFLAGS += -Wno-sign-compare
 
--

2.1.3

_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

Signature · 7 lines
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
author
#3 lore raw
Quoted 44 lines

-----Original Message-----
From: Daniel Vetter [mailto:[email protected]] On Behalf Of Daniel Vetter
Sent: Monday, December 15, 2014 2:41 PM
To: Wood, Thomas
Cc: Gore, Tim; Intel Graphics Development
Subject: Re: [Intel-gfx] [PATCH i-g-t] Demos/Android.mk: dont build intel_sprite_on

Quoted 24 lines · Thomas Wood
Quoted 23 lines · On 12 December 2014 at 10:18, <[email protected]> wrote:

From: Tim Gore <[email protected]>

intel_sprite_on wont build on Android, due to use of a particular API that has changed in Gmin

---
 demos/Android.mk | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)
demos/Android.mk index renamed from demos/Android.mk +0 -0

6227e06..be7f3c2 100644

demos/Android.mk +3 -1
@@ -4,11 +4,13 @@ LOCAL_PATH := $(call my-dir)
 
 include $(CLEAR_VARS)
 
-LOCAL_SRC_FILES := intel_sprite_on.c
+# This demo wont build on android (from Gmin on).
+#LOCAL_SRC_FILES := intel_sprite_on.c
+
 
Quoted 7 lines

demos/Android.mk LOCAL_PATH := $(call my-dir) · line 13

Quoted 4 lines
demos/Android.mk +1 -1
 LOCAL_CFLAGS += -DHAVE_TERMIOS_H
 LOCAL_CFLAGS += -DANDROID -UNDEBUG
-LOCAL_CFLAGS += -std=c99
+LOCAL_CFLAGS += -std=gnu99

I think this change should have been in your previous patch ("Android.mk: replace std=c99 with std=gnu99")?

Quoted 5 lines

btw intel_sprite_on has been contributed by your team (Armin Reese), so not sure why you want to disable it. Have you checked with display folks whether they don't need it?
-Daniel

Unfortunately this test wont build, out of the box, for Android. I can patch This locally but I don't think the patch is suitable for upstream.

Tim

Quoted 14 lines
Quoted 3 lines

demos/Android.mk LOCAL_PATH := $(call my-dir) · line 14

Quoted 3 lines
demos/Android.mk +0 -0
 # Excessive complaining for established cases. Rely on the Linux version

warnings.

Quoted 9 lines
Quoted 5 lines
demos/Android.mk +0 -1
 LOCAL_CFLAGS += -Wno-sign-compare
 
--

2.1.3

_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

Quoted 4 lines

--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch

_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

#4 lore raw
Quoted 44 lines · Tim
Quoted 44 lines

-----Original Message-----
From: Daniel Vetter [mailto:[email protected]] On Behalf Of Daniel Vetter
Sent: Monday, December 15, 2014 2:41 PM
To: Wood, Thomas
Cc: Gore, Tim; Intel Graphics Development
Subject: Re: [Intel-gfx] [PATCH i-g-t] Demos/Android.mk: dont build intel_sprite_on

Quoted 31 lines · Thomas Wood
Quoted 17 lines · On 12 December 2014 at 10:18, <[email protected]> wrote:

From: Tim Gore <[email protected]>

intel_sprite_on wont build on Android, due to use of a particular API that has changed in Gmin

---
 demos/Android.mk | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)
demos/Android.mk index renamed from demos/Android.mk +0 -0

6227e06..be7f3c2 100644

demos/Android.mk +0 -0
@@ -4,11 +4,13 @@ LOCAL_PATH := $(call my-dir)
 
 include $(CLEAR_VARS)

demos/Android.mk LOCAL_PATH := $(call my-dir) · line 13

Quoted 10 lines
demos/Android.mk +4 -2
 
-LOCAL_SRC_FILES := intel_sprite_on.c
+# This demo wont build on android (from Gmin on).
+#LOCAL_SRC_FILES := intel_sprite_on.c
+
 
 LOCAL_CFLAGS += -DHAVE_TERMIOS_H
 LOCAL_CFLAGS += -DANDROID -UNDEBUG
-LOCAL_CFLAGS += -std=c99
+LOCAL_CFLAGS += -std=gnu99

I think this change should have been in your previous patch ("Android.mk: replace std=c99 with std=gnu99")?

Quoted 8 lines
Quoted 5 lines

btw intel_sprite_on has been contributed by your team (Armin Reese), so not sure why you want to disable it. Have you checked with display folks whether they don't need it?
-Daniel

Unfortunately this test wont build, out of the box, for Android. I can patch This locally but I don't think the patch is suitable for upstream.

I'm still confused ... why does it not build on Android? I've thought we have this now all worked out wrt igt build issues. Imo better to address whatever's upsetting your builder than to just disable stuff. -Daniel

Signature · 7 lines
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx