Skip to contentSkip to conversation

package/gdb: fix shared-only build

PATCH Superseded Romain Naour 2 participants 2 messages Dec 16, 2014 – Dec 17, 2014

v2 of 4 Superseded Latest is v4 →

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 package/gdb: fix shared-only build

The shared build only of gdb is actually not supported.

When --disable-static is given to the gdb's main configure script, it also disable the static build of bundled libraries like bfd, readline and opcodes, which must be build statically.

Forece static build of bundled libraries by adding --enable-static in GDB_CONF_OPTS.

Fixes:
http://autobuild.buildroot.net/results/219/21979e730dca1fce5bdda9a4c7fad4485e788866/
http://autobuild.buildroot.net/results/c10/c1096d0bd22de5c6feba848f743601ad0416a944/
http://autobuild.buildroot.net/results/d8a/d8a5bcc7fa374fb0c916a9d0f33ef283109cb404/
http://autobuild.buildroot.net/results/22a/22a86d0f1df0fc4698c0f734f3d659e6317404a4/
http://autobuild.buildroot.net/results/404/404e61e5c30040ee5756f4b5839149dca38660d4/

And many more.

---
 package/gdb/gdb.mk | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
package/gdb/gdb.mk +2 -1
index dbec760..7fbf2f8 100644
@@ -83,7 +83,8 @@ GDB_CONF_OPTS = \
 	$(if $(BR2_PACKAGE_GDB_SERVER),--enable-gdbserver) \
 	--with-curses \
 	--without-included-gettext \
-	--disable-werror
+	--disable-werror \
+	--enable-static
 
 ifeq ($(BR2_PACKAGE_GDB_TUI),y)
 	GDB_CONF_OPTS += --enable-tui
Signature · 1 line
1.9.3
#1 lore raw

PATCH v2 1/1 package/gdb: fix shared-only build

Dear Romain Naour,

package/gdb/gdb.mk GDB_CONF_OPTS = \ · line 87

Quoted 11 lines · Romain Naour
package/gdb/gdb.mk +2 -1
index dbec760..7fbf2f8 100644
@@ -83,7 +83,8 @@ GDB_CONF_OPTS = \
 	$(if $(BR2_PACKAGE_GDB_SERVER),--enable-gdbserver) \
 	--with-curses \
 	--without-included-gettext \
-	--disable-werror
+	--disable-werror \
+	--enable-static

We probably want a comment above GDB_CONF_OPTS to explain why we're adding --enable-static.

Thanks,

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com