Skip to contentSkip to conversation

Staging: lustre: lproc_osc.c: used seq_puts() and seq_putc() instead of seq_printf()

PATCH In review Hariharan 2 participants 2 messages Dec 17, 2014 Staging

lore
Share & tools
lore

Hariharan

author
#0 lore raw

PATCH 2/2 Staging: lustre: lproc_osc.c: used seq_puts() and seq_putc() instead of seq_printf()

Quoted 1 line

From 55d1ae4a440126e5befa9de4698a7aac57319885 Mon Sep 17 00:00:00 2001

From: Hariharan Rangasamy <[email protected]>
Date: Thu, 18 Dec 2014 00:04:24 +0530
Subject: [PATCH 2/2] Staging: lustre: lproc_osc.c: used seq_puts() and
seq_putc() instead of seq_printf()

used seq_puts() and seq_putc() instead of seq_printf().

---
 drivers/staging/lustre/lustre/osc/lproc_osc.c | 20 ++++++++++----------
 1 file changed, 10 insertions(+), 10 deletions(-)
(quoted diff) +0 -0

b/drivers/staging/lustre/lustre/osc/lproc_osc.c
index f578b51..7cd9638 100644

drivers/staging/lustre/lustre/osc/lproc_osc.c +0 -0
@@ -358,7 +358,7 @@ static int osc_checksum_type_seq_show(struct

seq_file *m, void *v)
else
seq_printf(m, "%s ", cksum_name[i]);
}
- seq_printf(m, "\n");
+ seq_putc(m, '\n');
return 0;
}

@@ -590,9 +590,9 @@ static int osc_rpc_stats_seq_show(struct seq_file *seq, void *v)
seq_printf(seq, "pending read pages: %d\n",
atomic_read(&cli->cl_pending_r_pages));

- seq_printf(seq, "\n\t\t\tread\t\t\twrite\n");
- seq_printf(seq, "pages per rpc rpcs %% cum %% |");
- seq_printf(seq, " rpcs %% cum %%\n");
+ seq_puts(seq, "\n\t\t\tread\t\t\twrite\n");
+ seq_puts(seq, "pages per rpc rpcs % cum % |");
+ seq_puts(seq, " rpcs % cum %\n");

read_tot = lprocfs_oh_sum(&cli->cl_read_page_hist); write_tot = lprocfs_oh_sum(&cli->cl_write_page_hist);
@@ -613,9 +613,9 @@ static int osc_rpc_stats_seq_show(struct seq_file *seq, void *v)
break;
}

- seq_printf(seq, "\n\t\t\tread\t\t\twrite\n");
- seq_printf(seq, "rpcs in flight rpcs %% cum %% |");
- seq_printf(seq, " rpcs %% cum %%\n");
+ seq_puts(seq, "\n\t\t\tread\t\t\twrite\n");
+ seq_puts(seq, "rpcs in flight rpcs % cum % |");
+ seq_puts(seq, " rpcs % cum %\n");

read_tot = lprocfs_oh_sum(&cli->cl_read_rpc_hist); write_tot = lprocfs_oh_sum(&cli->cl_write_rpc_hist);
@@ -636,9 +636,9 @@ static int osc_rpc_stats_seq_show(struct seq_file *seq, void *v)
break;
}

- seq_printf(seq, "\n\t\t\tread\t\t\twrite\n");
- seq_printf(seq, "offset rpcs %% cum %% |");
- seq_printf(seq, " rpcs %% cum %%\n");
+ seq_puts(seq, "\n\t\t\tread\t\t\twrite\n");
+ seq_puts(seq, "offset rpcs % cum % |");
+ seq_puts(seq, " rpcs % cum %\n");

read_tot = lprocfs_oh_sum(&cli->cl_read_offset_hist); write_tot = lprocfs_oh_sum(&cli->cl_write_offset_hist);

Signature · 1 line
1.9.1
#1 lore raw
Quoted 6 lines · Hariharan
Quoted 1 line

From 55d1ae4a440126e5befa9de4698a7aac57319885 Mon Sep 17 00:00:00 2001

From: Hariharan Rangasamy <[email protected]>
Date: Thu, 18 Dec 2014 00:04:24 +0530
Subject: [PATCH 2/2] Staging: lustre: lproc_osc.c: used seq_puts() and
seq_putc() instead of seq_printf()

Don't include this stuff in the patch, it messes up the git log. Read the first paragraph of Documentation/email-clients.txt for more information.

regards,
dan carpenter