Skip to contentSkip to conversation

Staging: wlan-ng: hfa384x_usb: fixed an 'else' statement coding style issue

PATCH Superseded Eduardo Barretto 2 participants 3 messages Dec 18, 2014 Staging

v2 of 4 Superseded Latest is v4 →

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 Staging: wlan-ng: hfa384x_usb: fixed an 'else' statement coding style issue

Fixed a coding style issue.

---
 drivers/staging/wlan-ng/hfa384x_usb.c | 11 +++++------
 1 file changed, 5 insertions(+), 6 deletions(-)
drivers/staging/wlan-ng/hfa384x_usb.c +5 -6
index 55d2f56..de33a07 100644
@@ -4123,12 +4123,11 @@ static int hfa384x_isgood_pdrcode(u16 pdrcode)
 			pr_debug("Encountered unknown PDR#=0x%04x, assuming it's ok.\n",
 				 pdrcode);
 			return 1;
-		} else {
-			/* bad code */
-			pr_debug("Encountered unknown PDR#=0x%04x, (>=0x1000), assuming it's bad.\n",
-				 pdrcode);
-			return 0;
 		}
+		break;
 	}
-	return 0;		/* avoid compiler warnings */
+	/* bad code */
+	pr_debug("Encountered unknown PDR#=0x%04x, (>=0x1000), assuming it's bad.\n",
+		 pdrcode);
+	return 0;
 }

--
2.1.3

maintainer
#1 lore raw
Quoted 1 line · Eduardo Barretto

Fixed a coding style issue.

What coding style issue?

Be specific, you have lots of room here.

#2 lore raw

Thank you for your feedback Greg!

I wonder if I should send a patch v3 or patch v2.1 with a better description.

Is there any standard that I should follow when sending another version of a patch?

Thanks,
Best regards,
Eduardo dos Santos Barretto

Quoted 7 lines · Greg KH
Quoted 1 line · Eduardo Barretto

Fixed a coding style issue.

What coding style issue?

Be specific, you have lots of room here.