Skip to contentSkip to conversation

uapi/linux/target_core_user.h: fix headers_install.sh badness

PATCH Applied Kyle McMartin 3 participants 3 messages Dec 18, 2014 – Dec 19, 2014 SCSI target core user driver

lore
Share & tools
lore

Kyle McMartin

author
#0 lore raw

PATCH 1/1 uapi/linux/target_core_user.h: fix headers_install.sh badness

scripts/headers_install.sh will transform __packed to __attribute__((packed)), so the #ifndef is not necessary. (and, in fact, it's problematic, because we'll end up with the header
containing:
#ifndef __attribute__((packed))
#define __attribu...
and so forth.)

Cc [email protected] # 3.18
Signed-off-by Kyle McMartin <[email protected]>

---
cc-ing stable@ so this headers fix gets picked up by distros.

include/uapi/linux/target_core_user.h +0 -4
@@ -6,10 +6,6 @@
 #include <linux/types.h>
 #include <linux/uio.h>
 
-#ifndef __packed
-#define __packed                        __attribute__((packed))
-#endif
-
 #define TCMU_VERSION "1.0"
 
 /*
Acked-by on v1 1/1
#1 lore raw
Quoted 8 lines · Kyle McMartin

scripts/headers_install.sh will transform __packed to __attribute__((packed)), so the #ifndef is not necessary. (and, in fact, it's problematic, because we'll end up with the header
containing:
#ifndef __attribute__((packed))
#define __attribu...
and so forth.)

Quoted 5 lines
Cc [email protected] # 3.18
Signed-off-by Kyle McMartin <[email protected]>

---
cc-ing stable@ so this headers fix gets picked up by distros.

Acked-by Andy Grover <[email protected]>
Applied
#2 lore raw
In reply to Kyle McMartin

Hi Kyle,

Quoted 17 lines · Kyle McMartin

scripts/headers_install.sh will transform __packed to __attribute__((packed)), so the #ifndef is not necessary. (and, in fact, it's problematic, because we'll end up with the header
containing:
#ifndef __attribute__((packed))
#define __attribu...
and so forth.)

Cc [email protected] # 3.18
Signed-off-by Kyle McMartin <[email protected]>

---
cc-ing stable@ so this headers fix gets picked up by distros.

include/uapi/linux/target_core_user.h line 11

Quoted 10 lines
include/uapi/linux/target_core_user.h +0 -4
@@ -6,10 +6,6 @@
 #include <linux/types.h>
 #include <linux/uio.h>
 
-#ifndef __packed
-#define __packed                        __attribute__((packed))
-#endif
-
 #define TCMU_VERSION "1.0"
 
 /*

Applied to target-pending/for-next.

Thanks!

--nab