ocfs2: remove bogus check in dlm_process_recovery_data
PATCH 1/1 ocfs2: remove bogus check in dlm_process_recovery_data
In dlm_process_recovery_data, only when dlm_new_lock failed the ret will be set to -ENOMEM. And in this case, newlock is definitely NULL. So test newlock is meaningless, remove it.
Signed-off-by Joseph Qi <[email protected]>
Reviewed-by Alex Chen <[email protected]>
--- fs/ocfs2/dlm/dlmrecovery.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-)
fs/ocfs2/dlm/dlmrecovery.c +1 -4
@@ -2015,11 +2015,8 @@ leave:dlm_lockres_drop_inflight_ref (dlm, res);spin_unlock (&res->spinlock); -if (ret <0 ) { +if (ret <0 )mlog_errno (ret); -if (newlock) -dlm_lock_put (newlock); - }return ret; }
Signature · 1 line
1.8.4.3
PATCH 1/1 ocfs2: remove bogus check in dlm_process_recovery_data
Quoted 6 lines · Joseph Qi
In
dlm_process_recovery_data, only whendlm_new_lockfailed the ret will be set to-ENOMEM. And in this case, newlock is definitely NULL. So test newlock is meaningless, remove it.Signed-off-by Joseph Qi <[email protected]>Reviewed-by Alex Chen <[email protected]>
Reviewed-by Mark Fasheh <[email protected]>
--Mark
--
Mark Fasheh