Skip to contentSkip to conversation

package/weston: do not select rpi-userland

PATCH New Yann E. MORIN 2 participants 2 messages Dec 20, 2014

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 package/weston: do not select rpi-userland

rpi-userland is a provider for some virtual packages, so we can not select it, as instructed in the manual:

http://nightly.buildroot.org/#_infrastructure_for_virtual_packages

---8<---
If your package really requires a specific provider, then you?ll have to make your package depends on this provider; you can not select a provider.
---8<---

Instead, just depend on it. Remove the comment as well.

Cc Thomas Petazzoni <[email protected]>

---
Notes: I choose to remove the comment altogether, because we have no official solution to tell the user about dependencies to other packages.

---
 package/weston/Config.in | 11 ++---------
 1 file changed, 2 insertions(+), 9 deletions(-)
package/weston/Config.in +2 -9
index 5fff5bd..49130b4 100644
@@ -40,17 +40,10 @@ config BR2_PACKAGE_WESTON_HAS_COMPOSITOR
 config BR2_PACKAGE_WESTON_FBDEV
 	bool "fbdev compositor"
 
-comment "RPi compositor needs a toolchain w/ C++, largefile, threads"
-	depends on BR2_arm
-	depends on !BR2_INSTALL_LIBSTDCPP || !BR2_LARGEFILE || !BR2_TOOLCHAIN_HAS_THREADS
-
+# rpi-userland is an EGL/GLES provider, so we can't select it
 config BR2_PACKAGE_WESTON_RPI
 	bool "RPi compositor"
-	depends on BR2_arm                      # rpi-userland
-	depends on BR2_INSTALL_LIBSTDCPP        # rpi-userland
-	depends on BR2_LARGEFILE                # rpi-userland
-	depends on BR2_TOOLCHAIN_HAS_THREADS    # rpi-userland
-	select BR2_PACKAGE_RPI_USERLAND
+	depends on BR2_PACKAGE_RPI_USERLAND
 	select BR2_PACKAGE_WESTON_HAS_COMPOSITOR
 
 endif
Signature · 1 line
1.9.1
#1 lore raw

PATCH 1/1 package/weston: do not select rpi-userland

Dear Yann E. MORIN,

Quoted 11 lines · Yann E. MORIN

rpi-userland is a provider for some virtual packages, so we can not select it, as instructed in the manual:

http://nightly.buildroot.org/#_infrastructure_for_virtual_packages

---8<---
If your package really requires a specific provider, then you?ll have to make your package depends on this provider; you can not select a provider.
---8<---

Quoted 4 lines

Instead, just depend on it. Remove the comment as well.

Cc Thomas Petazzoni <[email protected]>

Applied, thanks.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com