Skip to contentSkip to conversation

samba: Swap libnss_win*.so* files and symlinks

PATCH New Benoît Thébaudeau 2 participants 2 messages Dec 14, 2014 – Dec 21, 2014

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 samba: Swap libnss_win*.so* files and symlinks

The libnss_wins and libnss_winbind libraries were installed in this way:
/lib/libnss_<service>.so
/lib/libnss_<service>.so.<major> -> /lib/libnss_<service>.so

This had been done like this in order to get something similar to the other NSS libraries, which are usually installed in this way:
/lib/libnss_<service>-<version>.so /lib/libnss_<service>.so.<major> -> /lib/libnss_<service>-<version>.so

However, besides these files, these other NSS libraries usually come installed with:
/usr/lib/libnss_<service>.so -> /lib/libnss_<service>.so.<major>

This means that the NSS libraries follow the usual library installation practice, i.e. that the non-versioned .so is a symlink to the versioned .so, so that switching versions is easy. In the case of the NSS libraries, the versioned .so is just also a symlink to a .so with a more accurate version.

Hence, follow the same rules for libnss_win*.so*, and install these libraries the other way around:
/lib/libnss_<service>.so -> /lib/libnss_<service>.so.<major> /lib/libnss_<service>.so.<major>

This is also how these libraries are installed by a major OS like Ubuntu 14.10:
/lib/x86_64-linux-gnu/libnss_winbind.so -> libnss_winbind.so.2 /lib/x86_64-linux-gnu/libnss_winbind.so.2 /lib/x86_64-linux-gnu/libnss_wins.so -> libnss_wins.so.2 /lib/x86_64-linux-gnu/libnss_wins.so.2

---
 package/samba/samba.mk | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
package/samba/samba.mk +4 -4
index 0e4db95..d25e94e 100644
@@ -137,16 +137,16 @@ SAMBA_POST_INSTALL_TARGET_HOOKS += SAMBA_REMOVE_UNNEEDED_BINARIES
 
 ifeq ($(BR2_PACKAGE_SAMBA_LIBNSS_WINS),y)
 define SAMBA_INSTALL_LIBNSS_WINS
-	$(INSTALL) -m 0755 -D $(@D)/nsswitch/libnss_wins.so $(TARGET_DIR)/lib/libnss_wins.so
-	ln -snf libnss_wins.so $(TARGET_DIR)/lib/libnss_wins.so.2
+	$(INSTALL) -m 0755 -D $(@D)/nsswitch/libnss_wins.so $(TARGET_DIR)/lib/libnss_wins.so.2
+	ln -snf libnss_wins.so.2 $(TARGET_DIR)/lib/libnss_wins.so
 endef
 SAMBA_POST_INSTALL_TARGET_HOOKS += SAMBA_INSTALL_LIBNSS_WINS
 endif
 
 ifeq ($(BR2_PACKAGE_SAMBA_LIBNSS_WINBIND),y)
 define SAMBA_INSTALL_LIBNSS_WINBIND
-	$(INSTALL) -m 0755 -D $(@D)/nsswitch/libnss_winbind.so $(TARGET_DIR)/lib/libnss_winbind.so
-	ln -snf libnss_winbind.so $(TARGET_DIR)/lib/libnss_winbind.so.2
+	$(INSTALL) -m 0755 -D $(@D)/nsswitch/libnss_winbind.so $(TARGET_DIR)/lib/libnss_winbind.so.2
+	ln -snf libnss_winbind.so.2 $(TARGET_DIR)/lib/libnss_winbind.so
 endef
 SAMBA_POST_INSTALL_TARGET_HOOKS += SAMBA_INSTALL_LIBNSS_WINBIND
 endif
Signature · 1 line
2.1.0
#1 lore raw

PATCH 1/1 samba: Swap libnss_win*.so* files and symlinks

Dear Beno?t Th?baudeau,

Quoted 24 lines · Beno?t Th?baudeau

The libnss_wins and libnss_winbind libraries were installed in this way:
/lib/libnss_<service>.so
/lib/libnss_<service>.so.<major> -> /lib/libnss_<service>.so

This had been done like this in order to get something similar to the other NSS libraries, which are usually installed in this way:
/lib/libnss_<service>-<version>.so /lib/libnss_<service>.so.<major> -> /lib/libnss_<service>-<version>.so

However, besides these files, these other NSS libraries usually come installed with:
/usr/lib/libnss_<service>.so -> /lib/libnss_<service>.so.<major>

This means that the NSS libraries follow the usual library installation practice, i.e. that the non-versioned .so is a symlink to the versioned .so, so that switching versions is easy. In the case of the NSS libraries, the versioned .so is just also a symlink to a .so with a more accurate version.

Hence, follow the same rules for libnss_win*.so*, and install these libraries the other way around:
/lib/libnss_<service>.so -> /lib/libnss_<service>.so.<major> /lib/libnss_<service>.so.<major>

Quoted 8 lines

This is also how these libraries are installed by a major OS like Ubuntu 14.10:
/lib/x86_64-linux-gnu/libnss_winbind.so -> libnss_winbind.so.2 /lib/x86_64-linux-gnu/libnss_winbind.so.2 /lib/x86_64-linux-gnu/libnss_wins.so -> libnss_wins.so.2 /lib/x86_64-linux-gnu/libnss_wins.so.2

Applied, thanks.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com