Skip to contentSkip to conversation

staging: vt6656: whitespace checkpatch warning fix.

PATCH In review Krzysztof Adamski 2 participants 3 messages Dec 22, 2014 – Jan 13, 2015 Staging

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 staging: vt6656: whitespace checkpatch warning fix.

This fixes following checkpatch.pl error:
ERROR: space prohibited before that ',' (ctx:WxW)

---
drivers/staging/vt6656/rxtx.c | 2 +-

1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/vt6656/rxtx.c +0 -0
index ea5140a..5a18e26 100644
@@ -55,7 +55,7 @@ static const u16 vnt_fb_opt0[2][5] = {
 
static const u16 vnt_fb_opt1[2][5] = {
	{RATE_12M, RATE_18M, RATE_24M, RATE_24M, RATE_36M}, /* fallback_rate0 */

- {RATE_6M , RATE_6M, RATE_12M, RATE_12M, RATE_18M}, /* fallback_rate1 */
+ {RATE_6M, RATE_6M, RATE_12M, RATE_12M, RATE_18M}, /* fallback_rate1 */
};

#define RTSDUR_BB 0

Signature · 1 line
1.7.10.4
#1 lore raw
Quoted 23 lines · Krzysztof Adamski

This fixes following checkpatch.pl error:
ERROR: space prohibited before that ',' (ctx:WxW)

---
drivers/staging/vt6656/rxtx.c | 2 +-

1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/vt6656/rxtx.c +1 -1
index ea5140a..5a18e26 100644
@@ -55,7 +55,7 @@ static const u16 vnt_fb_opt0[2][5] = {
 
 static const u16 vnt_fb_opt1[2][5] = {
 	{RATE_12M, RATE_18M, RATE_24M, RATE_24M, RATE_36M}, /* fallback_rate0 */
-	{RATE_6M , RATE_6M,  RATE_12M, RATE_12M, RATE_18M}, /* fallback_rate1 */
+	{RATE_6M,  RATE_6M,  RATE_12M, RATE_12M, RATE_18M}, /* fallback_rate1 */
 };
 
 #define RTSDUR_BB       0
Signature · 1 line
1.7.10.4

Again resend?

#2 lore raw
Quoted 21 lines · Greg Kroah-Hartman
Quoted 20 lines · Krzysztof Adamski

This fixes following checkpatch.pl error:
ERROR: space prohibited before that ',' (ctx:WxW)

---
drivers/staging/vt6656/rxtx.c | 2 +-

1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/vt6656/rxtx.c +1 -1
index ea5140a..5a18e26 100644
@@ -55,7 +55,7 @@ static const u16 vnt_fb_opt0[2][5] = {
 
 static const u16 vnt_fb_opt1[2][5] = {
 	{RATE_12M, RATE_18M, RATE_24M, RATE_24M, RATE_36M}, /* fallback_rate0 */
-	{RATE_6M , RATE_6M,  RATE_12M, RATE_12M, RATE_18M}, /* fallback_rate1 */
+	{RATE_6M,  RATE_6M,  RATE_12M, RATE_12M, RATE_18M}, /* fallback_rate1 */
 };
 
Quoted 5 lines
Quoted 3 lines
drivers/staging/vt6656/rxtx.c +0 -1
 #define RTSDUR_BB       0
--

1.7.10.4

Again resend?

Sorry, it was my first attempt at getting some patch to upstream kernel. I was following your advice about being persistent:
http://www.reddit.com/r/linux/comments/2ny1lz/im_greg_kroahhartman_linux_kernel_developer_ama/cmvltqk

Next time I'll wait much longer.