Skip to contentSkip to conversation

staging: lustre: cleanup align switch and case

PATCH In review samuel kihahu 2 participants 4 messages Dec 22, 2014 – Dec 23, 2014 Staging

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 staging: lustre: cleanup align switch and case

From: skihahu <[email protected]>

Align switch and case to be at the same indent.

---
 drivers/staging/lustre/lnet/selftest/module.c | 50 +++++++++++++--------------
 1 file changed, 25 insertions(+), 25 deletions(-)
drivers/staging/lustre/lnet/selftest/module.c +0 -0
index 6dd4309..b5f07fa 100644
@@ -61,31 +61,31 @@ lnet_selftest_fini(void)
	int	i;

	switch (lst_init_step) {

- case LST_INIT_CONSOLE:
- lstcon_console_fini();
- case LST_INIT_FW:
- sfw_shutdown();
- case LST_INIT_RPC:
- srpc_shutdown();
- case LST_INIT_WI_TEST:
- for (i = 0;
- i < cfs_cpt_number(lnet_cpt_table()); i++) {
- if (lst_sched_test[i] == NULL)
- continue;
- cfs_wi_sched_destroy(lst_sched_test[i]);
- }
- LIBCFS_FREE(lst_sched_test,
- sizeof(lst_sched_test[0]) *
- cfs_cpt_number(lnet_cpt_table()));
- lst_sched_test = NULL;
-
- case LST_INIT_WI_SERIAL:
- cfs_wi_sched_destroy(lst_sched_serial);
- lst_sched_serial = NULL;
- case LST_INIT_NONE:
- break;
- default:
- LBUG();
+ case LST_INIT_CONSOLE:
+ lstcon_console_fini();
+ case LST_INIT_FW:
+ sfw_shutdown();
+ case LST_INIT_RPC:
+ srpc_shutdown();
+ case LST_INIT_WI_TEST:
+ for (i = 0;
+ i < cfs_cpt_number(lnet_cpt_table()); i++) {
+ if (lst_sched_test[i] == NULL)
+ continue;
+ cfs_wi_sched_destroy(lst_sched_test[i]);
+ }
+ LIBCFS_FREE(lst_sched_test,
+ sizeof(lst_sched_test[0]) *
+ cfs_cpt_number(lnet_cpt_table()));
+ lst_sched_test = NULL;
+
+ case LST_INIT_WI_SERIAL:
+ cfs_wi_sched_destroy(lst_sched_serial);
+ lst_sched_serial = NULL;
+ case LST_INIT_NONE:
+ break;
+ default:

+		LBUG();
	}
	return;

}

#2 lore raw
Quoted 10 lines · Greg KH
Quoted 5 lines · samuel kihahu

From: skihahu <[email protected]>

Align switch and case to be at the same indent.

The "From:" and "Signed-off-by:" names don't match, which doesn't make much sense, right? Please fix and resend.

I have corrected as requested above.

Quoted 1 line

From 766dd7eefe8992b90dc69cca085e6719019aae82 Mon Sep 17 00:00:00 2001

From: samuel kihahu <[email protected]>
Date: Mon, 22 Dec 2014 18:16:29 +0300
Subject: [PATCH] staging: lustre: cleanup align switch and case

Align switch and case to be at the same indent.

---
 drivers/staging/lustre/lnet/selftest/module.c | 50 +++++++++++++--------------
 1 file changed, 25 insertions(+), 25 deletions(-)
drivers/staging/lustre/lnet/selftest/module.c +0 -0
index 6dd4309..b5f07fa 100644
@@ -61,31 +61,31 @@ lnet_selftest_fini(void)
	int	i;

	switch (lst_init_step) {

- case LST_INIT_CONSOLE:
- lstcon_console_fini();
- case LST_INIT_FW:
- sfw_shutdown();
- case LST_INIT_RPC:
- srpc_shutdown();
- case LST_INIT_WI_TEST:
- for (i = 0;
- i < cfs_cpt_number(lnet_cpt_table()); i++) {
- if (lst_sched_test[i] == NULL)
- continue;
- cfs_wi_sched_destroy(lst_sched_test[i]);
- }
- LIBCFS_FREE(lst_sched_test,
- sizeof(lst_sched_test[0]) *
- cfs_cpt_number(lnet_cpt_table()));
- lst_sched_test = NULL;
-
- case LST_INIT_WI_SERIAL:
- cfs_wi_sched_destroy(lst_sched_serial);
- lst_sched_serial = NULL;
- case LST_INIT_NONE:
- break;
- default:
- LBUG();
+ case LST_INIT_CONSOLE:
+ lstcon_console_fini();
+ case LST_INIT_FW:
+ sfw_shutdown();
+ case LST_INIT_RPC:
+ srpc_shutdown();
+ case LST_INIT_WI_TEST:
+ for (i = 0;
+ i < cfs_cpt_number(lnet_cpt_table()); i++) {
+ if (lst_sched_test[i] == NULL)
+ continue;
+ cfs_wi_sched_destroy(lst_sched_test[i]);
+ }
+ LIBCFS_FREE(lst_sched_test,
+ sizeof(lst_sched_test[0]) *
+ cfs_cpt_number(lnet_cpt_table()));
+ lst_sched_test = NULL;
+
+ case LST_INIT_WI_SERIAL:
+ cfs_wi_sched_destroy(lst_sched_serial);
+ lst_sched_serial = NULL;
+ case LST_INIT_NONE:
+ break;
+ default:

+		LBUG();
	}
	return;

}

maintainer
#3 lore raw
Quoted 19 lines · samuel kihahu
Quoted 10 lines · Greg KH
Quoted 5 lines · samuel kihahu

From: skihahu <[email protected]>

Align switch and case to be at the same indent.

The "From:" and "Signed-off-by:" names don't match, which doesn't make much sense, right? Please fix and resend.

I have corrected as requested above.

Quoted 1 line

From 766dd7eefe8992b90dc69cca085e6719019aae82 Mon Sep 17 00:00:00 2001

From: samuel kihahu <[email protected]>
Date: Mon, 22 Dec 2014 18:16:29 +0300
Subject: [PATCH] staging: lustre: cleanup align switch and case

Quoted 6 lines

Align switch and case to be at the same indent.

---
 drivers/staging/lustre/lnet/selftest/module.c | 50 +++++++++++++--------------
 1 file changed, 25 insertions(+), 25 deletions(-)

But this isn't in a form I can apply, please resend in a format I don't have to hand-edit the email.

greg k-h