Skip to contentSkip to conversation

DT: leds: Add flash LED devices related properties (fwd) (fwd)

PATCH In review Pavel Machek 2 participants 2 messages Dec 22, 2014

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH v3 1/1 DT: leds: Add flash LED devices related properties (fwd) (fwd)

Addition of a LED Flash class extension entails the need for flash LED specific device tree properties. The properties being added are:
max-microamp, flash-max-microamp, flash-timeout-microsec.

---

This will allow me to add device tree support for adp1653 i2c flash LED driver, and allow Jacek Anaszewski to add support for more LED drivers..

Rob Herring requested to change microsec to us.

Yes, microamp vs. us does look inconsistent, but that's what other subsystems do, and what Rob asked.

Documentation/devicetree/bindings/leds/common.txt +16 -0
index 2d88816..e9acbbc 100644
@@ -14,6 +14,15 @@ Optional properties for child nodes:
      "ide-disk" - LED indicates disk activity
      "timer" - LED flashes at a fixed, configurable rate
 
+- max-microamp : maximum intensity in microamperes of the LED
+  	         (torch LED for flash devices)
+- flash-max-microamp : maximum intensity in microamperes of the
+                       flash LED; it is mandatory if the LED should
+		       support the flash mode
+- flash-timeout-us : timeout in microseconds after which the flash
+                     LED is turned off
+
+
 Examples:
 
 system-status {
@@ -21,3 +30,10 @@ system-status {
 	linux,default-trigger = "heartbeat";
 	...
 };
+
+camera-flash {
+	label = "Flash";
+	max-microamp = <50000>;
+	flash-max-microamp = <320000>;
+	flash-timeout-us = <500000>;
+}
Signature · 2 lines
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
#1 lore raw
Quoted 9 lines · Pavel Machek

Addition of a LED Flash class extension entails the need for flash LED specific device tree properties. The properties being added are:
max-microamp, flash-max-microamp, flash-timeout-microsec.

Applied after removing some white spaces, thanks,
-Bryan

Quoted 48 lines

---

This will allow me to add device tree support for adp1653 i2c flash LED driver, and allow Jacek Anaszewski to add support for more LED drivers..

Rob Herring requested to change microsec to us.

Yes, microamp vs. us does look inconsistent, but that's what other subsystems do, and what Rob asked.

Documentation/devicetree/bindings/leds/common.txt +16 -1
index 2d88816..e9acbbc 100644
@@ -14,6 +14,15 @@ Optional properties for child nodes:
      "ide-disk" - LED indicates disk activity
      "timer" - LED flashes at a fixed, configurable rate
 
+- max-microamp : maximum intensity in microamperes of the LED
+                (torch LED for flash devices)
+- flash-max-microamp : maximum intensity in microamperes of the
+                       flash LED; it is mandatory if the LED should
+                      support the flash mode
+- flash-timeout-us : timeout in microseconds after which the flash
+                     LED is turned off
+
+
 Examples:
 
 system-status {
@@ -21,3 +30,10 @@ system-status {
        linux,default-trigger = "heartbeat";
...
 };
+
+camera-flash {
+       label = "Flash";
+       max-microamp = <50000>;
+       flash-max-microamp = <320000>;
+       flash-timeout-us = <500000>;
+}
 
 
--

(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html