acpi: remove pointless checks for NULL pointer
PATCH 1/1 acpi: remove pointless checks for NULL pointer
A trivial fix. No need to check p for NULL. resource pointer is valid therefore p is also valid.
Signed-off-by Eugene Korenevsky <[email protected]>
--- drivers/acpi/pci_link.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)
drivers/acpi/pci_link.c +4 -4
@@ -111,7 +111,7 @@ static acpi_status acpi_pci_link_check_possible(struct acpi_resource *resource,case ACPI_RESOURCE_TYPE_IRQ : {struct acpi_resource_irq *p = &resource->data.irq; -if (!p || !p->interrupt_count) { +if (!p->interrupt_count) {ACPI_DEBUG_PRINT ((ACPI_DB_INFO ,"Blank _PRS IRQ resource\n" ));return AE_OK ;
@@ -137,7 +137,7 @@ static acpi_status acpi_pci_link_check_possible(struct acpi_resource *resource, {struct acpi_resource_extended_irq *p = &resource->data.extended_irq; -if (!p || !p->interrupt_count) { +if (!p->interrupt_count) { printk(KERN_WARNING PREFIX "Blank _PRS EXT IRQ resource\n");return AE_OK ;
@@ -198,7 +198,7 @@ static acpi_status acpi_pci_link_check_current(struct acpi_resource *resource,case ACPI_RESOURCE_TYPE_IRQ : {struct acpi_resource_irq *p = &resource->data.irq; -if (!p || !p->interrupt_count) { +if (!p->interrupt_count) {/* * IRQ descriptors may have no IRQ# bits set, * particularly those those w/ _STA disabled
@@ -214,7 +214,7 @@ static acpi_status acpi_pci_link_check_current(struct acpi_resource *resource, {struct acpi_resource_extended_irq *p = &resource->data.extended_irq; -if (!p || !p->interrupt_count) { +if (!p->interrupt_count) {/* * extended IRQ descriptors must * return at least 1 IRQ
Signature · 1 line
2.0.4
Rafael J. Wysocki
AppliedQuoted 4 lines · Eugene Korenevsky
A trivial fix. No need to check
pfor NULL.resourcepointer is valid thereforepis also valid.Signed-off-by Eugene Korenevsky <[email protected]>
Queued up for 3.20, thanks!
Quoted 45 lines
--- drivers/acpi/pci_link.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)drivers/acpi/pci_link.c +4
-4@@ -111,7 +111,7 @@ static acpi_status acpi_pci_link_check_possible(struct acpi_resource *resource,case ACPI_RESOURCE_TYPE_IRQ : {struct acpi_resource_irq *p = &resource->data.irq; -if (!p || !p->interrupt_count) { +if (!p->interrupt_count) {ACPI_DEBUG_PRINT ((ACPI_DB_INFO ,"Blank _PRS IRQ resource\n" ));return AE_OK ;@@ -137,7 +137,7 @@ static acpi_status acpi_pci_link_check_possible(struct acpi_resource *resource, {struct acpi_resource_extended_irq *p = &resource->data.extended_irq; -if (!p || !p->interrupt_count) { +if (!p->interrupt_count) { printk(KERN_WARNING PREFIX "Blank _PRS EXT IRQ resource\n");return AE_OK ;@@ -198,7 +198,7 @@ static acpi_status acpi_pci_link_check_current(struct acpi_resource *resource,case ACPI_RESOURCE_TYPE_IRQ : {struct acpi_resource_irq *p = &resource->data.irq; -if (!p || !p->interrupt_count) { +if (!p->interrupt_count) {/* * IRQ descriptors may have no IRQ# bits set, * particularly those those w/ _STA disabled @@ -214,7 +214,7 @@ static acpi_status acpi_pci_link_check_current(struct acpi_resource *resource, {struct acpi_resource_extended_irq *p = &resource->data.extended_irq; -if (!p || !p->interrupt_count) { +if (!p->interrupt_count) {/* * extended IRQ descriptors must * return at least 1 IRQ
Signature · 2 lines
I speak only for myself. Rafael J. Wysocki, Intel Open Source Technology Center.