Skip to contentSkip to conversation

staging: comedi: dmm32at: fix style issues

PATCH Superseded David Decotigny 2 participants 2 messages Dec 25, 2014 Staging

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 staging: comedi: dmm32at: fix style issues

Before:
1 ERROR: code indent should use tabs where possible 1 WARNING: please, no spaces at the start of a line

After:
(none)

---
 drivers/staging/comedi/drivers/dmm32at.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/staging/comedi/drivers/dmm32at.c +3 -3
index 6df298a..1615103 100644
@@ -363,9 +363,9 @@ static void dmm32at_setaitimer(struct comedi_device *dev, unsigned int nansec)
 	outb(hi2, dev->iobase + DMM32AT_CLK2);
 
 	/* enable the ai conversion interrupt and the clock to start scans */
-	outb(DMM32AT_INTCLK_ADINT |
-	     DMM32AT_INTCLK_CLKEN | DMM32AT_INTCLK_CLKSEL,
-             dev->iobase + DMM32AT_INTCLK_REG);
+	outb(DMM32AT_INTCLK_ADINT | DMM32AT_INTCLK_CLKEN |
+		 DMM32AT_INTCLK_CLKSEL,
+	     dev->iobase + DMM32AT_INTCLK_REG);
 }
 
 static int dmm32at_ai_cmd(struct comedi_device *dev, struct comedi_subdevice *s)
Signature · 1 line
2.2.0.rc0.207.ga3a616c
#1 lore raw

David,

Quoted 19 lines · David Decotigny

Before:
1 ERROR: code indent should use tabs where possible 1 WARNING: please, no spaces at the start of a line

After:
(none)

---
 drivers/staging/comedi/drivers/dmm32at.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/staging/comedi/drivers/dmm32at.c +0 -0
index 6df298a..1615103 100644
@@ -363,9 +363,9 @@ static void dmm32at_setaitimer(struct comedi_device *dev, unsigned int nansec)
 	outb(hi2, dev->iobase + DMM32AT_CLK2);
 

drivers/staging/comedi/drivers/dmm32at.c static void dmm32at_setaitimer(struct comedi_device *dev, unsigned int nansec) · line 371

Quoted 10 lines
drivers/staging/comedi/drivers/dmm32at.c +3 -3
 	/* enable the ai conversion interrupt and the clock to start scans */
-	outb(DMM32AT_INTCLK_ADINT |
-	     DMM32AT_INTCLK_CLKEN | DMM32AT_INTCLK_CLKSEL,
-             dev->iobase + DMM32AT_INTCLK_REG);
+	outb(DMM32AT_INTCLK_ADINT | DMM32AT_INTCLK_CLKEN |
+		 DMM32AT_INTCLK_CLKSEL,
+	     dev->iobase + DMM32AT_INTCLK_REG);
 }
 
 static int dmm32at_ai_cmd(struct comedi_device *dev, struct comedi_subdevice *s)

Your patch re-formats this section, but I don't think this is needed. Some people like to format their code so it is aligned at the left parenthesis.

The warning is about the line which is indented entirely using spaces and no tabs. The following patch would fix the warning without disrupting the formatting.

drivers/staging/comedi/drivers/dmm32at.c +1 -1
index 6df298a..31919b8 100644
@@ -365,7 +365,7 @@ static void dmm32at_setaitimer(struct comedi_device *dev, unsigned int nansec)
 	/* enable the ai conversion interrupt and the clock to start scans */
 	outb(DMM32AT_INTCLK_ADINT |
 	     DMM32AT_INTCLK_CLKEN | DMM32AT_INTCLK_CLKSEL,
-             dev->iobase + DMM32AT_INTCLK_REG);
+	     dev->iobase + DMM32AT_INTCLK_REG);
 }
 
 static int dmm32at_ai_cmd(struct comedi_device *dev, struct comedi_subdevice *s)
Signature · 1 line
- Jeremiah Mahler