Skip to contentSkip to conversation

misc guile-related fixes (branch yem/fixes)

PATCH New Yann E. MORIN 2 participants 4 messages Dec 24, 2014 – Dec 26, 2014

lore
Share & tools
lore
#0 lore raw

cover misc guile-related fixes (branch yem/fixes)

Hello All!

Here are two patches intended to fix guile builds:
- in bdwgc, detect availability of getcontext
- add proper kconfig dependency to guile

A third patch to guile I kept in limbo until we have a way to reproduce the autobuild failures it is supposed to fix (I was not able to reproduce any of them).

Thanks to Samuel for the initial series. :-)

Regards,
Yann E. MORIN.

The following changes since commit 49b147ccbb807238009fde815ad68e953077bc3a:

linux: fix breakage from d4b2b032a00c9922c9efa144b014dc086a7e48f1 (2014-12-24 15:00:48 +0100)

are available in the git repository at:

git://git.busybox.net/~ymorin/git/buildroot yem/fixes

for you to fetch changes up to efeb5ff2d78fb77cfd65a2e4e3bbb78ec9bef3f0:

bdwgc: add patch automatically detecting for NO_GETCONTEXT need (2014-12-24 20:04:24 +0100)

----------------------------------------------------------------
Samuel Martin (1):
bdwgc: add patch automatically detecting for NO_GETCONTEXT need

Yann E. MORIN (1):
package/guile: needs libtool

 ...ac-add-check-for-NO_GETCONTEXT-definition.patch | 28 ++++++++++++++++++++++
 package/guile/Config.in                            |  1 +
 2 files changed, 29 insertions(+)
 create mode 100644 package/bdwgc/0001-configure.ac-add-check-for-NO_GETCONTEXT-definition.patch
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
#1 lore raw

PATCH 1/2 package/guile: needs libtool

guile build-depends on libtool, but forgot to select it Kconfig.

---
 package/guile/Config.in | 1 +
 1 file changed, 1 insertion(+)
package/guile/Config.in +1 -0
index 8f86e9f..6859caf 100644
@@ -8,6 +8,7 @@ config BR2_PACKAGE_GUILE
 	select BR2_PACKAGE_LIBFFI
 	select BR2_PACKAGE_GMP
 	select BR2_PACKAGE_BDWGC
+	select BR2_PACKAGE_LIBTOOL
 	help
 	  Guile is an interpreter and compiler for the Scheme
 	  programming language, a clean and elegant dialect of Lisp.
Signature · 1 line
1.9.1
#2 lore raw

PATCH 2/2 bdwgc: add patch automatically detecting for NO_GETCONTEXT need

In reply to Yann E. MORIN

From: Samuel Martin <[email protected]>

This patch is necessary to successfully build guile with toolchain missing support for getcontext.

[yann.morin.1998 at free.fr: add a comment, change variable name, use
AS_IF, remove debug traces, use AC_CHECK_FUNCS (Thomas)]

Cc Thomas Petazzoni <[email protected]>

---
Note: we're not testing setcontext, because it is not used. getcontext is used only to retrieve the context of the tread (like registers, heap adress, and so on...), not to actually use contexts.

---
 ...ac-add-check-for-NO_GETCONTEXT-definition.patch | 28 ++++++++++++++++++++++
 1 file changed, 28 insertions(+)
 create mode 100644 package/bdwgc/0001-configure.ac-add-check-for-NO_GETCONTEXT-definition.patch
package/bdwgc/0001-configure.ac-add-check-for-NO_GETCONTEXT-definition.patch new file +28 -0
new file mode 100644
index 0000000..393ad90
@@ -0,0 +1,28 @@
+configure.ac: add check for NO_GETCONTEXT definition
+
+Signed-off-by: Samuel Martin <[email protected]>
+[yann.morin.1998 at free.fr: add a comment, change variable name, use
+ AS_IF, remove debug traces, use AC_CHECK_FUNCS (as suggested by
+ Thomas)]
+Signed-off-by: "Yann E. MORIN" <[email protected]>
+Cc: Thomas Petazzoni <[email protected]>
+
+---
+ configure.ac | 6 ++++++
+ 1 file changed, 6 insertions(+)
+
+--- bdwgc-7.2f.orig/configure.ac	2014-06-01 19:00:47.000000000 +0200
++++ bdwgc-7.2f/configure.ac	2014-12-23 14:13:11.585716713 +0100
+@@ -365,6 +365,12 @@
+   AC_MSG_RESULT($ac_cv_fno_strict_aliasing)
+ fi
+ 
++# Check for getcontext (uClibc can be configured without it, for example)
++AC_CHECK_FUNCS([getcontext])
++AS_IF([test "$ac_cv_func_getcontext" = "no"],
++  [CFLAGS="$CFLAGS -DNO_GETCONTEXT"
++   CPPFLAGS="$CPPFLAGS -DNO_GETCONTEXT"])
++
+ case "$host" in
+ # While IRIX 6 has libdl for the O32 and N32 ABIs, it's missing for N64
+ # and unnecessary everywhere.
Signature · 1 line
1.9.1
#3 lore raw

cover misc guile-related fixes (branch yem/fixes)

In reply to Yann E. MORIN

Dear Yann E. MORIN,

Quoted 5 lines · Yann E. MORIN

Samuel Martin (1):
bdwgc: add patch automatically detecting for NO_GETCONTEXT need

Yann E. MORIN (1):
package/guile: needs libtool

Both applied, thanks.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com