Skip to contentSkip to conversation

Makefile: clarify comment on .br-external handling

PATCH New Baruch Siach 2 participants 2 messages Dec 25, 2014 – Dec 26, 2014 Kbuild

lore
Share & tools
lore

Baruch Siach

author
#0 lore raw

PATCH 1/1 Makefile: clarify comment on .br-external handling

The comment language may lead the reader to think that .br-external is removed whenever BR2_EXTERNAL is not set in the command line. Make it clear that BR2_EXTERNAL must be explicitly set to an empty value for .br-external to get removed.

Signed-off-by Baruch Siach <[email protected]>
---
 Makefile | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
Makefile +3 -2
index ad018c88f12e..5e0b4f254a05 100644
@@ -123,8 +123,9 @@ $(if $(BASE_DIR),, $(error output directory "$(O)" does not exist))
 # On subsequent invocations of make, it is read in. It can still be overridden
 # on the command line, therefore the file is re-created every time make is run.
 #
-# When BR2_EXTERNAL is not set, the .br-external file is removed and we point
-# to support/dummy-external. This makes sure we can unconditionally include the
+# When BR2_EXTERNAL is set to an empty value (e.g. explicitly in command
+# line), the .br-external file is removed and we point to
+# support/dummy-external. This makes sure we can unconditionally include the
 # Config.in and external.mk from the BR2_EXTERNAL directory. In this case,
 # override is necessary so the user can clear BR2_EXTERNAL from the command
 # line, but the dummy path is still used internally.
Signature · 1 line
2.1.3
Applied
#1 lore raw

PATCH 1/1 Makefile: clarify comment on .br-external handling

Dear Baruch Siach,

Quoted 9 lines · Baruch Siach

The comment language may lead the reader to think that .br-external is removed whenever BR2_EXTERNAL is not set in the command line. Make it clear that BR2_EXTERNAL must be explicitly set to an empty value for .br-external to get removed.

Signed-off-by Baruch Siach <[email protected]>
---
 Makefile | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

Applied, thanks!

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com