Skip to contentSkip to conversation

NFS: nfs4_fs.h: Fix for checkpatch warnings

PATCH In review Koshy George 3 participants 3 messages Dec 27, 2014

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 NFS: nfs4_fs.h: Fix for checkpatch warnings

This patch fix checkpatch warning for nfs4_fs.h

fs/nfs/nfs4_fs.h:134: ERROR: "foo * bar" should be "foo *bar"
fs/nfs/nfs4_fs.h:416: ERROR: "foo * bar" should be "foo *bar"

[Being first patch, need some assistance]
---
 fs/nfs/nfs4_fs.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
fs/nfs/nfs4_fs.h +2 -2
index a081787..ae336c7 100644
@@ -131,7 +131,7 @@ enum {
 
 struct nfs4_lock_state {
 	struct list_head	ls_locks;	/* Other lock stateids */
-	struct nfs4_state *	ls_state;	/* Pointer to open state */
+	struct nfs4_state	*ls_state;	/* Pointer to open state */
 #define NFS_LOCK_INITIALIZED 0
 #define NFS_LOCK_LOST        1
 	unsigned long		ls_flags;
@@ -413,7 +413,7 @@ static inline void nfs4_schedule_session_recovery(struct nfs4_session *session,
 extern struct nfs4_state_owner *nfs4_get_state_owner(struct nfs_server *, struct rpc_cred *, gfp_t);
 extern void nfs4_put_state_owner(struct nfs4_state_owner *);
 extern void nfs4_purge_state_owners(struct nfs_server *);
-extern struct nfs4_state * nfs4_get_open_state(struct inode *, struct nfs4_state_owner *);
+extern struct nfs4_state *nfs4_get_open_state(struct inode *, struct nfs4_state_owner *);
 extern void nfs4_put_open_state(struct nfs4_state *);
 extern void nfs4_close_state(struct nfs4_state *, fmode_t);
 extern void nfs4_close_sync(struct nfs4_state *, fmode_t);
Signature · 1 line
1.9.1
#1 lore raw
Quoted 7 lines · Koshy George

This patch fix checkpatch warning for nfs4_fs.h

fs/nfs/nfs4_fs.h:134: ERROR: "foo * bar" should be "foo *bar"
fs/nfs/nfs4_fs.h:416: ERROR: "foo * bar" should be "foo *bar"

[Being first patch, need some assistance]

this should not come here. any comment like this you can place below the ---
And actually its better to try generate your first patch on staging. There are lots of things to fix there.

thanks
sudip

Quoted 34 lines
---
 fs/nfs/nfs4_fs.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
fs/nfs/nfs4_fs.h +2 -2
index a081787..ae336c7 100644
@@ -131,7 +131,7 @@ enum {
 
 struct nfs4_lock_state {
 	struct list_head	ls_locks;	/* Other lock stateids */
-	struct nfs4_state *	ls_state;	/* Pointer to open state */
+	struct nfs4_state	*ls_state;	/* Pointer to open state */
 #define NFS_LOCK_INITIALIZED 0
 #define NFS_LOCK_LOST        1
 	unsigned long		ls_flags;
@@ -413,7 +413,7 @@ static inline void nfs4_schedule_session_recovery(struct nfs4_session *session,
 extern struct nfs4_state_owner *nfs4_get_state_owner(struct nfs_server *, struct rpc_cred *, gfp_t);
 extern void nfs4_put_state_owner(struct nfs4_state_owner *);
 extern void nfs4_purge_state_owners(struct nfs_server *);
-extern struct nfs4_state * nfs4_get_open_state(struct inode *, struct nfs4_state_owner *);
+extern struct nfs4_state *nfs4_get_open_state(struct inode *, struct nfs4_state_owner *);
 extern void nfs4_put_open_state(struct nfs4_state *);
 extern void nfs4_close_state(struct nfs4_state *, fmode_t);
 extern void nfs4_close_sync(struct nfs4_state *, fmode_t);
Signature · 7 lines
1.9.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/
#2 lore raw
In reply to Koshy George
Quoted 34 lines · Koshy George

This patch fix checkpatch warning for nfs4_fs.h

fs/nfs/nfs4_fs.h:134: ERROR: "foo * bar" should be "foo *bar"
fs/nfs/nfs4_fs.h:416: ERROR: "foo * bar" should be "foo *bar"

[Being first patch, need some assistance]
---
 fs/nfs/nfs4_fs.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
fs/nfs/nfs4_fs.h +2 -3
index a081787..ae336c7 100644
@@ -131,7 +131,7 @@ enum {
 
 struct nfs4_lock_state {
        struct list_head        ls_locks;       /* Other lock stateids */
-       struct nfs4_state *     ls_state;       /* Pointer to open state */
+       struct nfs4_state       *ls_state;      /* Pointer to open state */
 #define NFS_LOCK_INITIALIZED 0
 #define NFS_LOCK_LOST        1
        unsigned long           ls_flags;
@@ -413,7 +413,7 @@ static inline void nfs4_schedule_session_recovery(struct nfs4_session *session,
 extern struct nfs4_state_owner *nfs4_get_state_owner(struct nfs_server *, struct rpc_cred *, gfp_t);
 extern void nfs4_put_state_owner(struct nfs4_state_owner *);
 extern void nfs4_purge_state_owners(struct nfs_server *);
-extern struct nfs4_state * nfs4_get_open_state(struct inode *, struct nfs4_state_owner *);
+extern struct nfs4_state *nfs4_get_open_state(struct inode *, struct nfs4_state_owner *);
 extern void nfs4_put_open_state(struct nfs4_state *);
 extern void nfs4_close_state(struct nfs4_state *, fmode_t);
 extern void nfs4_close_sync(struct nfs4_state *, fmode_t);
--
Quoted 1 line

1.9.1

Sorry, but I'm not applying this kind of patch.

Signature · 3 lines
Trond Myklebust
Linux NFS client maintainer, PrimaryData
[email protected]