Skip to contentSkip to conversation

package/leafnode2: fix news user check

PATCH New Romain Naour 2 participants 3 messages Dec 26, 2014 – Dec 27, 2014

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 package/leafnode2: fix news user check

--enable-runas-user use 'news' as default but the configure stop if news doesn't exist on the build host.
Use 'root' while cross-compiling

---
 package/leafnode2/leafnode2.mk | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)
package/leafnode2/leafnode2.mk +5 -1
index 3bc1c68..0fc2a8d 100644
@@ -14,9 +14,13 @@ LEAFNODE2_DEPENDENCIES = host-pcre pcre
 LEAFNODE2_CONF_ENV = \
 	PCRECONFIG="$(STAGING_DIR)/usr/bin/pcre-config"
 
+# --enable-runas-user use 'news' as default but the configure stop
+# if news doesn't exist on the build host.
+# Use 'root' while cross-compiling 
 LEAFNODE2_CONF_OPTS = \
 	--sysconfdir=/etc/leafnode2 \
-	--enable-spooldir=/var/spool/news
+	--enable-spooldir=/var/spool/news \
+	--enable-runas-user=root
 
 # Leafnode2 needs the host version of b_sortnl during
 # compilation. Instead of creating a seperate host package and
Signature · 1 line
1.9.3
#1 lore raw

PATCH 1/1 package/leafnode2: fix news user check

Dear Romain Naour,

Quoted 8 lines · Romain Naour

--enable-runas-user use 'news' as default but the configure stop if news doesn't exist on the build host.
Use 'root' while cross-compiling

---
 package/leafnode2/leafnode2.mk | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

Applied, thanks. Here, leafnode2 does not start properly at boot time, it asks for a fully qualified host name in /etc/hosts. It would be good to add a default config file + init script to make leafnode2 work at least somewhat out of the box.

Thanks!

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
#2 lore raw

PATCH 1/1 package/leafnode2: fix news user check

Le 27/12/2014 17:13, Thomas Petazzoni a ?crit :

Quoted 11 lines

Dear Romain Naour,

Quoted 8 lines · Romain Naour

--enable-runas-user use 'news' as default but the configure stop if news doesn't exist on the build host.
Use 'root' while cross-compiling

---
 package/leafnode2/leafnode2.mk | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)
Quoted 8 lines

Applied, thanks. Here, leafnode2 does not start properly at boot time, it asks for a fully qualified host name in /etc/hosts. It would be good to add a default config file + init script to make leafnode2 work at least somewhat out of the box.

Thanks!

Thomas

Honestly, I haven't runtime tested leadnode2.
I just checked why the build has stopped during a random build.

The configure script run the command: id -u news:
a=$ID -u $RUNAS_USER
if test -z "$a" ; then
as_fn_error $? "user $RUNAS_USER does not exist. Please add this user before building leafnode.
Most systems have man adduser or man useradd to tell you how to do this." "$LINENO" 5
else
...

This test is used to print a warning because it expect a native
build:
WARNING: user $RUNAS_USER cannot be used to run leafnode for security reasons. Be sure to configure run_as_user to an unprivileged user, else leafnode will not run."

I'm adding Bernd to cc since it use leadnode2.

Best regards,
Romain