Skip to contentSkip to conversation

rename() from outside of the target dir breaks /proc exe symlink.

BUG Piotr Karbowski 3 participants 5 messages Dec 27, 2014 – Feb 9, 2015

lore
Share & tools
lore
#0 lore raw

Hi,

There's something wrong about exe symlink that can be found insde /proc/<pid>/ directories. When the running binary is replaced with another, using rename() call, the symlink may point to wrong path.

As example let me use sshd. I have running sshd from /usr/sbin. If I replace /usr/sbin/sshd one could expect to see exe symlink pointing to '/usr/sbin/sshd (deleted)', it does work this way if the source of rename() was in the same directory or nested within, thus rename like:

rename("/usr/sbin/foo", "/usr/sbin/sshd")

and

rename("/usr/sbin/bar/sshd", "/usr/sbin/sshd")

ends with a proper '/usr/sbin/sshd (deleted)' symlink.

if however the source was outside of the target directory, the symlink will point to the source path of rename() calls with 'deleted' sufix.

Here's example:

sbin # for i in pidof sshd; do ls -l /proc/$i/exe; done lrwxrwxrwx 1 root root 0 Dec 27 18:09 /proc/29047/exe -> /usr/sbin/sshd

sbin # cp sshd /root/foo

sbin # strace -f perl -e 'rename("/root/foo", "/usr/sbin/sshd")' 2>&1 | grep sshd
rename("/root/foo", "/usr/sbin/sshd") = 0

sbin # for i in pidof sshd; do ls -l /proc/$i/exe; done lrwxrwxrwx 1 root root 0 Dec 27 18:09 /proc/29047/exe -> /root/sshd (deleted)

I am unable to find kernel version where it worked as one could presume thus I cannot offer to bisect commits to find the bad one.

The environment was kernel 3.17.4 x86_64 and the filesystem ext4.

-- Piotr.

#1 lore raw
Quoted 35 lines · Piotr Karbowski

Hi,

There's something wrong about exe symlink that can be found insde /proc/<pid>/ directories. When the running binary is replaced with another, using rename() call, the symlink may point to wrong path.

As example let me use sshd. I have running sshd from /usr/sbin. If I replace /usr/sbin/sshd one could expect to see exe symlink pointing to '/usr/sbin/sshd (deleted)', it does work this way if the source of rename() was in the same directory or nested within, thus rename like:

rename("/usr/sbin/foo", "/usr/sbin/sshd")

and

rename("/usr/sbin/bar/sshd", "/usr/sbin/sshd")

ends with a proper '/usr/sbin/sshd (deleted)' symlink.

if however the source was outside of the target directory, the symlink will point to the source path of rename() calls with 'deleted' sufix.

Here's example:

sbin # for i in pidof sshd; do ls -l /proc/$i/exe; done lrwxrwxrwx 1 root root 0 Dec 27 18:09 /proc/29047/exe -> /usr/sbin/sshd

sbin # cp sshd /root/foo

sbin # strace -f perl -e 'rename("/root/foo", "/usr/sbin/sshd")' 2>&1 | grep sshd
rename("/root/foo", "/usr/sbin/sshd") = 0

Quoted 6 lines

sbin # for i in pidof sshd; do ls -l /proc/$i/exe; done lrwxrwxrwx 1 root root 0 Dec 27 18:09 /proc/29047/exe -> /root/sshd (deleted)

I am unable to find kernel version where it worked as one could presume thus I cannot offer to bisect commits to find the bad one.

That's because it never _had_ worked. Note that opening the damn thing will give the right file - it does not work by traversing the result of readlink(2). readlink(2) output on those is not promised to be useful in all cases; often enough it is, but it won't work on cross-directory renames, it can't be used to tell a filename that really ends with " (deleted)" from a removed file, etc. Moreover, it only very recently became usable for victim names with the last component longer than 40 characters if you did an overwriting rename.

What are you trying to use it for?

#2 lore raw

Hi Al,

Quoted 10 lines · Al Viro

That's because it never _had_ worked. Note that opening the damn thing will give the right file - it does not work by traversing the result of readlink(2). readlink(2) output on those is not promised to be useful in all cases; often enough it is, but it won't work on cross-directory renames, it can't be used to tell a filename that really ends with " (deleted)" from a removed file, etc. Moreover, it only very recently became usable for victim names with the last component longer than 40 characters if you did an overwriting rename.

What are you trying to use it for?

I am using it to track the origin of running processes. I am working with continuous integration of a Linux embedded software. The tests goes in Linux containers, multiple instances of binary with the same name in a single container/namespace, all with cwd symlink pointing to / which looks from outside virtually the same, the binaries are modified at runtime by coping, modifing and replacing for another execution of the same binary (using patchelf to add additional NEEDED to header or change rpath or dynamic loader and such).

In my very usecase, the exe symlink is essential.

-- Piotr.

#3 lore raw
Quoted 26 lines · Piotr Karbowski

Hi Al,

Quoted 12 lines · Al Viro

That's because it never _had_ worked. Note that opening the damn thing will give the right file - it does not work by traversing the result of readlink(2). readlink(2) output on those is not promised to be useful in all cases; often enough it is, but it won't work on cross-directory renames, it can't be used to tell a filename that really ends with " (deleted)"
from a removed file, etc. Moreover, it only very recently became usable for
victim names with the last component longer than 40 characters if you did an
overwriting rename.

Quoted 1 line

What are you trying to use it for?

I am using it to track the origin of running processes. I am working with continuous integration of a Linux embedded software. The tests goes in Linux containers, multiple instances of binary with the same name in a single container/namespace, all with cwd symlink pointing to / which looks from outside virtually the same, the binaries are modified at runtime by coping, modifing and replacing for another execution of the same binary (using patchelf to add additional NEEDED to header or change rpath or dynamic loader and such).

Quoted 1 line

In my very usecase, the exe symlink is essential.

*Friendly bump*

Can anything be done about it or is there any other mechanism that I could use to get origin of the running binary?

-- Piotr.

#4 lore raw
Quoted 27 lines · Piotr Karbowski
Quoted 26 lines · Piotr Karbowski

Hi Al,

Quoted 12 lines · Al Viro

That's because it never _had_ worked. Note that opening the damn thing will give the right file - it does not work by traversing the result of readlink(2). readlink(2) output on those is not promised to be useful in all cases; often enough it is, but it won't work on cross-directory renames, it can't be used to tell a filename that really ends with " (deleted)"
from a removed file, etc. Moreover, it only very recently became usable for
victim names with the last component longer than 40 characters if you did an
overwriting rename.

Quoted 1 line

What are you trying to use it for?

I am using it to track the origin of running processes. I am working with continuous integration of a Linux embedded software. The tests goes in Linux containers, multiple instances of binary with the same name in a single container/namespace, all with cwd symlink pointing to / which looks from outside virtually the same, the binaries are modified at runtime by coping, modifing and replacing for another execution of the same binary (using patchelf to add additional NEEDED to header or change rpath or dynamic loader and such).

Quoted 6 lines
Quoted 1 line

In my very usecase, the exe symlink is essential.

*Friendly bump*

Can anything be done about it or is there any other mechanism that I could use to get origin of the running binary?

*Even friendlier bump*

-- Piotr.