Skip to contentSkip to conversation

devkit8000: convert to use generic board code

PATCH In review Anthoine Bourgeois 2 participants 5 messages Dec 24, 2014 – Jan 7, 2015

lore
Share & tools
lore

Anthoine Bourgeois

author
#0 lore raw

PATCH 1/1 devkit8000: convert to use generic board code

Signed-off-by Anthoine Bourgeois <[email protected]>

---

 include/configs/devkit8000.h | 1 +
 1 file changed, 1 insertion(+)
include/configs/devkit8000.h +1 -0
index 930b08e..77e2f58 100644
@@ -21,6 +21,7 @@
 #define CONFIG_MACH_TYPE	MACH_TYPE_DEVKIT8000
 #define CONFIG_OMAP_GPIO
 #define CONFIG_OMAP_COMMON
+#define CONFIG_SYS_GENERIC_BOARD
 
 /*
  * 1MB into the SDRAM to allow for SPL's bss at the beginning of SDRAM
Signature · 1 line
2.0.4
author
#1 lore raw

PATCH 1/1 devkit8000: convert to use generic board code

Hi,

Quoted 11 lines · Anthoine Bourgeois
Signed-off-by Anthoine Bourgeois <[email protected]>

---

 include/configs/devkit8000.h | 1 +
 1 file changed, 1 insertion(+)
include/configs/devkit8000.h +0 -0
index 930b08e..77e2f58 100644

include/configs/devkit8000.h line 24

Quoted 4 lines
include/configs/devkit8000.h +1 -0
@@ -21,6 +21,7 @@
 #define CONFIG_MACH_TYPE	MACH_TYPE_DEVKIT8000
 #define CONFIG_OMAP_GPIO
 #define CONFIG_OMAP_COMMON
+#define CONFIG_SYS_GENERIC_BOARD

I try this patch with my devkit8000 board and it works well but I wonder if the devkit8000.h configuration should inherit the ti_omap3_common.h configuration. I can do those modifications but is it a good idea ? Is it worth to try ?

Thanks, Anthoine

author
#2 lore raw

PATCH 1/1 devkit8000: convert to use generic board code

Hi,

Quoted 11 lines · Anthoine Bourgeois
Signed-off-by Anthoine Bourgeois <[email protected]>

---

 include/configs/devkit8000.h | 1 +
 1 file changed, 1 insertion(+)
include/configs/devkit8000.h +0 -0
index 930b08e..77e2f58 100644

include/configs/devkit8000.h line 24

Quoted 4 lines
include/configs/devkit8000.h +1 -0
@@ -21,6 +21,7 @@
 #define CONFIG_MACH_TYPE     MACH_TYPE_DEVKIT8000
 #define CONFIG_OMAP_GPIO
 #define CONFIG_OMAP_COMMON
+#define CONFIG_SYS_GENERIC_BOARD

I try this patch with my devkit8000 board and it works well but I wonder if the devkit8000.h configuration should inherit the ti_omap3_common.h configuration. I can do those modifications but is it a good idea ? Is it worth to try ?

Thanks, Anthoine

#3 lore raw

PATCH 1/1 devkit8000: convert to use generic board code

In reply to Anthoine Bourgeois
Quoted 10 lines · Anthoine Bourgeois

Hi,

Quoted 6 lines · Anthoine Bourgeois
Signed-off-by Anthoine Bourgeois <[email protected]>

---

 include/configs/devkit8000.h | 1 +
 1 file changed, 1 insertion(+)
Quoted 14 lines

include/configs/devkit8000.h line 24

Quoted 9 lines
include/configs/devkit8000.h +1 -0
index 930b08e..77e2f58 100644
@@ -21,6 +21,7 @@
 #define CONFIG_MACH_TYPE	MACH_TYPE_DEVKIT8000
 #define CONFIG_OMAP_GPIO
 #define CONFIG_OMAP_COMMON
+#define CONFIG_SYS_GENERIC_BOARD

I try this patch with my devkit8000 board and it works well but I wonder if the devkit8000.h configuration should inherit the ti_omap3_common.h configuration. I can do those modifications but is it a good idea ? Is it worth to try ?

It would be appreciated, yes, thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20150105/869f2301/attachment.pgp>
#4 lore raw
In reply to Anthoine Bourgeois
Quoted 1 line · Anthoine Bourgeois
Signed-off-by Anthoine Bourgeois <[email protected]>

Since we're close to release, I'm taking this now and will take your patches to further clean up the config after release, applied to u-boot/master, thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20150107/72eae561/attachment.pgp>