arm64: KVM: Fix TLB invalidation by IPA/VMID
PATCH 1/1 arm64: KVM: Fix TLB invalidation by IPA/VMID
It took about two years for someone to notice that the IPA passed to TLBI IPAS2E1IS must be shifted by 12 bits. Clearly our reviewing is not as good as it should be...
Paper bag time for me.
--- arch/arm64/kvm/hyp.S | 1 + 1 file changed, 1 insertion(+)
arch/arm64/kvm/hyp.S +1 -0
@@ -1014,6 +1014,7 @@ ENTRY(__kvm_tlb_flush_vmid_ipa) * Instead, we invalidate Stage-2 for this IPA, and the * whole of Stage-1. Weep... */ + lsr x1, x1, #12 tlbi ipas2e1is, x1 /* * We have to ensure completion of the invalidation at Stage-2,
Signature · 1 line
2.1.3
Christoffer Dall
AppliedPATCH 1/1 arm64: KVM: Fix TLB invalidation by IPA/VMID
Quoted 9 lines · Marc Zyngier
It took about two years for someone to notice that the IPA passed to TLBI IPAS2E1IS must be shifted by 12 bits. Clearly our reviewing is not as good as it should be...
Paper bag time for me.
Reported-by Mario Smarduch <[email protected]>Tested-by Mario Smarduch <[email protected]>Signed-off-by Marc Zyngier <[email protected]>
Thanks, applied to queue.
-Christoffer
PATCH 1/1 arm64: KVM: Fix TLB invalidation by IPA/VMID
Quoted 5 lines · Christoffer Dall
Quoted 4 lines · Marc Zyngier
It took about two years for someone to notice that the IPA passed to TLBI IPAS2E1IS must be shifted by 12 bits. Clearly our reviewing is not as good as it should be...
Quoted 7 lines
Quoted 5 lines
Paper bag time for me.
Reported-by Mario Smarduch <[email protected]>Tested-by Mario Smarduch <[email protected]>Signed-off-by Marc Zyngier <[email protected]>Thanks, applied to queue.
Thanks for picking this up. This should also be CC-ed to -stable, as all versions of the kernel since 3.11 are affected.
M.
Signature · 1 line
Jazz is not dead. It just smells funny.