Staging: comedi: fix space and 80 char coding style issue

PATCH In review jitendra kumar khasdev 3 participants 3 messages Dec 28, 2014 – Dec 29, 2014 Staging

Share & tools

jitendra kumar khasdev

author

2014-12-28 21:45 UTC #0 lore raw

PATCH 3/3 Staging: comedi: fix space and 80 char coding style issue

This is a patch to the s626.c file that fixes up spcae and maximum character limit warning found by the checkpatch.pl tool

Signed-off-by Jitendra Kumar Khasdev <[email protected]>

---
 drivers/staging/comedi/drivers/s626.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

drivers/staging/comedi/drivers/s626.c +3 -2

index 14932c5..77f715b 100644
@@ -118,7 +118,7 @@ static void s626_mc_enable(struct comedi_device *dev,
 static void s626_mc_disable(struct comedi_device *dev,
 			    unsigned int cmd, unsigned int reg)
 {
-	writel(cmd << 16 , dev->mmio + reg);
+	writel(cmd << 16, dev->mmio + reg);
 	mmiowb();
 }

@@ -2534,7 +2534,8 @@ static int s626_initialize(struct comedi_device *dev)
 	for (i = 0; i < 2; i++) {
 		writel(S626_I2C_CLKSEL, dev->mmio + S626_P_I2CSTAT);
 		s626_mc_enable(dev, S626_MC2_UPLD_IIC, S626_P_MC2);
-		ret = comedi_timeout(dev, NULL, NULL, s626_i2c_handshake_eoc, 0);
+		ret = comedi_timeout(dev, NULL, NULL, s626_i2c_handshake_eoc,
+		0);
 		if (ret)
 			return ret;
 	}

Signature · 1 line

1.9.1

Sudip Mukherjee

2014-12-29 07:07 UTC #1 lore raw

Quoted 2 lines · jitendra kumar khasdev

This is a patch to the s626.c file that fixes up spcae and maximum character limit warning found by the checkpatch.pl tool

you are doing two different kind of changes in this patch. it should be in two different patches. One patch should do only one type of change.

thanks
sudip

Quoted 37 lines

Signed-off-by Jitendra Kumar Khasdev <[email protected]>

---
 drivers/staging/comedi/drivers/s626.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

drivers/staging/comedi/drivers/s626.c +3 -2

index 14932c5..77f715b 100644
@@ -118,7 +118,7 @@ static void s626_mc_enable(struct comedi_device *dev,
 static void s626_mc_disable(struct comedi_device *dev,
 			    unsigned int cmd, unsigned int reg)
 {
-	writel(cmd << 16 , dev->mmio + reg);
+	writel(cmd << 16, dev->mmio + reg);
 	mmiowb();
 }

@@ -2534,7 +2534,8 @@ static int s626_initialize(struct comedi_device *dev)
 	for (i = 0; i < 2; i++) {
 		writel(S626_I2C_CLKSEL, dev->mmio + S626_P_I2CSTAT);
 		s626_mc_enable(dev, S626_MC2_UPLD_IIC, S626_P_MC2);
-		ret = comedi_timeout(dev, NULL, NULL, s626_i2c_handshake_eoc, 0);
+		ret = comedi_timeout(dev, NULL, NULL, s626_i2c_handshake_eoc,
+		0);
 		if (ret)
 			return ret;
 	}

Signature · 7 lines

1.9.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Pankaj Saraf

2014-12-29 13:18 UTC #2 lore raw

Jitendra,

You have to make 2 different changes so that the description of the change can clearly be associated to change-number. Thanks!

Regards
Pankaj Saraf
NEKTech Research Labs, Bhopal (M.P.) - India

Quoted 51 lines · Sudip Mukherjee

Quoted 2 lines · jitendra kumar khasdev

This is a patch to the s626.c file that fixes up spcae and maximum character limit warning found by the checkpatch.pl tool

you are doing two different kind of changes in this patch. it should be in two different patches. One patch should do only one type of change.

thanks
sudip

Quoted 41 lines

Signed-off-by Jitendra Kumar Khasdev <[email protected]>

---
 drivers/staging/comedi/drivers/s626.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

drivers/staging/comedi/drivers/s626.c +3 -2

index 14932c5..77f715b 100644
@@ -118,7 +118,7 @@ static void s626_mc_enable(struct comedi_device
 *dev,
 static void s626_mc_disable(struct comedi_device *dev,
 			    unsigned int cmd, unsigned int reg)
 {
-	writel(cmd << 16 , dev->mmio + reg);
+	writel(cmd << 16, dev->mmio + reg);
 	mmiowb();
 }

@@ -2534,7 +2534,8 @@ static int s626_initialize(struct comedi_device
 *dev)
 	for (i = 0; i < 2; i++) {
 		writel(S626_I2C_CLKSEL, dev->mmio + S626_P_I2CSTAT);
 		s626_mc_enable(dev, S626_MC2_UPLD_IIC, S626_P_MC2);
-		ret = comedi_timeout(dev, NULL, NULL, s626_i2c_handshake_eoc, 0);
+		ret = comedi_timeout(dev, NULL, NULL, s626_i2c_handshake_eoc,
+		0);
 		if (ret)
 			return ret;

}

Signature · 8 lines

1.9.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel"
in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/