Skip to contentSkip to conversation

Vendor Setup for walkera_dev structure argument in the function,walkera0701_connect for the file,walera0701.c

DISCUSSION Dmitry Torokhov 1 participant 1 message Dec 29, 2014 1 message not in the archive HID

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

#1 lore raw

Hi Nick,

Quoted 9 lines · nick

Greetings Dmirty,
I am wondering about the below code in the function,walkera701_connect in the file,walera0701.c. /* TODO what id vendor/product/version ? */

         w->input_dev->id.vendor = 0x0001;
         w->input_dev->id.product = 0x0001;
         w->input_dev->id.version = 0x0100;

As the maintainer I am wondering if you known the values these need to be set to as it seems a rather trivial patch for me to write if you can send me the correct values or a reference sheet.

I think we should not have initialized them at all as I don't think we have good values for IDs for it. But now that we had done that, current values are as good as any... Just leave the driver alone.

Also, as you mentioned, producing a patch is trivial. If you want to get involved in kernel development you need to do some research and actually _propose_ the changes (with explanation why the change is needed and why you chose to make the change in a certain way), rather just asking maintainers for explicit instructions on what changes to make.

Thanks.

Signature · 1 line
Dmitry