Skip to contentSkip to conversation

ntp upgrade (including security fixes)

PATCH Applied Paul Eggleton 3 participants 4 messages Dec 25, 2014 – Dec 29, 2014

lore
Share & tools
lore
#0 lore raw

cover ntp upgrade (including security fixes)

The following change since commit edcf03b5fb576dbeae3784471aec8c2b7a9a04a8:

eggdbus: port from openembedded. (2014-12-17 13:11:57 +0100)

is available in the git repository at:

git://git.openembedded.org/meta-openembedded-contrib paule/ntp-upgrade
http://cgit.openembedded.org/cgit.cgi/meta-openembedded-contrib/log/?h=paule/ntp-upgrade

Paul Eggleton (1):
ntp: upgrade to 4.2.8

 .../recipes-support/ntp/files/CVE-2013-5211.patch  | 112 --------------
 .../recipes-support/ntp/files/openssl-check.patch  |  59 --------
 .../recipes-support/ntp/files/tickadj.c.patch      |  32 ----
 .../ntp/{files => ntp}/ntp-4.2.4_p6-nano.patch     |   0
 .../ntp/ntp/ntp-4.2.8-ntp-keygen-no-openssl.patch  | 168 +++++++++++++++++++++
 .../recipes-support/ntp/{files => ntp}/ntp.conf    |   0
 .../recipes-support/ntp/{files => ntp}/ntpd        |   0
 .../recipes-support/ntp/{files => ntp}/ntpdate     |   0
 .../ntp/{files => ntp}/ntpdate.default             |   0
 meta-networking/recipes-support/ntp/ntp_4.2.6p5.bb |   6 -
 .../recipes-support/ntp/{ntp.inc => ntp_4.2.8.bb}  |  41 ++---
 11 files changed, 191 insertions(+), 227 deletions(-)
 delete mode 100644 meta-networking/recipes-support/ntp/files/CVE-2013-5211.patch
 delete mode 100644 meta-networking/recipes-support/ntp/files/openssl-check.patch
 delete mode 100644 meta-networking/recipes-support/ntp/files/tickadj.c.patch
 rename meta-networking/recipes-support/ntp/{files => ntp}/ntp-4.2.4_p6-nano.patch (100%)
 create mode 100644 meta-networking/recipes-support/ntp/ntp/ntp-4.2.8-ntp-keygen-no-openssl.patch
 rename meta-networking/recipes-support/ntp/{files => ntp}/ntp.conf (100%)
 rename meta-networking/recipes-support/ntp/{files => ntp}/ntpd (100%)
 rename meta-networking/recipes-support/ntp/{files => ntp}/ntpdate (100%)
 rename meta-networking/recipes-support/ntp/{files => ntp}/ntpdate.default (100%)
 delete mode 100644 meta-networking/recipes-support/ntp/ntp_4.2.6p5.bb
 rename meta-networking/recipes-support/ntp/{ntp.inc => ntp_4.2.8.bb} (81%)
Signature · 1 line
1.9.3
#1 lore raw

PATCH 1/1 ntp: upgrade to 4.2.8

* Upgrade to 4.2.8 which fixes several security issues, including CVE-2014-9293, CVE-2014-9294, CVE-2014-9295, and CVE-2014-9296. For more details please see:
https://ics-cert.us-cert.gov/advisories/ICSA-14-353-01A
* LIC_FILES_CHKSUM changed due to a number of copyright year and patch list changes; nothing material about the license text changed.
* This version moves a number of binaries from sbindir to bindir; there's supposed to be a configure option --with-locfile=legacy to use the old layout but it does not seem to work. I guess we'll just have to live with the change.
* Drop patches which are no longer applicable.
* Merge inc file into recipe; there were too many changes required to the inc file in this version and it's unlikely it was much use split out in any case.
* Move remaining files in files/ to ntp/

---
 .../recipes-support/ntp/files/CVE-2013-5211.patch  | 112 --------------
 .../recipes-support/ntp/files/openssl-check.patch  |  59 --------
 .../recipes-support/ntp/files/tickadj.c.patch      |  32 ----
 .../ntp/{files => ntp}/ntp-4.2.4_p6-nano.patch     |   0
 .../ntp/ntp/ntp-4.2.8-ntp-keygen-no-openssl.patch  | 168 +++++++++++++++++++++
 .../recipes-support/ntp/{files => ntp}/ntp.conf    |   0
 .../recipes-support/ntp/{files => ntp}/ntpd        |   0
 .../recipes-support/ntp/{files => ntp}/ntpdate     |   0
 .../ntp/{files => ntp}/ntpdate.default             |   0
 meta-networking/recipes-support/ntp/ntp_4.2.6p5.bb |   6 -
 .../recipes-support/ntp/{ntp.inc => ntp_4.2.8.bb}  |  41 ++---
 11 files changed, 191 insertions(+), 227 deletions(-)
 delete mode 100644 meta-networking/recipes-support/ntp/files/CVE-2013-5211.patch
 delete mode 100644 meta-networking/recipes-support/ntp/files/openssl-check.patch
 delete mode 100644 meta-networking/recipes-support/ntp/files/tickadj.c.patch
 rename meta-networking/recipes-support/ntp/{files => ntp}/ntp-4.2.4_p6-nano.patch (100%)
 create mode 100644 meta-networking/recipes-support/ntp/ntp/ntp-4.2.8-ntp-keygen-no-openssl.patch
 rename meta-networking/recipes-support/ntp/{files => ntp}/ntp.conf (100%)
 rename meta-networking/recipes-support/ntp/{files => ntp}/ntpd (100%)
 rename meta-networking/recipes-support/ntp/{files => ntp}/ntpdate (100%)
 rename meta-networking/recipes-support/ntp/{files => ntp}/ntpdate.default (100%)
 delete mode 100644 meta-networking/recipes-support/ntp/ntp_4.2.6p5.bb
 rename meta-networking/recipes-support/ntp/{ntp.inc => ntp_4.2.8.bb} (81%)
meta-networking/recipes-support/ntp/files/CVE-2013-5211.patch deleted +0 -112
deleted file mode 100644
index ddcb044..0000000
@@ -1,112 +0,0 @@
-ntp: fix CVE-2013-5211
-
-Upstream-status: Backport
-
-The monlist feature in ntp_request.c in ntpd in NTP before
-4.2.7p26 allows remote attackers to cause a denial of service
-(traffic amplification) via forged (1) REQ_MON_GETLIST or
-(2) REQ_MON_GETLIST_1 requests, as exploited in the wild
-in December 2013.
-
-Signed-off-by: Zhang Xiao <[email protected]>
-
---- a/ntpd/ntp_request.c
-+++ b/ntpd/ntp_request.c
-@@ -1912,44 +1912,11 @@ mon_getlist_0(
- 	struct req_pkt *inpkt
- 	)
- {
--	register struct info_monitor *im;
--	register struct mon_data *md;
--	extern struct mon_data mon_mru_list;
--	extern int mon_enabled;
--
- #ifdef DEBUG
- 	if (debug > 2)
- 	    printf("wants monitor 0 list\n");
- #endif
--	if (!mon_enabled) {
--		req_ack(srcadr, inter, inpkt, INFO_ERR_NODATA);
--		return;
--	}
--	im = (struct info_monitor *)prepare_pkt(srcadr, inter, inpkt,
--	    v6sizeof(struct info_monitor));
--	for (md = mon_mru_list.mru_next; md != &mon_mru_list && im != 0;
--	     md = md->mru_next) {
--		im->lasttime = htonl((u_int32)((current_time -
--		    md->firsttime) / md->count));
--		im->firsttime = htonl((u_int32)(current_time - md->lasttime));
--		im->restr = htonl((u_int32)md->flags);
--		im->count = htonl((u_int32)(md->count));
--		if (IS_IPV6(&md->rmtadr)) {
--			if (!client_v6_capable)
--				continue;
--			im->addr6 = SOCK_ADDR6(&md->rmtadr);
--			im->v6_flag = 1;
--		} else {
--			im->addr = NSRCADR(&md->rmtadr);
--			if (client_v6_capable)
--				im->v6_flag = 0;
--		}
--		im->port = md->rmtport;
--		im->mode = md->mode;
--		im->version = md->version;
--		im = (struct info_monitor *)more_pkt();
--	}
--	flush_pkt();
-+	req_ack(srcadr, inter, inpkt, INFO_ERR_NODATA);
- }
- 
- /*
-@@ -1962,50 +1929,7 @@ mon_getlist_1(
- 	struct req_pkt *inpkt
- 	)
- {
--	register struct info_monitor_1 *im;
--	register struct mon_data *md;
--	extern struct mon_data mon_mru_list;
--	extern int mon_enabled;
--
--	if (!mon_enabled) {
--		req_ack(srcadr, inter, inpkt, INFO_ERR_NODATA);
--		return;
--	}
--	im = (struct info_monitor_1 *)prepare_pkt(srcadr, inter, inpkt,
--	    v6sizeof(struct info_monitor_1));
--	for (md = mon_mru_list.mru_next; md != &mon_mru_list && im != 0;
--	     md = md->mru_next) {
--		im->lasttime = htonl((u_int32)((current_time -
--		    md->firsttime) / md->count));
--		im->firsttime = htonl((u_int32)(current_time - md->lasttime));
--		im->restr = htonl((u_int32)md->flags);
--		im->count = htonl((u_int32)md->count);
--		if (IS_IPV6(&md->rmtadr)) {
--			if (!client_v6_capable)
--				continue;
--			im->addr6 = SOCK_ADDR6(&md->rmtadr);
--			im->v6_flag = 1;
--			im->daddr6 = SOCK_ADDR6(&md->interface->sin);
--		} else {
--			im->addr = NSRCADR(&md->rmtadr);
--			if (client_v6_capable)
--				im->v6_flag = 0;
--			if (MDF_BCAST == md->cast_flags)
--				im->daddr = NSRCADR(&md->interface->bcast);
--			else if (md->cast_flags) {
--				im->daddr = NSRCADR(&md->interface->sin);
--				if (!im->daddr)
--					im->daddr = NSRCADR(&md->interface->bcast);
--			} else
--				im->daddr = 4;
--		}
--		im->flags = htonl(md->cast_flags);
--		im->port = md->rmtport;
--		im->mode = md->mode;
--		im->version = md->version;
--		im = (struct info_monitor_1 *)more_pkt();
--	}
--	flush_pkt();
-+	req_ack(srcadr, inter, inpkt, INFO_ERR_NODATA);
- }
- 
- /*
meta-networking/recipes-support/ntp/files/openssl-check.patch deleted +0 -59

59 lines not on this page · raw message

meta-networking/recipes-support/ntp/files/tickadj.c.patch deleted +0 -32
deleted file mode 100644
index 9ef9de9..0000000
@@ -1,32 +0,0 @@
-Index: ntp-4.2.2p3-r0/ntp-4.2.2p3/util/tickadj.c
-===================================================================
---- ntp-4.2.2p3/util/tickadj.c	2004-02-25 06:58:33.000000000 +0100
-+++ ntp-4.2.2p3/util/tickadj.c	2007-07-07 01:00:54.000000000 +0200
-@@ -21,7 +21,8 @@
- # include <unistd.h>
- #endif /* HAVE_UNISTD_H */
- 
--#ifdef HAVE___ADJTIMEX		/* Linux */
-+/* proper handling here has been moved to upstream ntp bugzilla */
-+#ifdef linux
- 
- #include <sys/timex.h>
- struct timex txc;
-@@ -91,7 +92,7 @@
- 	}
- 
- 	if (!errflg) {
--		if (__adjtimex(&txc) < 0)
-+		if (adjtimex(&txc) < 0)
- 			perror("adjtimex");
- 		else if (!quiet)
- 			printf("tick     = %ld\ntick_adj = %d\n",
-@@ -146,7 +147,7 @@
- #endif
- 	}
-     
--	if (__adjtimex(&txc) < 0)
-+	if (adjtimex(&txc) < 0)
- 	{
- 		perror("adjtimex");
- 	}
meta-networking/recipes-support/ntp/ntp/ntp-4.2.4_p6-nano.patch renamed from meta-networking/recipes-support/ntp/files/ntp-4.2.4_p6-nano.patch +0 -0
similarity index 100%
rename from meta-networking/recipes-support/ntp/files/ntp-4.2.4_p6-nano.patch
rename to meta-networking/recipes-support/ntp/ntp/ntp-4.2.4_p6-nano.patch
meta-networking/recipes-support/ntp/ntp/ntp-4.2.8-ntp-keygen-no-openssl.patch new file +168 -0

168 lines not on this page · raw message

meta-networking/recipes-support/ntp/ntp/ntp.conf renamed from meta-networking/recipes-support/ntp/files/ntp.conf +0 -0
similarity index 100%
rename from meta-networking/recipes-support/ntp/files/ntp.conf
rename to meta-networking/recipes-support/ntp/ntp/ntp.conf
meta-networking/recipes-support/ntp/ntp/ntpd renamed from meta-networking/recipes-support/ntp/files/ntpd +0 -0
similarity index 100%
rename from meta-networking/recipes-support/ntp/files/ntpd
rename to meta-networking/recipes-support/ntp/ntp/ntpd
meta-networking/recipes-support/ntp/ntp/ntpdate renamed from meta-networking/recipes-support/ntp/files/ntpdate +0 -0
similarity index 100%
rename from meta-networking/recipes-support/ntp/files/ntpdate
rename to meta-networking/recipes-support/ntp/ntp/ntpdate
meta-networking/recipes-support/ntp/ntp/ntpdate.default renamed from meta-networking/recipes-support/ntp/files/ntpdate.default +0 -0
similarity index 100%
rename from meta-networking/recipes-support/ntp/files/ntpdate.default
rename to meta-networking/recipes-support/ntp/ntp/ntpdate.default
meta-networking/recipes-support/ntp/ntp_4.2.6p5.bb deleted +0 -6
deleted file mode 100644
index 588a1b0..0000000
@@ -1,6 +0,0 @@
-require ntp.inc
-
-PR = "${INC_PR}.0"
-
-SRC_URI[md5sum] = "00df80a84ec9528fcfb09498075525bc"
-SRC_URI[sha256sum] = "d6ab8371f9d31e594eb6922823d5ccd03dcc4e9d84b0e23ea25ac1405432f91c"
meta-networking/recipes-support/ntp/ntp_4.2.8.bb renamed from meta-networking/recipes-support/ntp/ntp.inc +23 -18

88 lines not on this page · raw message

Signature · 1 line
1.9.3
#2 lore raw

Re: [meta-networking][PATCH 1/1] ntp: upgrade to 4.2.8

Dizzy needs these too. Can we upgrade Dizzy too or do we want patches
only?

- Armin

Quoted 1 line · Paul Eggleton

CVE-2014-9293, CVE-2014-9294, CVE-2014-9295, and CVE-2014-9296

#3 lore raw
In reply to Paul Eggleton

Merged, thanks Paul.
-J.

Quoted 39 lines · [[oe] [meta-networking][PATCH 0/1] ntp upgrade (including security fixes)] On…

The following change since commit edcf03b5fb576dbeae3784471aec8c2b7a9a04a8:

eggdbus: port from openembedded. (2014-12-17 13:11:57 +0100)

is available in the git repository at:

git://git.openembedded.org/meta-openembedded-contrib paule/ntp-upgrade
http://cgit.openembedded.org/cgit.cgi/meta-openembedded-contrib/log/?h=paule/ntp-upgrade

Paul Eggleton (1):
ntp: upgrade to 4.2.8

 .../recipes-support/ntp/files/CVE-2013-5211.patch  | 112 --------------
 .../recipes-support/ntp/files/openssl-check.patch  |  59 --------
 .../recipes-support/ntp/files/tickadj.c.patch      |  32 ----
 .../ntp/{files => ntp}/ntp-4.2.4_p6-nano.patch     |   0
 .../ntp/ntp/ntp-4.2.8-ntp-keygen-no-openssl.patch  | 168 +++++++++++++++++++++
 .../recipes-support/ntp/{files => ntp}/ntp.conf    |   0
 .../recipes-support/ntp/{files => ntp}/ntpd        |   0
 .../recipes-support/ntp/{files => ntp}/ntpdate     |   0
 .../ntp/{files => ntp}/ntpdate.default             |   0
 meta-networking/recipes-support/ntp/ntp_4.2.6p5.bb |   6 -
 .../recipes-support/ntp/{ntp.inc => ntp_4.2.8.bb}  |  41 ++---
 11 files changed, 191 insertions(+), 227 deletions(-)
 delete mode 100644 meta-networking/recipes-support/ntp/files/CVE-2013-5211.patch
 delete mode 100644 meta-networking/recipes-support/ntp/files/openssl-check.patch
 delete mode 100644 meta-networking/recipes-support/ntp/files/tickadj.c.patch
 rename meta-networking/recipes-support/ntp/{files => ntp}/ntp-4.2.4_p6-nano.patch (100%)
 create mode 100644 meta-networking/recipes-support/ntp/ntp/ntp-4.2.8-ntp-keygen-no-openssl.patch
 rename meta-networking/recipes-support/ntp/{files => ntp}/ntp.conf (100%)
 rename meta-networking/recipes-support/ntp/{files => ntp}/ntpd (100%)
 rename meta-networking/recipes-support/ntp/{files => ntp}/ntpdate (100%)
 rename meta-networking/recipes-support/ntp/{files => ntp}/ntpdate.default (100%)
 delete mode 100644 meta-networking/recipes-support/ntp/ntp_4.2.6p5.bb
 rename meta-networking/recipes-support/ntp/{ntp.inc => ntp_4.2.8.bb} (81%)
Signature · 1 line
1.9.3
Signature · 2 lines
-Joe MacDonald.
:wq