ASoC: fsl_esai: Use dev_name() for registering the irq

From: Fabio Estevam <[email protected]>

The 'name' array is currently stored inside the fsl_esai private structure only for registering the interrupt name.

This can be simplified by registering it with dev_name() instead.

Signed-off-by Fabio Estevam <[email protected]>

---
 sound/soc/fsl/fsl_esai.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

sound/soc/fsl/fsl_esai.c +1 -4

index 1c08ab1..dbe9204 100644
@@ -44,7 +44,6 @@
  * @sck_div: if using PSR/PM dividers for SCKx clock
  * @slave_mode: if fully using DAI slave mode
  * @synchronous: if using tx/rx synchronous mode
- * @name: driver name
  */
 struct fsl_esai {
 	struct snd_dmaengine_dai_dma_data dma_params_rx;

@@ -63,7 +62,6 @@ struct fsl_esai {
 	bool sck_div[2];
 	bool slave_mode;
 	bool synchronous;
-	char name[32];
 };
 
 static irqreturn_t esai_isr(int irq, void *devid)

@@ -739,7 +737,6 @@ static int fsl_esai_probe(struct platform_device *pdev)
 		return -ENOMEM;
 
 	esai_priv->pdev = pdev;
-	strncpy(esai_priv->name, np->name, sizeof(esai_priv->name) - 1);
 
 	/* Get the addresses and IRQ */
 	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);

@@ -779,7 +776,7 @@ static int fsl_esai_probe(struct platform_device *pdev)
 	}
 
 	ret = devm_request_irq(&pdev->dev, irq, esai_isr, 0,
-			       esai_priv->name, esai_priv);
+			       dev_name(&pdev->dev), esai_priv);
 	if (ret) {
 		dev_err(&pdev->dev, "failed to claim irq %u\n", irq);
 		return ret;

Signature · 1 line

1.9.1

Quoted 7 lines · Fabio Estevam

From: Fabio Estevam <[email protected]>

The 'name' array is currently stored inside the fsl_esai private structure only for registering the interrupt name.

This can be simplified by registering it with dev_name() instead.

Quoted 1 line

Signed-off-by Fabio Estevam <[email protected]>

Acked-by Nicolin Chen <[email protected]>

The name from dev_name() is a little different but doesn't matter. The code looks neater now. I think we may also apply similar ones to other drivers as well -- ASRC, SPDIF, etc. Would you like to send the patches? Otherwise, I can do this instead :)

From: Fabio Estevam <[email protected]>

The 'name' array is currently stored inside the fsl_esai private structure only for registering the interrupt name.