Skip to contentSkip to conversation

crypto: omap-des: fix BUG_ON condition

PATCH Applied Asaf Vertz 2 participants 2 messages Jan 5, 2015 – Jan 8, 2015 Crypto API

lore
Share & tools
lore

Asaf Vertz

author
#0 lore raw

PATCH 1/1 crypto: omap-des: fix BUG_ON condition

dd->total is unsigned so it won't do any good to check for negative value after subtracting instead of that we should check if the subtracted value is bigger than him

This was partially found by using a static code analysis program called cppcheck.

Signed-off-by Asaf Vertz <[email protected]>
---
 drivers/crypto/omap-des.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
drivers/crypto/omap-des.c +2 -2
index e350f5b..0b8dcf5 100644
@@ -965,9 +965,9 @@ static irqreturn_t omap_des_irq(int irq, void *dev_id)
 			}
 		}
 
-		dd->total -= DES_BLOCK_SIZE;
+		BUG_ON(dd->total < DES_BLOCK_SIZE);
 
-		BUG_ON(dd->total < 0);
+		dd->total -= DES_BLOCK_SIZE;
 
 		/* Clear IRQ status */
 		status &= ~DES_REG_IRQ_DATA_OUT;
Signature · 1 line
1.7.0.4
maintainer Applied
#1 lore raw
Quoted 6 lines · Asaf Vertz

dd->total is unsigned so it won't do any good to check for negative value after subtracting instead of that we should check if the subtracted value is bigger than him

This was partially found by using a static code analysis program called cppcheck.

Signed-off-by Asaf Vertz <[email protected]>

Applied.

Signature · 3 lines
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt