Skip to contentSkip to conversation

ARM: dts: sun6i: ippo-q8h-v5: Fix serial0 alias

PATCH New Hans de Goede 2 participants 3 messages Dec 25, 2014 – Jan 6, 2015

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ARM: dts: sun6i: ippo-q8h-v5: Fix serial0 alias

Hi Maxime, ChenYu,

The Ippo q8h has its serial console connected to the r-uart. Adjust the serial0 alias to match.

This fixes the kernel serial console no longer working since 3.19-rc1, because 8250_dw.c now honors dt aliases, causing the serial console to be ttyS5 rather then being ttyS0, as it was in 3.18 and before.

Note that adjusting bootargs instead is not an acceptable fix, because console=ttyS0,115200 is used by a lot of bootscripts, etc. and this should continue to work.

Maxime, can you please queue this up as a fix for 3.19 ?

Regards,

Hans

#1 lore raw

PATCH 1/1 ARM: dts: sun6i: ippo-q8h-v5: Fix serial0 alias

The Ippo q8h has its serial console connected to the r-uart. Adjust the serial0 alias to match.

This fixes the kernel serial console no longer working since 3.19-rc1, because 8250_dw.c now honors dt aliases, causing the serial console to be ttyS5 rather then being ttyS0, as it was in 3.18 and before.

Note that adjusting bootargs instead is not an acceptable fix, because console=ttyS0,115200 is used by a lot of bootscripts, etc. and this should continue to work.

---
 arch/arm/boot/dts/sun8i-a23-ippo-q8h-v5.dts | 4 ++++
 1 file changed, 4 insertions(+)
arch/arm/boot/dts/sun8i-a23-ippo-q8h-v5.dts +4 -0
index 7f2117c..32ad808 100644
@@ -55,6 +55,10 @@
 	model = "Ippo Q8H Dual Core Tablet (v5)";
 	compatible = "ippo,q8h-v5", "allwinner,sun8i-a23";
 
+	aliases {
+		serial0 = &r_uart;
+	};
+
 	chosen {
 		bootargs = "earlyprintk console=ttyS0,115200";
 	};
Signature · 1 line
2.1.0
#2 lore raw

PATCH 1/1 ARM: dts: sun6i: ippo-q8h-v5: Fix serial0 alias

Quoted 7 lines · Hans de Goede

The Ippo q8h has its serial console connected to the r-uart. Adjust the serial0 alias to match.

This fixes the kernel serial console no longer working since 3.19-rc1, because 8250_dw.c now honors dt aliases, causing the serial console to be ttyS5 rather then being ttyS0, as it was in 3.18 and before.

Quoted 5 lines

Note that adjusting bootargs instead is not an acceptable fix, because console=ttyS0,115200 is used by a lot of bootscripts, etc. and this should continue to work.

Applied, thanks!

Maxime

Signature · 10 lines
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20150106/5f4fad5a/attachment.sig>