Skip to contentSkip to conversation

ARM: dts: imx6dl-udoo: Add board support based off imx6q-udoo

PATCH New Robert Nelson 3 participants 4 messages Dec 22, 2014 – Jan 6, 2015

Subsystems (3)
Device tree bindings Arm i.MX and Layerscape Arm and arm64 SoC sub-architectures (common parts)
lore
Share & tools
lore

Robert Nelson

author
#0 lore raw

PATCH 1/1 ARM: dts: imx6dl-udoo: Add board support based off imx6q-udoo

For more information about the Udoo boards:
http://www.udoo.org/

Signed-off-by Robert Nelson <[email protected]>
CC Fabio Estevam <[email protected]>
---
 arch/arm/boot/dts/Makefile          |   1 +
 arch/arm/boot/dts/imx6dl-udoo.dts   |  18 +++++
 arch/arm/boot/dts/imx6q-udoo.dts    | 124 +--------------------------------
 arch/arm/boot/dts/imx6qdl-udoo.dtsi | 134 ++++++++++++++++++++++++++++++++++++
 4 files changed, 154 insertions(+), 123 deletions(-)
 create mode 100644 arch/arm/boot/dts/imx6dl-udoo.dts
 create mode 100644 arch/arm/boot/dts/imx6qdl-udoo.dtsi
arch/arm/boot/dts/Makefile +1 -0
index 91bd5bd..6a6ecdb 100644
@@ -234,6 +234,7 @@ dtb-$(CONFIG_ARCH_MXC) += \
 	imx6dl-tx6dl-comtft.dtb \
 	imx6dl-tx6u-801x.dtb \
 	imx6dl-tx6u-811x.dtb \
+	imx6dl-udoo.dtb \
 	imx6dl-wandboard.dtb \
 	imx6dl-wandboard-revb1.dtb \
 	imx6q-arm2.dtb \
arch/arm/boot/dts/imx6dl-udoo.dts new file +18 -0
new file mode 100644
index 0000000..a4d2ef2
@@ -0,0 +1,18 @@
+/*
+ * Copyright 2013 Freescale Semiconductor, Inc.
+ *
+ * Author: Fabio Estevam <[email protected]>
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 2 as
+ * published by the Free Software Foundation.
+ *
+ */
+/dts-v1/;
+#include "imx6dl.dtsi"
+#include "imx6qdl-udoo.dtsi"
+
+/ {
+	model = "Udoo i.MX6 Dual Board";
+	compatible = "udoo,imx6dl-udoo", "fsl,imx6dl";
+};
arch/arm/boot/dts/imx6q-udoo.dts +1 -123

138 lines not on this page · raw message

arch/arm/boot/dts/imx6qdl-udoo.dtsi new file +134 -0

134 lines not on this page · raw message

Signature · 1 line
2.1.3
reviewer
#1 lore raw

PATCH 1/1 ARM: dts: imx6dl-udoo: Add board support based off imx6q-udoo

arch/arm/boot/dts/imx6dl-udoo.dts line 16

Quoted 6 lines · Robert Nelson
arch/arm/boot/dts/imx6dl-udoo.dts new file +6 -0
+/dts-v1/;
+#include "imx6dl.dtsi"
+#include "imx6qdl-udoo.dtsi"
+
+/ {
+       model = "Udoo i.MX6 Dual Board";

It would be better to use "Udoo i.MX6 Dual-lite Board" in order to avoid confusion with the i.MX6 Dual variant.

Other than that:

Reviewed-by Fabio Estevam <[email protected]>
author
#2 lore raw

PATCH 1/1 ARM: dts: imx6dl-udoo: Add board support based off imx6q-udoo

Quoted 12 lines · Fabio Estevam

arch/arm/boot/dts/imx6dl-udoo.dts line 16

Quoted 6 lines · Robert Nelson
arch/arm/boot/dts/imx6dl-udoo.dts new file +6 -0
+/dts-v1/;
+#include "imx6dl.dtsi"
+#include "imx6qdl-udoo.dtsi"
+
+/ {
+       model = "Udoo i.MX6 Dual Board";

It would be better to use "Udoo i.MX6 Dual-lite Board" in order to avoid confusion with the i.MX6 Dual variant.

Quoted 3 lines

Other than that:

Reviewed-by Fabio Estevam <[email protected]>

True! That would correctly match the other dual-lite boards on mainline too.

Shawn, if you want me to respin the patch i will, otherwise can you tweak that line?

Regards,

Signature · 2 lines
Robert Nelson
http://www.rcn-ee.com/
#3 lore raw

PATCH 1/1 ARM: dts: imx6dl-udoo: Add board support based off imx6q-udoo

Quoted 13 lines · Robert Nelson
Quoted 12 lines · Fabio Estevam

arch/arm/boot/dts/imx6dl-udoo.dts line 16

Quoted 6 lines · Robert Nelson
arch/arm/boot/dts/imx6dl-udoo.dts new file +6 -0
+/dts-v1/;
+#include "imx6dl.dtsi"
+#include "imx6qdl-udoo.dtsi"
+
+/ {
+       model = "Udoo i.MX6 Dual Board";

It would be better to use "Udoo i.MX6 Dual-lite Board" in order to avoid confusion with the i.MX6 Dual variant.

Quoted 8 lines
Quoted 3 lines

Other than that:

Reviewed-by Fabio Estevam <[email protected]>

True! That would correctly match the other dual-lite boards on mainline too.

Shawn, if you want me to respin the patch i will, otherwise can you tweak that line?

Fixed it up and applied.