ARM: DRA7: beagle-x15: hwmod: Fix boot crash with DEBUG_LL
Subsystems (4)
PATCH 1/1 ARM: DRA7: beagle-x15: hwmod: Fix boot crash with DEBUG_LL
With commit '7dedd34: ARM: OMAP2+: hwmod: Fix a crash in _setup_reset() with DEBUG_LL' we moved from parsing cmdline to identify uart used for earlycon to using the requsite hwmod CONFIG_DEBUG_OMAPxUARTy FLAGS.
On beagle-x15, we use uart3 for console and missed enabling this flag for uart3 hwmod, so boot fails with DEBUG_LL. Enable DEBUG_OMAP4UART3_FLAGS for uart3 hwmod.
For using DEBUG_LL, enable CONFIG_DEBUG_OMAP4UART3 in menuconfig.
--- arch/arm/mach-omap2/omap_hwmod_7xx_data.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/mach-omap2/omap_hwmod_7xx_data.c +1 -1
@@ -2017,7 +2017,7 @@ static struct omap_hwmod dra7xx_uart3_hwmod = { .class = &dra7xx_uart_hwmod_class, .clkdm_name = "l4per_clkdm", .main_clk = "uart3_gfclk_mux", - .flags = HWMOD_SWSUP_SIDLE_ACT, + .flags = HWMOD_SWSUP_SIDLE_ACT | DEBUG_OMAP4UART3_FLAGS, .prcm = { .omap4 = { .clkctrl_offs = DRA7XX_CM_L4PER_UART3_CLKCTRL_OFFSET,
Signature · 1 line
1.9.1
PATCH 1/1 ARM: DRA7: beagle-x15: hwmod: Fix boot crash with DEBUG_LL
$subject should probably need a cleanup: this is hwmod support for DEBUG_LL on UART3 - x15 happens to be one of the platforms that uses that, but not the only one.. I suggest removing x15 from $subject and rephrasing accordingly.
Quoted 5 lines · Lokesh Vutla
With commit '7dedd34: ARM: OMAP2+: hwmod: Fix a crash in
_setup_reset()withDEBUG_LL' we moved from parsing cmdline to identify uart used for earlycon to using the requsite hwmodCONFIG_DEBUG_OMAPxUARTyFLAGS.On beagle-x15, we use uart3 for console and missed enabling this flag
Official name of the platform is BeagleBoard-X15
Quoted 2 lines
for uart3 hwmod, so boot fails with
DEBUG_LL. EnableDEBUG_OMAP4UART3_FLAGSfor uart3 hwmod.
Could you align your commit message to 70 chars if possible?
Quoted 4 lines
For using
DEBUG_LL, enableCONFIG_DEBUG_OMAP4UART3in menuconfig.Fixes 90020c7 (ARM: OMAP: DRA7: hwmod: Create initial DRA7XX SoC data)
Quoted 24 lines
Cc <[email protected]> # v3.12+Reviewed-by Felipe Balbi <[email protected]>Acked-by Felipe Balbi <[email protected]>Signed-off-by Lokesh Vutla <[email protected]>--- arch/arm/mach-omap2/omap_hwmod_7xx_data.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)arch/arm/mach-omap2/omap_hwmod_7xx_data.c +1
-1@@ -2017,7 +2017,7 @@ static struct omap_hwmod dra7xx_uart3_hwmod = { .class = &dra7xx_uart_hwmod_class, .clkdm_name = "l4per_clkdm", .main_clk = "uart3_gfclk_mux", - .flags = HWMOD_SWSUP_SIDLE_ACT, + .flags = HWMOD_SWSUP_SIDLE_ACT | DEBUG_OMAP4UART3_FLAGS, .prcm = { .omap4 = { .clkctrl_offs = DRA7XX_CM_L4PER_UART3_CLKCTRL_OFFSET,Signature · 1 line
1.9.1
Signature · 2 lines
Regards, Nishanth Menon
PATCH 1/1 ARM: DRA7: beagle-x15: hwmod: Fix boot crash with DEBUG_LL
Quoted 5 lines · Nishanth Menon
Quoted 3 lines
For using
DEBUG_LL, enableCONFIG_DEBUG_OMAP4UART3in menuconfig.Fixes 90020c7 (ARM: OMAP: DRA7: hwmod: Create initial DRA7XX SoC data)Fixes 90020c7b2c5e ("ARM: OMAP: DRA7: hwmod: Create initial DRA7XX SoC data")
what's the difference ? why do you want that many more characters if those 7 are enough for git to find a uniq commit ? Try this:
$ git show --abbrev-commit 90020c7b2c5e02200bc752c8cfeba91c4435588c
Signature · 8 lines
balbi -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 819 bytes Desc: Digital signature URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20150106/61afa5b0/attachment.sig>
PATCH 1/1 ARM: DRA7: beagle-x15: hwmod: Fix boot crash with DEBUG_LL
Quoted 12 lines · Felipe Balbi
Quoted 5 lines · Nishanth Menon
Quoted 3 lines
For using
DEBUG_LL, enableCONFIG_DEBUG_OMAP4UART3in menuconfig.Fixes 90020c7 (ARM: OMAP: DRA7: hwmod: Create initial DRA7XX SoC data)Fixes 90020c7b2c5e ("ARM: OMAP: DRA7: hwmod: Create initial DRA7XX SoC data")what's the difference ? why do you want that many more characters if those 7 are enough for git to find a uniq commit ? Try this:
$ git show --abbrev-commit 90020c7b2c5e02200bc752c8cfeba91c4435588c
Signature · 2 lines
Regards, Nishanth Menon
PATCH 1/1 ARM: DRA7: beagle-x15: hwmod: Fix boot crash with DEBUG_LL
Hi,
Quoted 6 lines · Nishanth Menon
Quoted 5 lines · Felipe Balbi
Quoted 4 lines · Nishanth Menon
Quoted 3 lines
For using
DEBUG_LL, enableCONFIG_DEBUG_OMAP4UART3in menuconfig.Fixes 90020c7 (ARM: OMAP: DRA7: hwmod: Create initial DRA7XX SoC data)
Quoted 8 lines
Quoted 7 lines
Quoted 1 line
Fixes 90020c7b2c5e ("ARM: OMAP: DRA7: hwmod: Create initial DRA7XX SoC data")what's the difference ? why do you want that many more characters if those 7 are enough for git to find a uniq commit ? Try this:
$ git show --abbrev-commit 90020c7b2c5e02200bc752c8cfeba91c4435588c
alright, if it's Documented, it's best done ;-)
Signature · 8 lines
balbi -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 819 bytes Desc: Digital signature URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20150106/ead50429/attachment.sig>