Skip to contentSkip to conversation

wireless extensions should default to Y

PATCH In review Pavel Machek 2 participants 4 messages Jan 7, 2015

Subsystems (3)
Networking Network drivers 802.11 (including cfg80211/NL80211)
lore
Share & tools
lore

Pavel Machek

author
#0 lore raw

PATCH 1/1 wireless extensions should default to Y

Do we need following patch on top of
24a0aa212ee2dbe44360288684478d76a8e20a0a revert?

I updated kernel today, and (probably because extensions were not selectable before), the default choice was "N", which is wrong:
oldconfig should result in compatible choices being made, for example to help bisect.

Signed-off-by Pavel Machek <[email protected]>
net/wireless/Kconfig +1 -0
index 29c8675..8951dba 100644
@@ -177,6 +177,7 @@ config CFG80211_INTERNAL_REGDB
 config CFG80211_WEXT
 	bool "cfg80211 wireless extensions compatibility"
 	depends on CFG80211
+	default y
 	select WEXT_CORE
 	help
 	  Enable this option if you need old userspace for wireless
Signature · 2 lines
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
maintainer
#1 lore raw
Quoted 7 lines · Pavel Machek

Do we need following patch on top of
24a0aa212ee2dbe44360288684478d76a8e20a0a revert?

I updated kernel today, and (probably because extensions were not selectable before), the default choice was "N", which is wrong:
oldconfig should result in compatible choices being made, for example to help bisect.

I don't believe we need this. It has been defaulting to N for a long time, it's just that it got thrown out of your config due to building inbetween the patch and its revert. Had you built only before and after that wouldn't be an issue.

If we default to Y now we send the wrong signal. If you really need to bisect something wext related you have far bigger issues I'd think, the code hasn't changed *forever*.

johannes

--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html

author
#2 lore raw
Quoted 9 lines · Johannes Berg
Quoted 7 lines · Pavel Machek

Do we need following patch on top of
24a0aa212ee2dbe44360288684478d76a8e20a0a revert?

I updated kernel today, and (probably because extensions were not selectable before), the default choice was "N", which is wrong:
oldconfig should result in compatible choices being made, for example to help bisect.

Quoted 4 lines

I don't believe we need this. It has been defaulting to N for a long time, it's just that it got thrown out of your config due to building inbetween the patch and its revert. Had you built only before and after that wouldn't be an issue.

Well, I clearly hit the issue. If someone had _not_ build in between, the "default y" does not change anything for him, as he will not be asked thequestion. If someone starts config from scratch, Y is the safe answer.

Quoted 3 lines

If we default to Y now we send the wrong signal. If you really need to bisect something wext related you have far bigger issues I'd think, the code hasn't changed *forever*.

I am woried about bisecting something unrelated, and then wext coming and breaking the bisect. But you are right that it will break the bisect, anyway...

Pavel

Signature · 2 lines
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
maintainer
#3 lore raw
Quoted 15 lines · Pavel Machek
Quoted 9 lines · Johannes Berg
Quoted 7 lines · Pavel Machek

Do we need following patch on top of
24a0aa212ee2dbe44360288684478d76a8e20a0a revert?

I updated kernel today, and (probably because extensions were not selectable before), the default choice was "N", which is wrong:
oldconfig should result in compatible choices being made, for example to help bisect.

Quoted 4 lines

I don't believe we need this. It has been defaulting to N for a long time, it's just that it got thrown out of your config due to building inbetween the patch and its revert. Had you built only before and after that wouldn't be an issue.

Quoted 4 lines

Well, I clearly hit the issue. If someone had _not_ build in between, the "default y" does not change anything for him, as he will not be asked thequestion. If someone starts config from scratch, Y is the safe answer.

We've long stated that if really starting from scratch it's the wrong thing to do and had a default N, so I don't really know why we'd revert that only to make a short period of bisect slightly happier?

I really don't want to merge this patch and encourage more people to build with wext enabled.

johannes

--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html