Skip to contentSkip to conversation

glibc: add debug symbols when BR2_ENABLE_DEBUG

PATCH New Baruch Siach 2 participants 4 messages Jan 1, 2015 – Jan 7, 2015

lore
Share & tools
lore

Baruch Siach

author
#0 lore raw

PATCH 1/1 glibc: add debug symbols when BR2_ENABLE_DEBUG

Signed-off-by Baruch Siach <[email protected]>
---
 package/glibc/glibc.mk | 4 ++++
 1 file changed, 4 insertions(+)
package/glibc/glibc.mk +4 -0
index 65f4ed3b0d97..0a37bb361a07 100644
@@ -47,6 +47,10 @@ else ifeq ($(BR2_MIPS_OABI32),y)
 GLIBC_EXTRA_CFLAGS += -mabi=32
 endif
 
+ifeq ($(BR2_ENABLE_DEBUG),y)
+GLIBC_EXTRA_CFLAGS += -g
+endif
+
 # The stubs.h header is not installed by install-headers, but is
 # needed for the gcc build. An empty stubs.h will work, as explained
 # in http://gcc.gnu.org/ml/gcc/2002-01/msg00900.html. The same trick
Signature · 1 line
2.1.4
#1 lore raw

PATCH 1/1 glibc: add debug symbols when BR2_ENABLE_DEBUG

Dear Baruch Siach,

Quoted 4 lines · Baruch Siach
Signed-off-by Baruch Siach <[email protected]>
---
 package/glibc/glibc.mk | 4 ++++
 1 file changed, 4 insertions(+)

Thanks!

Do you know if there's an easy way of checking if ELF binaries have debugging symbols? If so, we could add a check to verify that all ELF binaries have debugging symbols when BR2_ENABLE_DEBUG=y, and add this check in the autobuilders.

Best regards,

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
author
#2 lore raw

PATCH 1/1 glibc: add debug symbols when BR2_ENABLE_DEBUG

Hi Thomas,

Quoted 6 lines · Thomas Petazzoni
Quoted 4 lines · Baruch Siach
Signed-off-by Baruch Siach <[email protected]>
---
 package/glibc/glibc.mk | 4 ++++
 1 file changed, 4 insertions(+)
Quoted 6 lines

Thanks!

Do you know if there's an easy way of checking if ELF binaries have debugging symbols? If so, we could add a check to verify that all ELF binaries have debugging symbols when BR2_ENABLE_DEBUG=y, and add this check in the autobuilders.

I guess looking for '.debug_info' in the output of 'objdump -h' or 'readelf -S' should be enough.

baruch

Signature · 3 lines
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -
Applied
#3 lore raw

PATCH 1/1 glibc: add debug symbols when BR2_ENABLE_DEBUG

In reply to Baruch Siach

Dear Baruch Siach,

Quoted 4 lines · Baruch Siach
Signed-off-by Baruch Siach <[email protected]>
---
 package/glibc/glibc.mk | 4 ++++
 1 file changed, 4 insertions(+)

Applied, thanks!

Maybe we should also take care of the same thing in uClibc? musl is OK, we use $(TARGET_CFLAGS).

Thanks,

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com