ARM: Conexant Digicolor CX92755 SoC support

cx92755.dtsi describes CX92755 on chip peripherals. conexant_equinox.dts describes the Equinox evaluation board for the CX92755 SoC.

Signed-off-by Baruch Siach <[email protected]>

---
 arch/arm/boot/dts/Makefile             |   1 +
 arch/arm/boot/dts/conexant_equinox.dts |  67 +++++++++++++++++++++
 arch/arm/boot/dts/cx92755.dtsi         | 103 +++++++++++++++++++++++++++++++++
 3 files changed, 171 insertions(+)
 create mode 100644 arch/arm/boot/dts/conexant_equinox.dts
 create mode 100644 arch/arm/boot/dts/cx92755.dtsi

arch/arm/boot/dts/Makefile +1 -0

index 91bd5bd62857..fbeb65eaddda 100644
@@ -75,6 +75,7 @@ dtb-$(CONFIG_ARCH_BRCMSTB) += \
 	bcm7445-bcm97445svmb.dtb
 dtb-$(CONFIG_ARCH_DAVINCI) += da850-enbw-cmc.dtb \
 	da850-evm.dtb
+dtb-$(CONFIG_ARCH_DIGICOLOR) += conexant_equinox.dtb
 dtb-$(CONFIG_ARCH_EFM32) += efm32gg-dk3750.dtb
 dtb-$(CONFIG_ARCH_EXYNOS) += exynos3250-monk.dtb \
 	exynos3250-rinato.dtb \

arch/arm/boot/dts/conexant_equinox.dts new file +67 -0

new file mode 100644
index 000000000000..b2917d914740
@@ -0,0 +1,67 @@
+/*
+ * Device Tree file for the Conexant Equinox CX92755 EVK
+ *
+ * Author: Baruch Siach <[email protected]>
+ *
+ *  Copyright (C) 2014 Paradox Innovation Ltd.
+ *
+ * This file is dual-licensed: you can use it either under the terms
+ * of the GPL or the X11 license, at your option. Note that this dual
+ * licensing only applies to this file, and not this project as a
+ * whole.
+ *
+ *  a) This file is free software; you can redistribute it and/or
+ *     modify it under the terms of the GNU General Public License as
+ *     published by the Free Software Foundation; either version 2 of the
+ *     License, or (at your option) any later version.
+ *
+ *     This file is distributed in the hope that it will be useful,
+ *     but WITHOUT ANY WARRANTY; without even the implied warranty of
+ *     MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ *     GNU General Public License for more details.
+ *
+ * Or, alternatively,
+ *
+ *  b) Permission is hereby granted, free of charge, to any person
+ *     obtaining a copy of this software and associated documentation
+ *     files (the "Software"), to deal in the Software without
+ *     restriction, including without limitation the rights to use,
+ *     copy, modify, merge, publish, distribute, sublicense, and/or
+ *     sell copies of the Software, and to permit persons to whom the
+ *     Software is furnished to do so, subject to the following
+ *     conditions:
+ *
+ *     The above copyright notice and this permission notice shall be
+ *     included in all copies or substantial portions of the Software.
+ *
+ *     THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
+ *     EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES
+ *     OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
+ *     NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT
+ *     HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY,
+ *     WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
+ *     FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
+ *     OTHER DEALINGS IN THE SOFTWARE.
+ */
+
+/dts-v1/;
+
+#include "cx92755.dtsi"
+
+/ {
+	model = "Conexant Equinox CX92755 EVK";
+	compatible = "cnxt,equinox", "cnxt,cx92755";
+
+	memory at 0 {
+		reg = <0 0x8000000>;
+		device_type = "memory";
+	};
+
+	chosen {
+		bootargs = "console=ttyS0,115200 earlyprintk";
+	};
+};
+
+&uart0 {
+	status = "okay";
+};

arch/arm/boot/dts/cx92755.dtsi new file +103 -0

new file mode 100644
index 000000000000..4088e8974b4b
@@ -0,0 +1,103 @@
+/*
+ * Device Tree Include file for the Conexant Digicolor CX92755 SoC
+ *
+ * Author: Baruch Siach <[email protected]>
+ *
+ *  Copyright (C) 2014 Paradox Innovation Ltd.
+ *
+ * This file is dual-licensed: you can use it either under the terms
+ * of the GPL or the X11 license, at your option. Note that this dual
+ * licensing only applies to this file, and not this project as a
+ * whole.
+ *
+ *  a) This file is free software; you can redistribute it and/or
+ *     modify it under the terms of the GNU General Public License as
+ *     published by the Free Software Foundation; either version 2 of the
+ *     License, or (at your option) any later version.
+ *
+ *     This file is distributed in the hope that it will be useful,
+ *     but WITHOUT ANY WARRANTY; without even the implied warranty of
+ *     MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ *     GNU General Public License for more details.
+ *
+ * Or, alternatively,
+ *
+ *  b) Permission is hereby granted, free of charge, to any person
+ *     obtaining a copy of this software and associated documentation
+ *     files (the "Software"), to deal in the Software without
+ *     restriction, including without limitation the rights to use,
+ *     copy, modify, merge, publish, distribute, sublicense, and/or
+ *     sell copies of the Software, and to permit persons to whom the
+ *     Software is furnished to do so, subject to the following
+ *     conditions:
+ *
+ *     The above copyright notice and this permission notice shall be
+ *     included in all copies or substantial portions of the Software.
+ *
+ *     THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
+ *     EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES
+ *     OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
+ *     NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT
+ *     HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY,
+ *     WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
+ *     FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
+ *     OTHER DEALINGS IN THE SOFTWARE.
+ */
+
+#include "skeleton.dtsi"
+
+/ {
+	compatible = "cnxt,cx92755";
+
+	interrupt-parent = <&intc>;
+
+	aliases {
+		serial0 = &uart0;
+		serial1 = &uart1;
+		serial2 = &uart2;
+	};
+
+	main_clk: main_clk {
+		compatible = "fixed-clock";
+		#clock-cells = <0>;
+		clock-frequency  = <200000000>;
+	};
+
+	intc: intc at f0000000 {
+		compatible = "cnxt,cx92755-ic";
+		interrupt-controller;
+		#interrupt-cells = <1>;
+		reg = <0xf0000000 0x1000>;
+	};
+
+	timer at f0000fc0 {
+		compatible = "cnxt,cx92755-timer";
+		reg = <0xf0000fc0 0x40>;
+		interrupts = <19>, <31>, <34>, <35>, <52>, <53>, <54>, <55>;
+		clocks = <&main_clk>;
+	};
+
+	uart0: uart at f0000740 {
+		compatible = "cnxt,cx92755-usart";
+		reg = <0xf0000740 0x20>;
+		clocks = <&main_clk>;
+		interrupts = <44>;
+		status = "disabled";
+	};
+
+	uart1: uart at f0000760 {
+		compatible = "cnxt,cx92755-usart";
+		reg = <0xf0000760 0x20>;
+		clocks = <&main_clk>;
+		interrupts = <45>;
+		status = "disabled";
+	};
+
+	uart2: uart at f0000780 {
+		compatible = "cnxt,cx92755-usart";
+		reg = <0xf0000780 0x20>;
+		clocks = <&main_clk>;
+		interrupts = <46>;
+		status = "disabled";
+	};
+};

Signature · 1 line

2.1.4

Quoted 2 lines · Baruch Siach

cx92755.dtsi describes CX92755 on chip peripherals. conexant_equinox.dts describes the Equinox evaluation board for the CX92755 SoC.

I didn't spot any cpu nodes below. While that might happen to work at the moment for UP, there really should be a node for the boot CPU.

Signed-off-by Baruch Siach <[email protected]>

---
 .../bindings/interrupt-controller/digicolor-ic.txt   | 20 ++++++++++++++++++++
 1 file changed, 20 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/interrupt-controller/digicolor-ic.txt

Documentation/devicetree/bindings/interrupt-controller/digicolor-ic.txt new file +0 -0

new file mode 100644
index 000000000000..fdf9a4c59bf3

Documentation/devicetree/bindings/interrupt-controller/digicolor-ic.txt new file +10 -0

+
+Example:
+
+	intc: intc at f0000000 {
+		compatible = "cnxt,cx92755-ic";
+		interrupt-controller;
+		#interrupt-cells = <1>;
+		reg = <0xf0000000 0x1000>;
+	};
+

Signature · 1 line

2.1.4

Quoted 6 lines · Baruch Siach

Signed-off-by Baruch Siach <[email protected]>

---
 .../bindings/interrupt-controller/digicolor-ic.txt   | 20 ++++++++++++++++++++
 1 file changed, 20 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/interrupt-controller/digicolor-ic.txt

Documentation/devicetree/bindings/interrupt-controller/digicolor-ic.txt line 5

Quoted 11 lines

Documentation/devicetree/bindings/interrupt-controller/digicolor-ic.txt new file +5 -0

new file mode 100644
index 000000000000..fdf9a4c59bf3
@@ -0,0 +1,20 @@
+Conexant Digicolor Interrupt Controller
+
+Required properties:
+
+- compatible : should be "cnxt,cx92755-ic"

I didn't spot "cnxt" in Documentation/devicetree/bindings/vendor-prefixes.txt in mainline, nor did I spot it added as part of this series. Please add it, assuming a patch doing so is not already queued elsewhere.

Documentation/devicetree/bindings/interrupt-controller/digicolor-ic.txt line 7

Quoted 2 lines

Documentation/devicetree/bindings/interrupt-controller/digicolor-ic.txt new file +2 -0

+- reg : Specifies base physical address and size of the MISC area, that is
+  where the interrupt controller registers are located

Is this area shared with other devices?

Documentation/devicetree/bindings/interrupt-controller/digicolor-ic.txt line 10

Quoted 3 lines

Documentation/devicetree/bindings/interrupt-controller/digicolor-ic.txt new file +3 -0

+- interrupt-controller : Identifies the node as an interrupt controller
+- #interrupt-cells : Specifies the number of cells needed to encode an
+  interrupt source. The value shall be 1.

There is no configuration that can be applied to individual interrupt lines (e.g. trigger type)?

Signed-off-by Baruch Siach <[email protected]>

---
  .../bindings/interrupt-controller/digicolor-ic.txt   | 20 ++++++++++++++++++++
  1 file changed, 20 insertions(+)

create mode 100644 Documentation/devicetree/bindings/interrupt-controller/digicolor-ic.txt

Documentation/devicetree/bindings/interrupt-controller/digicolor-ic.txt new file +4 -0

new file mode 100644
index 000000000000..fdf9a4c59bf3
@@ -0,0 +1,20 @@
+Conexant Digicolor Interrupt Controller
+
+Required properties:
+

Quoted 21 lines · Baruch Siach

Signed-off-by Baruch Siach <[email protected]>

---
 .../bindings/interrupt-controller/digicolor-ic.txt   | 20 ++++++++++++++++++++
 1 file changed, 20 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/interrupt-controller/digicolor-ic.txt

Documentation/devicetree/bindings/interrupt-controller/digicolor-ic.txt new file +9 -0

new file mode 100644
index 000000000000..fdf9a4c59bf3
@@ -0,0 +1,20 @@
+Conexant Digicolor Interrupt Controller
+
+Required properties:
+
+- compatible : should be "cnxt,cx92755-ic"
+- reg : Specifies base physical address and size of the MISC area, that is
+  where the interrupt controller registers are located
+- interrupt-controller : Identifies the node as an interrupt controller
+- #interrupt-cells : Specifies the number of cells needed to encode an

Documentation/devicetree/bindings/interrupt-controller/digicolor-ic.txt line 14

Quoted 5 lines

Documentation/devicetree/bindings/interrupt-controller/digicolor-ic.txt new file +5 -0

+  interrupt source. The value shall be 1.
+
+Example:
+
+	intc: intc at f0000000 {

The node name should be "interrupt-controller at f0000000", according to the
ePAPR standard, section 2.2.2.

This series adds initial support for the Conexant CX92755 SoC. The CX92755 is one of the Digicolor series of SoCs, all sharing many of the same peripherals. The code was tested on the CX92755 evaluation kit, AKA Equinox.

Uses attempting to try this code will most likely also want the UART/console driver available from https://patchwork.kernel.org/patch/5515861/.

Quoted 6 lines · On Thursday 08 January 2015 21:39:56 Baruch Siach wrote:

This series adds initial support for the Conexant CX92755 SoC. The CX92755 is one of the Digicolor series of SoCs, all sharing many of the same peripherals. The code was tested on the CX92755 evaluation kit, AKA Equinox.

Uses attempting to try this code will most likely also want the UART/console driver available from https://patchwork.kernel.org/patch/5515861/.

Looks great overall now.

I have just two more comments in one patch, and one general request:

Please add a patch description for every patch. The text above would be a good start for the first patch, but it would be lost in the git history if it's only in the cover letter.

other than that, feel free to add my

Acked-by Arnd Bergmann <[email protected]>

Once there are no more review comments, please submit the first three patches to arm at kernel.org, and send the other patches as separate series to the respective maintainers for irqchip and clocksource.

Quoted 3 lines

Once there are no more review comments, please submit the first three patches to arm at kernel.org, and send the other patches as separate series to the respective maintainers for irqchip and clocksource.

What about the last patch in this series (ARM: devicetree: document supported Conexant Digicolor SoC)? What tree should it go through.

Once there are no more review comments, please submit the first three patches to arm at kernel.org, and send the other patches as separate series to the respective maintainers for irqchip and clocksource.

Quoted 3 lines · Arnd Bergmann

Once there are no more review comments, please submit the first three patches to arm at kernel.org, and send the other patches as separate series to the respective maintainers for irqchip and clocksource.

I found this message while looking into CONFIG_ARCH_DIGICOLOR. That Kconfig macro entered linux-next in next-20150128. But there's no Kconfig symbol ARCH_DIGICOLOR yet in linux-next.

Quoted 5 lines · Paul Bolle

Quoted 3 lines · Arnd Bergmann

Once there are no more review comments, please submit the first three patches to arm at kernel.org, and send the other patches as separate series to the respective maintainers for irqchip and clocksource.

Quoted 3 lines

I found this message while looking into CONFIG_ARCH_DIGICOLOR. That Kconfig macro entered linux-next in next-20150128. But there's no Kconfig symbol ARCH_DIGICOLOR yet in linux-next.

Just for the record: base digicolor platform support is in the for-next branch of arm-soc.git since today. I guess it should appear in linux-next tomorrow.