Skip to contentSkip to conversation

Linux kernel module for Waveshare 3.2inch RPi LCD (B) V3 touch controller

PATCH New Peter Seiderer 2 participants 3 messages Jan 9, 2015

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Linux kernel module for Waveshare 3.2inch RPi LCD (B) V3 touch controller

Hello Thomas,

Quoted 25 lines

Gesendet: Donnerstag, 08. Januar 2015 um 21:24 Uhr
Von: "Thomas Petazzoni" <[email protected]>
An: "Peter Seiderer" <[email protected]>
Cc: buildroot at busybox.net
Betreff: Re: [Buildroot] [PATCH] Linux kernel module for Waveshare 3.2inch RPi LCD (B) V3 touch controller

Dear Peter Seiderer,

Quoted 6 lines · Peter Seiderer

This kernel module enables the (easy?) using of the ADS7846 SPI touch controller on Waveshare 3.2 LCD (B) modules.

Alternatives would be:
- the old way: add device definition/register call to arch/arm/mach-bcm2708/bcm2708.c
- the new way: use device tree support and add an entrie for ads7846

I'm sorry, this is not your fault, but this ads7846_device thing is an absolute abomination. Why is RaspberryPi *THE* platform propagating all the worst possible abominations? Why is it *THE* platform doing all the non-standard stuff? Why is it so crappy.

People, please read this: if you want to learn embedded Linux, don't buy Raspberry Pi. It is the worst platform ever in terms of embedded Linux development best practices. Ever.

Quoted 8 lines

Do yourself a favor, and buy properly supported stuff: the Atmel Xplained comes to mind, the BeagleBone Black as well of course.

Sorry, but this ads7846_device is just pure crap. The alternatives you mentioned are the only good solutions: change your board file if you're using an old style ARM kernel, or change your Device Tree if you're using a new style ARM kernel.

No strong opinion for this patch from my side, primary goal was to support Lou to get his waveshare32b running with buildroot...

The fbtft patch is more important (for me), because I use it myself for my adafruit28 display (with uses an ft6x06 touchscreen for which I added an old way arch/arm/mach-bcm2708/bcm2708.c board file patch)...

Maybe the way to go is to wait (or add?) for raspberry pi linux-3.18 kernel support in buildroot with device tree overlay support (see [1],[2])?

Quoted 3 lines

I don't know what the policy of Buildroot should be about accepting crap, but on my side, I will not add such a package to Buildroot.

Anyone with pro/con opinion?

Quoted 3 lines

Again: don't take this personally, this is absolutely not against you. Just me being fed up with Raspberry Pi crap.

No problem, was astonished too about the creative solutions (instead of prober solutions) found for raspberry pi ;-)

But are other manufacturers so much better, TI/Freescale like to fork kernel trees with proprietary extensions too (including closed source libraries)?

My decision for raspberry pi was because of support for (hopefully) good audio out (using the hifiberry dac, but not yet delivered)...

Regards,
Peter

[1] http://www.raspberrypi.org/documentation/configuration/pin-configuration.md
[2] http://www.raspberrypi.org/forums/viewtopic.php?f=29&t=93015

Quoted 8 lines

Best regards,

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
#1 lore raw

PATCH 1/1 Linux kernel module for Waveshare 3.2inch RPi LCD (B) V3 touch controller

Peter, All,

On 2015-01-09 21:21 +0100, Peter Seiderer spake thusly:
[--SNIP--]

Quoted 2 lines

Maybe the way to go is to wait (or add?) for raspberry pi linux-3.18 kernel support in buildroot with device tree overlay support (see [1],[2])?

I'm working on it, and should be able to submit it shortly. You can see the previous attempt in that thread:

    http://lists.busybox.net/pipermail/buildroot/2015-January/116241.html

(Unfortunately, the archives for the ML does not sort the mails properly as a thread.)

You can see the current state of my work by browsing the yem/rpi-dt branch on my Buildroot tree:
http://git.buildroot.org/~ymorin/git/buildroot/log/?h=yem/rpi-dt

Quoted 3 lines
Quoted 2 lines

I don't know what the policy of Buildroot should be about accepting crap, but on my side, I will not add such a package to Buildroot.

Anyone with pro/con opinion?

I concur with Thomas.

[--SNIP--]

Quoted 2 lines

My decision for raspberry pi was because of support for (hopefully) good audio out (using the hifiberry dac, but not yet delivered)...

And the overlays for those devices I take care in my patchset. ;-)

Regards,
Yann E. MORIN.

Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
#2 lore raw

PATCH 1/1 Linux kernel module for Waveshare 3.2inch RPi LCD (B) V3 touch controller

Peter, All,

On 2015-01-09 22:40 +0100, Yann E. MORIN spake thusly:

Quoted 1 line

On 2015-01-09 21:21 +0100, Peter Seiderer spake thusly:

[--SNIP--]

Quoted 6 lines
Quoted 2 lines

Maybe the way to go is to wait (or add?) for raspberry pi linux-3.18 kernel support in buildroot with device tree overlay support (see [1],[2])?

I'm working on it, and should be able to submit it shortly. You can see the previous attempt in that thread:

    http://lists.busybox.net/pipermail/buildroot/2015-January/116241.html

I've updated my branch, and have now submitted the series:

    http://lists.busybox.net/pipermail/buildroot/2015-January/116919.html

Regards,
Yann E. MORIN.

Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'