Skip to contentSkip to conversation

package/xz-utils: does not require threads

PATCH New Yann E. MORIN 2 participants 2 messages Jan 9, 2015 – Jan 10, 2015

lore
Share & tools
lore

Yann E. MORIN

author
#0 lore raw

PATCH 1/1 package/xz-utils: does not require threads

Commit 799c12e (xz-utils: needs threads) tried to fix an autobuild failure by requiring threads. But xz-utils can be configured without thread support (even though it is one of the most prominent selling-points of the latest release!).

Signed-off-by "Yann E. MORIN" <[email protected]>
Cc Gustavo Zacarias <[email protected]>
---
 package/xz/Config.in | 4 ----
 package/xz/xz.mk     | 2 ++
 2 files changed, 2 insertions(+), 4 deletions(-)
package/xz/Config.in +0 -4
index 55beb42..50116f2 100644
@@ -1,6 +1,5 @@
 config BR2_PACKAGE_XZ
 	bool "xz-utils"
-	depends on BR2_TOOLCHAIN_HAS_THREADS
 	help
 	  XZ is the successor to the Lempel-Ziv/Markov-chain Algorithm
 	  compression format, which provides memory-hungry but powerful

@@ -13,6 +12,3 @@ config BR2_PACKAGE_XZ
 	  package.
 
 	  http://tukaani.org/xz/
-
-comment "xz-utils needs a toolchain w/ threads"
-	depends on !BR2_TOOLCHAIN_HAS_THREADS
package/xz/xz.mk +2 -0
index 24b1adb..11c15fa 100644
@@ -12,5 +12,7 @@ XZ_CONF_ENV = ac_cv_prog_cc_c99='-std=gnu99'
 XZ_LICENSE = GPLv2+ GPLv3+ LGPLv2.1+
 XZ_LICENSE_FILES = COPYING.GPLv2 COPYING.GPLv3 COPYING.LGPLv2.1
 
+XZ_CONF_OPTS = --enable-threads=$(if $(BR2_TOOLCHAIN_HAS_THREADS),yes,no)
+
 $(eval $(autotools-package))
 $(eval $(host-autotools-package))
Signature · 1 line
1.9.1
#1 lore raw

PATCH 1/1 package/xz-utils: does not require threads

Dear Yann E. MORIN,

Quoted 7 lines · Yann E. MORIN

Commit 799c12e (xz-utils: needs threads) tried to fix an autobuild failure by requiring threads. But xz-utils can be configured without thread support (even though it is one of the most prominent selling-points of the latest release!).

Signed-off-by "Yann E. MORIN" <[email protected]>
Cc Gustavo Zacarias <[email protected]>

Thanks, applied, after doing a minor tweak: use --enable-threads/--disable-threads instead of --enable-threads={yes,no}, to match what we do most often in autotools packages.

Thanks,

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com