Skip to contentSkip to conversation

bootstrap: new package

PATCH New Yegor Yefremov 2 participants 2 messages Jan 9, 2015 – Jan 10, 2015

lore
Share & tools
lore

Yegor Yefremov

author
#0 lore raw

PATCH 1/1 bootstrap: new package

Signed-off-by Yegor Yefremov <[email protected]>
---
 package/Config.in                |  1 +
 package/bootstrap/Config.in      |  7 +++++++
 package/bootstrap/bootstrap.hash |  2 ++
 package/bootstrap/bootstrap.mk   | 22 ++++++++++++++++++++++
 4 files changed, 32 insertions(+)
 create mode 100644 package/bootstrap/Config.in
 create mode 100644 package/bootstrap/bootstrap.hash
 create mode 100644 package/bootstrap/bootstrap.mk
package/Config.in +1 -0
index 5ece4a5..8476773 100644
@@ -740,6 +740,7 @@ menu "Hardware handling"
 endmenu
 
 menu "Javascript"
+	source "package/bootstrap/Config.in"
 	source "package/explorercanvas/Config.in"
 	source "package/flot/Config.in"
 	source "package/jquery/Config.in"
package/bootstrap/Config.in new file +7 -0
new file mode 100644
index 0000000..743d8a3
@@ -0,0 +1,7 @@
+config BR2_PACKAGE_BOOTSTRAP
+	bool "bootstrap"
+	help
+	  Bootstrap is the most popular HTML, CSS, and JS framework
+	  for developing responsive, mobile first projects on the web.
+
+	  http://getbootstrap.com
package/bootstrap/bootstrap.hash new file +2 -0
new file mode 100644
index 0000000..acb06b4
@@ -0,0 +1,2 @@
+# Locally computed:
+sha256  95ca4a02aff37570660c81a87065b53ebc281c33fa86b91a6a7a650eee10678f  bootstrap-3.3.1-dist.zip
package/bootstrap/bootstrap.mk new file +22 -0
new file mode 100644
index 0000000..e78f88b
@@ -0,0 +1,22 @@
+################################################################################
+#
+# bootstrap
+#
+################################################################################
+
+BOOTSTRAP_VERSION = 3.3.1
+BOOTSTRAP_SITE = https://github.com/twbs/bootstrap/releases/download/v$(BOOTSTRAP_VERSION)
+BOOTSTRAP_SOURCE = bootstrap-$(BOOTSTRAP_VERSION)-dist.zip
+BOOTSTRAP_LICENSE = MIT
+
+define BOOTSTRAP_EXTRACT_CMDS
+	unzip $(DL_DIR)/$(BOOTSTRAP_SOURCE) -d $(@D)
+endef
+
+define BOOTSTRAP_INSTALL_TARGET_CMDS
+	mkdir -p $(TARGET_DIR)/var/www/bootstrap
+	$(TAR) c -C $(@D) dist |  \
+		$(TAR) x -C $(TARGET_DIR)/var/www/bootstrap --strip-components=1
+endef
+
+$(eval $(generic-package))
Signature · 1 line
1.9.1
#1 lore raw

PATCH 1/1 bootstrap: new package

Dear Yegor Yefremov,

package/bootstrap/bootstrap.mk line 19

Quoted 4 lines · Yegor Yefremov
package/bootstrap/bootstrap.mk new file +4 -0
+define BOOTSTRAP_INSTALL_TARGET_CMDS
+	mkdir -p $(TARGET_DIR)/var/www/bootstrap
+	$(TAR) c -C $(@D) dist |  \
+		$(TAR) x -C $(TARGET_DIR)/var/www/bootstrap --strip-components=1

This is really a convoluted way of doing:

	cp -dpfr $(@D)/dist/* $(TARGET_DIR)/var/www/bootstrap/

so I've changed to use that instead, and applied.

However, can you submit a follow-up patch to remove the unneeded files from the target? Or copy only the ones that are used? Both the full JS and CSS files are added, in addition to the minimized ones, I don't think that's useful. I'm also not sure what the big .css.map file is.

Can you look into this?

Thanks,

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com