Skip to contentSkip to conversation

ARM: Kirkwood: add DT support for Seagate Goflex Home and CloudEngines Pogoplug E02

PATCH New Andrew Lunn 5 participants 12 messages Aug 10, 2014 – Jan 14, 2015 1 message not in the archive

Subsystems (2)
lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): CAA8MNVjieDJ-dv2NNWXK=+uqrPmvtk2EiBYJGJkMugEiN2TsAw@mail.gmail.com

#1 lore raw

PATCH 2/2 ARM: Kirkwood: add DT support for Seagate Goflex Home and CloudEngines Pogoplug E02

Quoted 2 lines · Oleg Rakhmanov

This patch adds Pogoplug E02 support and to apply clean it depends on the first patch in the series.

Hi Oleg

I don't see any dependencies between the two patches. Even if there is, we treat a two patch series as one entity, and apply them together in order. So you can remove that part of the comment.

Quoted 16 lines

diff -uprN a/arch/arm/boot/dts/kirkwood-pogo_e02.dts b/arch/arm/boot/dts/kirkwood-pogo_e02.dts
--- a/arch/arm/boot/dts/kirkwood-pogo_e02.dts 1969-12-31
17:00:00.000000000 -0700
+++ b/arch/arm/boot/dts/kirkwood-pogo_e02.dts 2014-08-10
03:59:10.616338535 -0600

(quoted diff) +8 -0
@@ -0,0 +1,117 @@
+/dts-v1/;
+
+#include "kirkwood.dtsi"
+#include "kirkwood-6281.dtsi"
+
+/ {
+       model = "CloudEngines Pogoplug E02";
+       compatible = "cloudengines,pogo_e02", "marvell,kirkwood-88f6281",
Quoted 1 line

"marvell,kirkwood";

All vendors should be listed in Documentation/devicetree/bindings/vendor-prefixes.txt. Please could you make a separate patch in this series adding it.

Quoted 8 lines
(quoted diff) +7 -0
+       memory {
+               device_type = "memory";
+               reg = <0x00000000 0x10000000>;
+       };
+
+       chosen {
+               bootargs = "console=ttyS0,115200n8 earlyprintk

root=/dev/sda1 rootdelay=10";

Review

Quoted 10 lines
(quoted diff) +10 -0
+               stdout-path = &uart0;
+       };
+
+       ocp at f1000000 {
+               pinctrl: pin-controller at 10000 {
+                       pmx_usb_power_enable: pmx-usb-power-enable {
+                               marvell,pins = "mpp29";
+                               marvell,function = "gpio";
+                       };
+                       pmx_led_green: pmx-led_green {

Last _ should be -

Review

Quoted 4 lines
(quoted diff) +4 -0
+                               marvell,pins = "mpp48";
+                               marvell,function = "gpio";
+                       };
+                       pmx_led_orange: pmx-led_orange {

Same here.

Quoted 91 lines
(quoted diff) +87 -0
+                               marvell,pins = "mpp49";
+                               marvell,function = "gpio";
+                       };
+               };
+               serial at 12000 {
+                       status = "ok";
+               };
+
+       };
+       gpio-leds {
+               compatible = "gpio-leds";
+               pinctrl-0 = < &pmx_led_orange
+                             &pmx_led_green
+                           >;
+               pinctrl-names = "default";
+
+               health {
+                       label = "status:green:health";
+                       gpios = <&gpio1 16 GPIO_ACTIVE_LOW>;
+                       default-state = "keep";
+               };
+               fault {
+                       label = "status:orange:fault";
+                       gpios = <&gpio1 17 GPIO_ACTIVE_LOW>;
+               };
+       };
+       regulators {
+               compatible = "simple-bus";
+               #address-cells = <1>;
+               #size-cells = <0>;
+               pinctrl-0 = <&pmx_usb_power_enable>;
+               pinctrl-names = "default";
+
+               usb_power: regulator at 1 {
+                       compatible = "regulator-fixed";
+                       reg = <1>;
+                       regulator-name = "USB Power";
+                       regulator-min-microvolt = <5000000>;
+                       regulator-max-microvolt = <5000000>;
+                       enable-active-high;
+                       regulator-always-on;
+                       regulator-boot-on;
+                       gpio = <&gpio0 29 GPIO_ACTIVE_HIGH>;
+               };
+       };
+};
+
+&nand {
+       chip-delay = <25>;
+       status = "okay";
+
+       partition at 0 {
+               label = "u-boot";
+               reg = <0x0000000 0x100000>;
+               read-only;
+       };
+
+       partition at 100000 {
+               label = "uImage";
+               reg = <0x0100000 0x0500000>;
+       };
+
+        partition at 0500000 {
+                label = "pogoplug";
+                reg = <0x0500000 0x2500000>;
+        };
+
+       partition at 2500000 {
+               label = "root";
+               reg = <0x2500000 0x6c00000>;
+       };
+};
+
+&mdio {
+       status = "okay";
+
+       ethphy0: ethernet-phy at 0 {
+               reg = <0>;
+       };
+};
+
+&eth0 {
+       status = "okay";
+       ethernet0-port at 0 {
+               phy-handle = <&ethphy0>;
+       };
+};

diff -uprN a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile

arch/arm/boot/dts/Makefile 2014-08-10 04:00:43.570037020 -0600 kirkwood := \ · line 140

Quoted 4 lines
arch/arm/boot/dts/Makefile 2014-08-10 04:00:43.570037020 -0600 renamed from arch/arm/boot/dts/Makefile 2014-08-10 03:54:22.764885366 -0600 +1 -0
@@ -137,6 +137,7 @@ kirkwood := \
        kirkwood-openrd-base.dtb \
        kirkwood-openrd-client.dtb \
        kirkwood-openrd-ultimate.dtb \
+      kirkwood-pogo_e02.dtb \

Again, there looks to be something odd here.

arch/arm/boot/dts/Makefile 2014-08-10 04:00:43.570037020 -0600 kirkwood := \ · line 143

Quoted 3 lines
arch/arm/boot/dts/Makefile 2014-08-10 04:00:43.570037020 -0600 renamed from arch/arm/boot/dts/Makefile 2014-08-10 03:54:22.764885366 -0600 +0 -0
        kirkwood-rd88f6192.dtb \
        kirkwood-rd88f6281-a0.dtb \
        kirkwood-rd88f6281-a1.dtb \

Thanks
Andrew

#2 lore raw

PATCH 1/1 Added support for pogoplug e02 (pink/gray)

In reply to a message not in the archive

The pogoplug differs from the SheevaPlug only by a few details, but especially in the led assignments. This patch was tested under Gentoo Linux.
A version of this patch was included in Arch Linux on Arm since Jun 2014:
https://github.com/archlinuxarm/PKGBUILDs/commit/250c2f0aa6ffe66c0ebda61efaa356e5dc709cc7
A similar patch is available for OpenWrt:
https://dev.openwrt.org/browser/trunk/target/linux/kirkwood/patches-3.14/150-pogoplug_e02.patch

---
 .../devicetree/bindings/vendor-prefixes.txt        |   1 +
 arch/arm/boot/dts/Makefile                         |   1 +
 arch/arm/boot/dts/kirkwood-pogo_e02.dts            | 114 +++++++++++++++++++++
 3 files changed, 116 insertions(+)
 create mode 100644 arch/arm/boot/dts/kirkwood-pogo_e02.dts
Documentation/devicetree/bindings/vendor-prefixes.txt +1 -0
index ac7269f..e5f58c6 100644
@@ -32,6 +32,7 @@ cdns	Cadence Design Systems Inc.
 chrp	Common Hardware Reference Platform
 chunghwa	Chunghwa Picture Tubes Ltd.
 cirrus	Cirrus Logic, Inc.
+cloudengines	Cloud Engines, Inc.
 cortina	Cortina Systems, Inc.
 crystalfontz	Crystalfontz America, Inc.
 dallas	Maxim Integrated Products (formerly Dallas Semiconductor)
arch/arm/boot/dts/Makefile +1 -0
index b8c5cd3..cd974eb 100644
@@ -143,6 +143,7 @@ dtb-$(CONFIG_MACH_KIRKWOOD) += kirkwood-b3.dtb \
 	kirkwood-openrd-base.dtb \
 	kirkwood-openrd-client.dtb \
 	kirkwood-openrd-ultimate.dtb \
+	kirkwood-pogo_e02.dtb \
 	kirkwood-rd88f6192.dtb \
 	kirkwood-rd88f6281-a0.dtb \
 	kirkwood-rd88f6281-a1.dtb \
arch/arm/boot/dts/kirkwood-pogo_e02.dts new file +114 -0

114 lines not on this page · raw message

Signature · 1 line
2.0.5
maintainer
#3 lore raw

PATCH 1/1 Added support for pogoplug e02 (pink/gray)

Quoted 9 lines · On Sunday 11 January 2015 23:11:01 Christoph Junghans wrote:

The pogoplug differs from the SheevaPlug only by a few details, but especially in the led assignments. This patch was tested under Gentoo Linux.
A version of this patch was included in Arch Linux on Arm since Jun 2014:
https://github.com/archlinuxarm/PKGBUILDs/commit/250c2f0aa6ffe66c0ebda61efaa356e5dc709cc7
A similar patch is available for OpenWrt:
https://dev.openwrt.org/browser/trunk/target/linux/kirkwood/patches-3.14/150-pogoplug_e02.patch

Quoted 3 lines

Very nice, glad someone found the time to do this. Maybe I should buy one now ;-)

arch/arm/boot/dts/kirkwood-pogo_e02.dts line 17

Quoted 4 lines
arch/arm/boot/dts/kirkwood-pogo_e02.dts new file +4 -0
+
+	chosen {
+		bootargs = "console=ttyS0,115200n8 earlyprintk";
+	};

I'd like to move away from using 'earlyprintk' in dts files. Can you remove this here and add a 'stdout-path' property that can be used with 'earlycon'? Unfortunately 3.19 doesn't support earlycon on ARM yet, but I hope to see that working in 3.20 at last.

Arnd

#4 lore raw

PATCH 1/1 Added support for pogoplug e02 (pink/gray)

In reply to Christoph Junghans

arch/arm/boot/dts/kirkwood-pogo_e02.dts

Quoted 49 lines · Christoph Junghans

The pogoplug differs from the SheevaPlug only by a few details, but especially in the led assignments. This patch was tested under Gentoo Linux.
A version of this patch was included in Arch Linux on Arm since Jun 2014:
https://github.com/archlinuxarm/PKGBUILDs/commit/250c2f0aa6ffe66c0ebda61efaa356e5dc709cc7
A similar patch is available for OpenWrt:
https://dev.openwrt.org/browser/trunk/target/linux/kirkwood/patches-3.14/150-pogoplug_e02.patch

---
 .../devicetree/bindings/vendor-prefixes.txt        |   1 +
 arch/arm/boot/dts/Makefile                         |   1 +
 arch/arm/boot/dts/kirkwood-pogo_e02.dts            | 114 +++++++++++++++++++++
 3 files changed, 116 insertions(+)
 create mode 100644 arch/arm/boot/dts/kirkwood-pogo_e02.dts
Documentation/devicetree/bindings/vendor-prefixes.txt +1 -0
index ac7269f..e5f58c6 100644
@@ -32,6 +32,7 @@ cdns	Cadence Design Systems Inc.
 chrp	Common Hardware Reference Platform
 chunghwa	Chunghwa Picture Tubes Ltd.
 cirrus	Cirrus Logic, Inc.
+cloudengines	Cloud Engines, Inc.
 cortina	Cortina Systems, Inc.
 crystalfontz	Crystalfontz America, Inc.
 dallas	Maxim Integrated Products (formerly Dallas Semiconductor)
arch/arm/boot/dts/Makefile +1 -0
index b8c5cd3..cd974eb 100644
@@ -143,6 +143,7 @@ dtb-$(CONFIG_MACH_KIRKWOOD) += kirkwood-b3.dtb \
 	kirkwood-openrd-base.dtb \
 	kirkwood-openrd-client.dtb \
 	kirkwood-openrd-ultimate.dtb \
+	kirkwood-pogo_e02.dtb \
 	kirkwood-rd88f6192.dtb \
 	kirkwood-rd88f6281-a0.dtb \
 	kirkwood-rd88f6281-a1.dtb \
arch/arm/boot/dts/kirkwood-pogo_e02.dts new file +0 -0
new file mode 100644
index 0000000..286a6be
@@ -0,0 +1,114 @@

Hi Christoph

Do you have any idea of the license on this file? Since there is nothing stated, i assume it falls under the general Linux kernel licence, GPL v2. Please could you add a normal GPLv2 header.

Quoted 43 lines
arch/arm/boot/dts/kirkwood-pogo_e02.dts new file +43 -0
+/dts-v1/;
+
+#include "kirkwood.dtsi"
+#include "kirkwood-6281.dtsi"
+
+/ {
+	model = "Cloud Engines Pogoplug E02";
+	compatible = "cloudengines,pogoe02", "marvell,kirkwood-88f6281", "marvell,kirkwood";
+
+	memory {
+		device_type = "memory";
+		reg = <0x00000000 0x10000000>;
+	};
+
+	chosen {
+		bootargs = "console=ttyS0,115200n8 earlyprintk";
+	};
+
+	ocp at f1000000 {
+		pinctrl: pinctrl at 10000 {
+			pmx_usb_power_enable: pmx-usb-power-enable {
+				marvell,pins = "mpp29";
+				marvell,function = "gpio";
+			};
+			pmx_led_green: pmx-led-green {
+				marvell,pins = "mpp48";
+				marvell,function = "gpio";
+			};
+			pmx_led_orange: pmx-led-orange {
+				marvell,pins = "mpp49";
+				marvell,function = "gpio";
+			};
+		};
+		serial at 12000 {
+			status = "ok";
+		};
+	};
+	gpio-leds {
+		compatible = "gpio-leds";
+		pinctrl-0 = < &pmx_usb_power_enable &pmx_led_orange
+			      &pmx_led_green >;
+		pinctrl-names = "default";
+

arch/arm/boot/dts/kirkwood-pogo_e02.dts line 53

Quoted 10 lines
arch/arm/boot/dts/kirkwood-pogo_e02.dts new file +10 -0
+		health {
+			label = "status:green:health";
+			gpios = <&gpio1 16 GPIO_ACTIVE_LOW>;
+			default-state = "keep";
+		};
+		fault {
+			label = "status:orange:fault";
+			gpios = <&gpio1 17 GPIO_ACTIVE_LOW>;
+		};
+	};

Documentation/leds/leds-class.txt says:

LED Device Naming
=================

Is currently of the form:

"devicename:colour:function"

Please could you change status to pogo_e02.

The rest looks good, and thanks for remembering the vendor.txt file.

Andrew

Quoted 69 lines
arch/arm/boot/dts/kirkwood-pogo_e02.dts new file +61 -0
+	regulators {
+		compatible = "simple-bus";
+		#address-cells = <1>;
+		#size-cells = <0>;
+		pinctrl-0 = <&pmx_usb_power_enable>;
+		pinctrl-names = "default";
+
+		usb_power: regulator at 1 {
+			compatible = "regulator-fixed";
+			reg = <1>;
+			regulator-name = "USB Power";
+			regulator-min-microvolt = <5000000>;
+			regulator-max-microvolt = <5000000>;
+			enable-active-high;
+			regulator-always-on;
+			regulator-boot-on;
+			gpio = <&gpio0 29 GPIO_ACTIVE_HIGH>;
+		};
+	};
+};
+
+&nand {
+	chip-delay = <40>;
+	status = "okay";
+
+	partition at 0 {
+		label = "u-boot";
+		reg = <0x0000000 0x100000>;
+		read-only;
+	};
+
+	partition at 100000 {
+		label = "uImage";
+		reg = <0x0100000 0x400000>;
+	};
+
+	partition at 500000 {
+		label = "pogoplug";
+		reg = <0x0500000 0x2000000>;
+	};
+
+	partition at 2500000 {
+		label = "root";
+		reg = <0x02500000 0x5b00000>;
+	};
+};
+
+&mdio {
+	status = "okay";
+
+	ethphy0: ethernet-phy at 0 {
+		reg = <0>;
+	};
+};
+
+&eth0 {
+	status = "okay";
+	ethernet0-port at 0 {
+		phy-handle = <&ethphy0>;
+	};
+};
Signature · 7 lines
2.0.5


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel at lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
#5 lore raw

PATCH 1/1 Added support for pogoplug e02 (pink/gray)

Quoted 3 lines · Andrew Lunn

Do you have any idea of the license on this file? Since there is nothing stated, i assume it falls under the general Linux kernel licence, GPL v2. Please could you add a normal GPLv2 header.

Note that it shouldn't include the FSF mailing address, which has changed several times already. The first two paragraphs of text are fine (suitably modified to specify GPLv2 or GPLv2+).

Signature · 2 lines
FTTC broadband for 0.8mile line: currently at 10.5Mbps down 400kbps up
according to speedtest.net.
#6 lore raw

PATCH 1/1 Added support for pogoplug e02 (pink/gray)

In reply to Christoph Junghans

arch/arm/boot/dts/Makefile

Quoted 32 lines · Christoph Junghans

The pogoplug differs from the SheevaPlug only by a few details, but especially in the led assignments. This patch was tested under Gentoo Linux.
A version of this patch was included in Arch Linux on Arm since Jun 2014:
https://github.com/archlinuxarm/PKGBUILDs/commit/250c2f0aa6ffe66c0ebda61efaa356e5dc709cc7
A similar patch is available for OpenWrt:
https://dev.openwrt.org/browser/trunk/target/linux/kirkwood/patches-3.14/150-pogoplug_e02.patch

---
 .../devicetree/bindings/vendor-prefixes.txt        |   1 +
 arch/arm/boot/dts/Makefile                         |   1 +
 arch/arm/boot/dts/kirkwood-pogo_e02.dts            | 114 +++++++++++++++++++++
 3 files changed, 116 insertions(+)
 create mode 100644 arch/arm/boot/dts/kirkwood-pogo_e02.dts
Documentation/devicetree/bindings/vendor-prefixes.txt +1 -0
index ac7269f..e5f58c6 100644
@@ -32,6 +32,7 @@ cdns	Cadence Design Systems Inc.
 chrp	Common Hardware Reference Platform
 chunghwa	Chunghwa Picture Tubes Ltd.
 cirrus	Cirrus Logic, Inc.
+cloudengines	Cloud Engines, Inc.
 cortina	Cortina Systems, Inc.
 crystalfontz	Crystalfontz America, Inc.
 dallas	Maxim Integrated Products (formerly Dallas Semiconductor)
arch/arm/boot/dts/Makefile +0 -0

Hi Christoph

Please make sure the device tree maintainers see this part of the patch. I added them as Cc:

We can however take this change via mvebu->arm-soc if nobody objects.

Andrew

#7 lore raw

PATCH v2 1/1 Added support for pogoplug e02 (pink/gray)

In reply to a message not in the archive

The pogoplug differs from the SheevaPlug only by a few details, but especially in the led assignments. This patch was tested under Gentoo Linux and is based on dts files from Arch Linux ARM and OpenWrt.

---
 .../devicetree/bindings/vendor-prefixes.txt        |   1 +
 arch/arm/boot/dts/Makefile                         |   1 +
 arch/arm/boot/dts/kirkwood-pogo_e02.dts            | 129 +++++++++++++++++++++
 3 files changed, 131 insertions(+)
 create mode 100644 arch/arm/boot/dts/kirkwood-pogo_e02.dts
Documentation/devicetree/bindings/vendor-prefixes.txt +1 -0
index ac7269f..e5f58c6 100644
@@ -32,6 +32,7 @@ cdns	Cadence Design Systems Inc.
 chrp	Common Hardware Reference Platform
 chunghwa	Chunghwa Picture Tubes Ltd.
 cirrus	Cirrus Logic, Inc.
+cloudengines	Cloud Engines, Inc.
 cortina	Cortina Systems, Inc.
 crystalfontz	Crystalfontz America, Inc.
 dallas	Maxim Integrated Products (formerly Dallas Semiconductor)
arch/arm/boot/dts/Makefile +1 -0
index b8c5cd3..cd974eb 100644
@@ -143,6 +143,7 @@ dtb-$(CONFIG_MACH_KIRKWOOD) += kirkwood-b3.dtb \
 	kirkwood-openrd-base.dtb \
 	kirkwood-openrd-client.dtb \
 	kirkwood-openrd-ultimate.dtb \
+	kirkwood-pogo_e02.dtb \
 	kirkwood-rd88f6192.dtb \
 	kirkwood-rd88f6281-a0.dtb \
 	kirkwood-rd88f6281-a1.dtb \
arch/arm/boot/dts/kirkwood-pogo_e02.dts new file +129 -0

129 lines not on this page · raw message

Signature · 1 line
2.0.5
#8 lore raw

PATCH v2 1/1 Added support for pogoplug e02 (pink/gray)

Quoted 4 lines · Christoph Junghans

The pogoplug differs from the SheevaPlug only by a few details, but especially in the led assignments. This patch was tested under Gentoo Linux and is based on dts files from Arch Linux ARM and OpenWrt.

Hi Christoph

I just tried compiling this with 3.19-rc1:

DTC arch/arm/boot/dts/kirkwood-pogo_e02.dtb
ERROR (duplicate_label): Duplicate label 'pinctrl' on /ocp at f1000000/pinctrl at 10000 and /ocp at f1000000/pin-controller at 10000
ERROR: Input tree has errors, aborting (use -f to force output)

Quoted 4 lines

---

It is normal to say here, after the --- what you have changed since the previous version.

Quoted 11 lines
 .../devicetree/bindings/vendor-prefixes.txt        |   1 +
 arch/arm/boot/dts/Makefile                         |   1 +
 arch/arm/boot/dts/kirkwood-pogo_e02.dts            | 129 +++++++++++++++++++++
 3 files changed, 131 insertions(+)
 create mode 100644 arch/arm/boot/dts/kirkwood-pogo_e02.dts
Documentation/devicetree/bindings/vendor-prefixes.txt +0 -0
index ac7269f..e5f58c6 100644

Documentation/devicetree/bindings/vendor-prefixes.txt cdns Cadence Design Systems Inc. · line 36

Quoted 5 lines
Documentation/devicetree/bindings/vendor-prefixes.txt +1 -0
@@ -32,6 +32,7 @@ cdns	Cadence Design Systems Inc.
 chrp	Common Hardware Reference Platform
 chunghwa	Chunghwa Picture Tubes Ltd.
 cirrus	Cirrus Logic, Inc.
+cloudengines	Cloud Engines, Inc.
 cortina	Cortina Systems, Inc.

This failed to apply. cnm was added Wed May 14 2014, so i guess you are not using 3.19-rc1?

Quoted 41 lines
Documentation/devicetree/bindings/vendor-prefixes.txt +0 -0
 crystalfontz	Crystalfontz America, Inc.
 dallas	Maxim Integrated Products (formerly Dallas Semiconductor)
arch/arm/boot/dts/Makefile +1 -0
index b8c5cd3..cd974eb 100644
@@ -143,6 +143,7 @@ dtb-$(CONFIG_MACH_KIRKWOOD) += kirkwood-b3.dtb \
 	kirkwood-openrd-base.dtb \
 	kirkwood-openrd-client.dtb \
 	kirkwood-openrd-ultimate.dtb \
+	kirkwood-pogo_e02.dtb \
 	kirkwood-rd88f6192.dtb \
 	kirkwood-rd88f6281-a0.dtb \
 	kirkwood-rd88f6281-a1.dtb \
arch/arm/boot/dts/kirkwood-pogo_e02.dts new file +21 -0
new file mode 100644
index 0000000..be38dab
@@ -0,0 +1,129 @@
+/*
+ * kirkwood-sheevaplug.dts - Device tree file for Pogoplug E02
+ *
+ * Copyright (C) 2015 Christoph Junghans <[email protected]>
+ *
+ * based on information of dts files from
+ *  Arch Linux ARM by Oleg Rakhmanov <[email protected]>
+ *  OpenWrt by Felix Kaechele <[email protected]>
+ *
+ * This file is licensed under the terms of the GNU General Public
+ * License version 2.  This program is licensed "as is" without any
+ * warranty of any kind, whether express or implied.
+ */
+
+/dts-v1/;
+
+#include "kirkwood.dtsi"
+#include "kirkwood-6281.dtsi"
+
+/ {
+	model = "Cloud Engines Pogoplug E02";

arch/arm/boot/dts/kirkwood-pogo_e02.dts line 31

Quoted 10 lines
arch/arm/boot/dts/kirkwood-pogo_e02.dts new file +10 -0
+	compatible = "cloudengines,pogoe02", "marvell,kirkwood-88f6281", "marvell,kirkwood";
+
+	memory {
+		device_type = "memory";
+		reg = <0x00000000 0x10000000>;
+	};
+
+	chosen {
+		bootargs = "console=ttyS0,115200n8";
+		linux,stdout-path = &serial1;

This is not what i was expecting. I would expect it to be

                stdout-path = &uart0;
Quoted 7 lines
arch/arm/boot/dts/kirkwood-pogo_e02.dts new file +7 -0
+	};
+
+	ocp at f1000000 {
+		pinctrl: pinctrl at 10000 {
+			pmx_usb_power_enable: pmx-usb-power-enable {
+				marvell,pins = "mpp29";
+				marvell,function = "gpio";

arch/arm/boot/dts/kirkwood-pogo_e02.dts line 48

Quoted 10 lines
arch/arm/boot/dts/kirkwood-pogo_e02.dts new file +10 -0
+			};
+			pmx_led_green: pmx-led-green {
+				marvell,pins = "mpp48";
+				marvell,function = "gpio";
+			};
+			pmx_led_orange: pmx-led-orange {
+				marvell,pins = "mpp49";
+				marvell,function = "gpio";
+			};
+		};

To fix the error above, i suggest you take a look at:

https://lkml.org/lkml/2014/12/28/34

Andrew

Quoted 84 lines
arch/arm/boot/dts/kirkwood-pogo_e02.dts new file +81 -0
+		serial1: serial at 12000 {
+			status = "ok";
+		};
+	};
+	gpio-leds {
+		compatible = "gpio-leds";
+		pinctrl-0 = < &pmx_usb_power_enable &pmx_led_orange
+			      &pmx_led_green >;
+		pinctrl-names = "default";
+
+		health {
+			label = "pogo_e02:green:health";
+			gpios = <&gpio1 16 GPIO_ACTIVE_LOW>;
+			default-state = "keep";
+		};
+		fault {
+			label = "pogo_e02:orange:fault";
+			gpios = <&gpio1 17 GPIO_ACTIVE_LOW>;
+		};
+	};
+	regulators {
+		compatible = "simple-bus";
+		#address-cells = <1>;
+		#size-cells = <0>;
+		pinctrl-0 = <&pmx_usb_power_enable>;
+		pinctrl-names = "default";
+
+		usb_power: regulator at 1 {
+			compatible = "regulator-fixed";
+			reg = <1>;
+			regulator-name = "USB Power";
+			regulator-min-microvolt = <5000000>;
+			regulator-max-microvolt = <5000000>;
+			enable-active-high;
+			regulator-always-on;
+			regulator-boot-on;
+			gpio = <&gpio0 29 GPIO_ACTIVE_HIGH>;
+		};
+	};
+};
+
+&nand {
+	chip-delay = <40>;
+	status = "okay";
+
+	partition at 0 {
+		label = "u-boot";
+		reg = <0x0000000 0x100000>;
+		read-only;
+	};
+
+	partition at 100000 {
+		label = "uImage";
+		reg = <0x0100000 0x400000>;
+	};
+
+	partition at 500000 {
+		label = "pogoplug";
+		reg = <0x0500000 0x2000000>;
+	};
+
+	partition at 2500000 {
+		label = "root";
+		reg = <0x02500000 0x5b00000>;
+	};
+};
+
+&mdio {
+	status = "okay";
+
+	ethphy0: ethernet-phy at 0 {
+		reg = <0>;
+	};
+};
+
+&eth0 {
+	status = "okay";
+	ethernet0-port at 0 {
+		phy-handle = <&ethphy0>;
+	};
+};
Signature · 1 line
2.0.5
#9 lore raw

PATCH v3 1/1 Added support for pogoplug e02 (pink/gray)

In reply to a message not in the archive

From: Christoph Junghans <[email protected]>

The pogoplug differs from the SheevaPlug only by a few details, but especially in the led assignments. This patch was tested under Gentoo Linux and is based on dts files from Arch Linux ARM and OpenWrt.

---

V1: initial patch
V2: added GPL-2 header
dropped earlyprintk from bootargs
added stdout-path
change leds name to scheme "devicename:colour:function"
V3: rebase on v3.19-rc4
fixed stdout-path to be &uart0
fixed compiling issue by using pin-controller

 .../devicetree/bindings/vendor-prefixes.txt        |   1 +
 arch/arm/boot/dts/Makefile                         |   1 +
 arch/arm/boot/dts/kirkwood-pogo_e02.dts            | 129 +++++++++++++++++++++
 3 files changed, 131 insertions(+)
 create mode 100644 arch/arm/boot/dts/kirkwood-pogo_e02.dts
Documentation/devicetree/bindings/vendor-prefixes.txt +1 -0
index b1df0ad..61888db 100644
@@ -34,6 +34,7 @@ chipidea	Chipidea, Inc
 chrp	Common Hardware Reference Platform
 chunghwa	Chunghwa Picture Tubes Ltd.
 cirrus	Cirrus Logic, Inc.
+cloudengines	Cloud Engines, Inc.
 cnm	Chips&Media, Inc.
 cortina	Cortina Systems, Inc.
 crystalfontz	Crystalfontz America, Inc.
arch/arm/boot/dts/Makefile +1 -0
index 91bd5bd..a3463ff 100644
@@ -160,6 +160,7 @@ dtb-$(CONFIG_MACH_KIRKWOOD) += kirkwood-b3.dtb \
 	kirkwood-openrd-base.dtb \
 	kirkwood-openrd-client.dtb \
 	kirkwood-openrd-ultimate.dtb \
+	kirkwood-pogo_e02.dtb \
 	kirkwood-rd88f6192.dtb \
 	kirkwood-rd88f6281-z0.dtb \
 	kirkwood-rd88f6281-a.dtb \
arch/arm/boot/dts/kirkwood-pogo_e02.dts new file +129 -0

129 lines not on this page · raw message

Signature · 1 line
2.0.5
#10 lore raw

PATCH v3 1/1 Added support for pogoplug e02 (pink/gray)

Quoted 12 lines · Christoph Junghans

From: Christoph Junghans <[email protected]>

The pogoplug differs from the SheevaPlug only by a few details, but especially in the led assignments. This patch was tested under Gentoo Linux and is based on dts files from Arch Linux ARM and OpenWrt.

---

Quoted 8 lines

V1: initial patch
V2: added GPL-2 header
dropped earlyprintk from bootargs
added stdout-path
change leds name to scheme "devicename:colour:function"
V3: rebase on v3.19-rc4
fixed stdout-path to be &uart0
fixed compiling issue by using pin-controller

Hi Christoph

Thanks for adding this list of changes.

Quoted 6 lines
arch/arm/boot/dts/kirkwood-pogo_e02.dts new file +6 -0
+
+	ocp at f1000000 {
+		pinctrl: pin-controller at 10000 {
+			pmx_usb_power_enable: pmx-usb-power-enable {
+				marvell,pins = "mpp29";
+				marvell,function = "gpio";

arch/arm/boot/dts/kirkwood-pogo_e02.dts line 48

Quoted 10 lines
arch/arm/boot/dts/kirkwood-pogo_e02.dts new file +10 -0
+			};
+			pmx_led_green: pmx-led-green {
+				marvell,pins = "mpp48";
+				marvell,function = "gpio";
+			};
+			pmx_led_orange: pmx-led-orange {
+				marvell,pins = "mpp49";
+				marvell,function = "gpio";
+			};
+		};

Sorry, should of made myself more clear, when i pointed at:

https://lkml.org/lkml/2014/12/28/34

Please use the label for pinctl, and don't nest it under ocp at f1000000.

arch/arm/boot/dts/kirkwood-pogo_e02.dts line 52

Quoted 4 lines
arch/arm/boot/dts/kirkwood-pogo_e02.dts new file +4 -0
+		serial at 12000 {
+			status = "ok";
+		};
+	};

Same here, just

&uart0 {
	status = "okay";
};

Doing it like this is somewhat new, so most of the other kirkwood boards don't do this. But we would like all new boards to use this layout.

Thanks
Andrew

#11 lore raw

PATCH v4 1/1 Added support for pogoplug e02 (pink/gray)

In reply to a message not in the archive

The pogoplug differs from the SheevaPlug only by a few details, but especially in the led assignments. This patch was tested under Gentoo Linux and is based on dts files from Arch Linux ARM and OpenWrt.

---

V1: initial patch
V2: added GPL-2 header
dropped earlyprintk from bootargs
added stdout-path
change leds name to scheme "devicename:colour:function"
V3: rebase on v3.19-rc4
fixed stdout-path to be &uart0
fixed compiling issue by using pin-controller
V4: moved ocp at f1000000 block into &uart and &pinctrl

 .../devicetree/bindings/vendor-prefixes.txt        |   1 +
 arch/arm/boot/dts/Makefile                         |   1 +
 arch/arm/boot/dts/kirkwood-pogo_e02.dts            | 133 +++++++++++++++++++++
 3 files changed, 135 insertions(+)
 create mode 100644 arch/arm/boot/dts/kirkwood-pogo_e02.dts
Documentation/devicetree/bindings/vendor-prefixes.txt +1 -0
index b1df0ad..61888db 100644
@@ -34,6 +34,7 @@ chipidea	Chipidea, Inc
 chrp	Common Hardware Reference Platform
 chunghwa	Chunghwa Picture Tubes Ltd.
 cirrus	Cirrus Logic, Inc.
+cloudengines	Cloud Engines, Inc.
 cnm	Chips&Media, Inc.
 cortina	Cortina Systems, Inc.
 crystalfontz	Crystalfontz America, Inc.
arch/arm/boot/dts/Makefile +1 -0
index 91bd5bd..a3463ff 100644
@@ -160,6 +160,7 @@ dtb-$(CONFIG_MACH_KIRKWOOD) += kirkwood-b3.dtb \
 	kirkwood-openrd-base.dtb \
 	kirkwood-openrd-client.dtb \
 	kirkwood-openrd-ultimate.dtb \
+	kirkwood-pogo_e02.dtb \
 	kirkwood-rd88f6192.dtb \
 	kirkwood-rd88f6281-z0.dtb \
 	kirkwood-rd88f6281-a.dtb \
arch/arm/boot/dts/kirkwood-pogo_e02.dts new file +133 -0

133 lines not on this page · raw message

Signature · 1 line
2.0.5
#12 lore raw

PATCH v4 1/1 Added support for pogoplug e02 (pink/gray)

Quoted 10 lines · Christoph Junghans

The pogoplug differs from the SheevaPlug only by a few details, but especially in the led assignments. This patch was tested under Gentoo Linux and is based on dts files from Arch Linux ARM and OpenWrt.

---

Quoted 9 lines

V1: initial patch
V2: added GPL-2 header
dropped earlyprintk from bootargs
added stdout-path
change leds name to scheme "devicename:colour:function"
V3: rebase on v3.19-rc4
fixed stdout-path to be &uart0
fixed compiling issue by using pin-controller
V4: moved ocp at f1000000 block into &uart and &pinctrl

Hi Christoph

Thanks for these last changes. It looks good now, and i've added it to mvebu/dt. So long as there are no more comments, i will pass it upstream soon.

Thanks
Andrew