out out damn perl

Commit e6023367d779 added perl back to the kernel build in -rc6. Replace 39 lines of perl with 4 lines of shell script.

From: Rob Landley <[email protected]>

Commit e6023367d779 ("x86, kaslr: Prevent .bss from overlaping initrd") added perl back to the kernel build dependencies in -rc6.

Replace those 39 lines of perl with 4 lines of shell script.

Signed-off-by Rob Landley <[email protected]>

Acked-by Anca Emanuel <[email protected]>

---

 arch/x86/boot/compressed/Makefile |    6 ++--
 arch/x86/tools/calc_run_size.pl   |   39 ----------------------------
 2 files changed, 4 insertions(+), 41 deletions(-)

Note: checkpatch.pl isn't a build dependency, it's a development dependency (like bloat-o-meter being written in python or "make xconfig" needing QT). Those aren't things you need to add to your cross compile environment to produce a binary. Different category of dependency.

For more history on the issue, see https://lkml.org/lkml/2013/2/27/18

arch/x86/boot/compressed/Makefile +0 -0

@@ -89,8 +76,10 @@
 suffix-$(CONFIG_KERNEL_LZO)    := lzo

arch/x86/tools/calc_run_size.pl deleted +0 -39

@@ -1,39 +0,0 @@
-#!/usr/bin/perl
-#
-# Calculate the amount of space needed to run the kernel, including room for
-# the .bss and .brk sections.
-#
-# Usage:
-# objdump -h a.out | perl calc_run_size.pl
-use strict;
-
-my $mem_size = 0;
-my $file_offset = 0;
-
-my $sections=" *[0-9]+ \.(?:bss|brk) +";
-while (<>) {
-       if (/^$sections([0-9a-f]+) +(?:[0-9a-f]+ +){2}([0-9a-f]+)/) {
-               my $size = hex($1);
-               my $offset = hex($2);
-               $mem_size += $size;
-               if ($file_offset == 0) {
-                       $file_offset = $offset;
-               } elsif ($file_offset != $offset) {
-                       # BFD linker shows the same file offset in ELF.
-                       # Gold linker shows them as consecutive.
-                       next if ($file_offset + $mem_size == $offset + $size);
-
-                       printf STDERR "file_offset: 0x%lx\n", $file_offset;
-                       printf STDERR "mem_size: 0x%lx\n", $mem_size;
-                       printf STDERR "offset: 0x%lx\n", $offset;
-                       printf STDERR "size: 0x%lx\n", $size;
-
-                       die ".bss and .brk are non-contiguous\n";
-               }
-       }
-}
-
-if ($file_offset == 0) {
-       die "Never found .bss or .brk file offset\n";
-}
-printf("%d\n", $mem_size + $file_offset);

Quoted 2 lines · On Tue, 06 Jan 2015 17:41:35 -0600 Rob Landley <[email protected]> wrote:

Commit e6023367d779 added perl back to the kernel build in -rc6. Replace 39 lines of perl with 4 lines of shell script.

Please resend this:

- Express the commit in the conventional fashion

e6023367d779 ("x86, kaslr: Prevent .bss from overlaping initrd")

- So that we all don't have to go look up the commit to find out what happened.

- So people can look up the commit in other trees, where the hash might change.

- Cc the people who wrote and committed the patch.

- The offending commit has cc:stable, so have a think about adding a cc:stable to this one as well.

- The title is cute, but not terribly informative.

Quoted 17 lines · Andrew Morton

Quoted 2 lines · On Tue, 06 Jan 2015 17:41:35 -0600 Rob Landley <[email protected]> wrote:

Commit e6023367d779 added perl back to the kernel build in -rc6. Replace 39 lines of perl with 4 lines of shell script.

Please resend this:

- Express the commit in the conventional fashion

e6023367d779 ("x86, kaslr: Prevent .bss from overlaping initrd")

- So that we all don't have to go look up the commit to find out what happened.

- So people can look up the commit in other trees, where the hash might change.

Quoted 4 lines

- Cc the people who wrote and committed the patch.

- The offending commit has cc:stable, so have a think about adding a cc:stable to this one as well.

Actually, I don't think this should go to stable. I like the patch, but it is not a bug, and certainly not serious enough one.

Quoted 4 lines · Andrew Morton

Quoted 2 lines · On Tue, 06 Jan 2015 17:41:35 -0600 Rob Landley <[email protected]> wrote:

Commit e6023367d779 added perl back to the kernel build in -rc6. Replace 39 lines of perl with 4 lines of shell script.

Quoted 2 lines

- The offending commit has cc:stable, so have a think about adding a cc:stable to this one as well.

Actually, I don't think this should go to stable. I like the patch, but it is not a bug, and certainly not serious enough one.

From: Rob Landley <[email protected]>

Commit e6023367d779 added perl back to the kernel build in -rc6. Replace 39 lines of perl with 4 lines of shell script.

Quoted 4 lines · Rob Landley

From: Rob Landley <[email protected]>

Commit e6023367d779 added perl back to the kernel build in -rc6. Replace 39 lines of perl with 4 lines of shell script.

Maybe checkpatch should be updated to look for perl. :)

Quoted 4 lines · Rob Landley

From: Rob Landley <[email protected]>

Commit e6023367d779 added perl back to the kernel build in -rc6. Replace 39 lines of perl with 4 lines of shell script.

Maybe checkpatch should be updated to look for perl. :)

Quoted 7 lines · Lennart Sorensen

Quoted 4 lines · Rob Landley

From: Rob Landley <[email protected]>

Commit e6023367d779 added perl back to the kernel build in -rc6. Replace 39 lines of perl with 4 lines of shell script.

Maybe checkpatch should be updated to look for perl. :)

Yeah, then checkpatch.pl warn on itself. ;-)

Quoted 8 lines

Quoted 6 lines · Lennart Sorensen

Quoted 4 lines · Rob Landley

From: Rob Landley <[email protected]>

Commit e6023367d779 added perl back to the kernel build in -rc6. Replace 39 lines of perl with 4 lines of shell script.

Quoted 3 lines

Quoted 1 line

Maybe checkpatch should be updated to look for perl. :)

Yeah, then checkpatch.pl warn on itself. ;-)

There's a difference between a development tool and a build tool. We have "make xconfig" and "make gconfig" but don't require qt and gtk to both be in your cross compile environment in order to build the kernel.